8000 chore: resolve overindented doc list items by brody4hire · Pull Request #2326 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: resolve overindented doc list items #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

brody4hire
Copy link
Contributor

Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

Copy link
codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (fd92926) to head (abf793e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2326   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files         103      103           
  Lines       24204    24204           
=======================================
  Hits        22965    22965           
  Misses       1239     1239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
rustls-benchmarking bot commented Feb 5, 2025

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand 8000
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8288653 8225010 -63643 (-0.77%) 0.80%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8280688 8252145 -28543 (-0.34%) 0.81%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10692683 10713616 20933 (0.20%) 1.28%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10435959 10430728 -5231 (-0.05%) 0.99%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10718361 10722758 4397 (0.04%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3079666 3080565 899 (0.03%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1175350 1175276 -74 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1172989 1173059 70 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623332 3623370 38 (0.00%) 0.22%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624741 3624703 -38 (-0.00%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3080795 3080827 32 (0.00%) 0.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27857253 27857542 289 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27797760 27798031 271 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2163936 2163951 15 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28195402 28195212 -190 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28895619 28895442 -177 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27861852 27861682 -170 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30432825 30433006 181 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30433205 30433342 137 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28897786 28897914 128 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28897709 28897831 122 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28224886 28225000 114 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30430451 30430349 -102 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28221809 28221719 -90 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28973788 28973877 89 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27795380 27795312 -68 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30390288 30390214 -74 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28198870 28198938 68 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1716239 1716235 -4 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1924272 1924268 -4 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1931018 1931014 -4 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27854779 27854733 -46 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28192091 28192046 -45 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28975980 28976009 29 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30387903 30387933 30 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27802384 27802359 -25 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28228714 28228703 -11 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28976145 28976134 -11 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180730 35180743 13 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7562933 7562931 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46471416 46471426 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46460635 46460628 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46457667 46457661 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92668574 92668584 10 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46377330 46377334 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465290 46465286 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58175581 58175576 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92702764 92702771 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235402 58235398 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92657674 92657680 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92666749 92666743 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92698762 92698767 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58237486 58237483 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58325517 58325514 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641988 80641991 3 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30390615 30390616 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80535991 80535993 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80541184 80541182 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407042 46407043 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46468536 46468537 1 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58219741 58219740 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58232525 58232524 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58332661 58332662 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80644956 80644955 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80649614 80649613 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80536384 80536384 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41612931 41612931 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40513549 40513549 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41974270 41974270 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7565075 7565075 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40587739 40587739 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4499013 4499013 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40198982 40198982 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3874375 3874375 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41976758 41976758 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1610604 1610604 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2660168 2660168 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4238499 4238499 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2561940 2561940 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3874155 3874155 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40516810 40516810 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ec 8000 dsap384_chacha_server 41494719 41494719 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40297353 40297353 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40595000 40595000 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46468144 46468144 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42075098 42075098 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41976568 41976568 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5021182 5021182 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40520810 40520810 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4235170 4235170 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4699410 4699410 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2654301 2654301 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58336414 58336414 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41612979 41612979 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41492560 41492560 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182637 35182637 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41610820 41610820 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40591000 40591000 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11429435 11429435 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1611977 1611977 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41494671 41494671 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40290359 40290359 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11290925 11290925 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40203033 40203033 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40196039 40196039 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2160797 2160797 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4216459 4216459 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42072610 42072610 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92696531 92696531 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11423480 11423480 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40293302 40293302 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42074908 42074908 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.44 ms 4.49 ms 0.05 ms (1.16%) 5.70%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 455.31 µs 460.00 µs 4.69 µs (1.03%) 3.32%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.15 ms 5.20 ms 0.05 ms (1.00%) 4.90%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.12 ms 5.18 ms 0.05 ms (0.98%) 7.26%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.07 ms 5.11 ms 0.05 ms (0.95%) 6.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 457.96 µs 462.01 µs 4.05 µs (0.89%) 4.01%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.67 ms 1.68 ms 0.01 ms (0.80%) 2.49%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.29 ms 6.34 ms 0.05 ms (0.79%) 4.49%
transfer_no_resume_ring_1.3_rsa_aes 6.78 ms 6.83 ms 0.05 ms (0.79%) 3.87%
handshake_no_resume_ring_1.3_ecdsap256_chacha 497.38 µs 501.19 µs 3.82 µs (0.77%) 2.99%
handshake_no_resume_ring_1.3_ecdsap256_aes 501.05 µs 504.86 µs 3.81 µs (0.76%) 2.36%
transfer_no_resume_ring_1.2_rsa_aes 6.71 ms 6.76 ms 0.05 ms (0.71%) 3.83%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.40 ms 9.45 ms 0.05 ms (0.56%) 2.88%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.61 ms 0.01 ms (0.45%) 1.92%
handshake_no_resume_ring_1.3_rsa_chacha 991.57 µs 995.80 µs 4.24 µs (0.43%) 1.34%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.99 ms 0.05 ms (0.42%) 2.26%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.48 ms 0.06 ms (0.41%) 2.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.91 ms 12.96 ms 0.05 ms (0.41%) 2.45%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.61 ms 13.66 ms 0.05 ms (0.40%) 2.19%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.53 ms 0.01 ms (0.39%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 991.69 µs 995.51 µs 3.83 µs (0.39%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.14 ms 1.14 ms 0.00 ms (0.38%) 6.16%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.32 ms 4.34 ms 0.02 ms (0.37%) 1.87%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.16 ms 1.17 ms 0.00 ms (0.36%) 1.04%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.61 ms 13.65 ms 0.05 ms (0.35%) 2.84%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.03 ms 5.04 ms 0.02 ms (0.35%) 1.73%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.13 ms 1.14 ms 0.00 ms (0.35%) 2.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.16 ms 1.16 ms 0.00 ms (0.33%) 1.09%
handshake_no_resume_ring_1.2_rsa_aes 989.69 µs 992.87 µs 3.18 µs (0.32%) 1.28%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.39 ms 6.41 ms 0.02 ms (0.32%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 16.10 ms 0.05 ms (0.31%) 1.69%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.10 ms 1.11 ms 0.00 ms (0.28%) 6.65%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.31 ms 6.33 ms 0.02 ms (0.28%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.98 ms 4.99 ms 0.01 ms (0.27%) 1.45%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.02 ms 5.04 ms 0.01 ms (0.27%) 1.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.24 ms 0.01 ms (0.25%) 1.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.49 ms 4.50 ms 0.01 ms (0.24%) 1.70%
handshake_tickets_ring_1.3_rsa_chacha 6.88 ms 6.89 ms 0.02 ms (0.23%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.29 ms 4.30 ms 0.01 ms (0.22%) 1.85%
handshake_tickets_ring_1.3_ecdsap256_aes 6.44 ms 6.46 ms 0.01 ms (0.22%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.53 ms 4.54 ms 0.01 ms (0.21%) 2.08%
handshake_tickets_ring_1.3_rsa_aes 6.93 ms 6.95 ms 0.01 ms (0.21%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.37 ms 6.38 ms 0.01 ms (0.20%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.85 ms 1.85 ms 0.00 ms (0.19%) 4.59%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.22 ms 5.23 ms 0.01 ms (0.16%) 1.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.19 ms 5.20 ms 0.01 ms (0.16%) 1.63%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.20 ms 5.20 ms 0.01 ms (0.14%) 1.79%
handshake_session_id_ring_1.3_rsa_chacha 6.81 ms 6.82 ms 0.01 ms (0.13%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.12%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.42 ms 9.43 ms 0.01 ms (0.11%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.00 ms 5.00 ms 0.01 ms (0.11%) 1.91%
handshake_tickets_ring_1.3_ecdsap384_aes 9.53 ms 9.54 ms 0.01 ms (0.10%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.49 ms 9.49 ms 0.01 ms (0.08%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.61 ms 0.00 ms (0.08%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.87 ms 6.88 ms 0.01 ms (0.08%) 1.05%
handshake_session_id_ring_1.3_ecdsap384_aes 9.47 ms 9.48 ms 0.01 ms (0.05%) 1.00%

Additional information

Historical results

Checkout details:

@djc djc added this pull request to the merge queue Feb 5, 2025
Merged via the queue into rustls:main with commit abf793e Feb 5, 2025
53 checks passed
@brody4hire brody4hire deleted the resolve-overindented-doc-list-items branch February 5, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0