8000 chore(ci): fix formatting of Taplo job by brody4hire · Pull Request #2328 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(ci): fix formatting of Taplo job #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

brody4hire
Copy link
Contributor

extra indenting was introduced by myself in PR #2307, should be fixed by this

Copy link
codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (fd92926) to head (4e84a35).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2328   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files         103      103           
  Lines       24204    24204           
=======================================
  Hits        22965    22965           
  Misses       1239     1239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc djc added this pull request to the merge queue Feb 5, 2025
Copy link

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1173063 1177609 ⚠️ 4546 (0.39%) 0.20%

Other differences

Click to expand 8000
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10414425 10495687 81262 (0.78%) 0.99%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080215 3084941 4726 (0.15%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3076838 3080807 3969 (0.13%) 0.28%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3618997 3620975 1978 (0.05%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8283587 8280712 -2875 (-0.03%) 0.80%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10684051 10682166 -1885 (-0.02%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10727356 10726297 -1059 (-0.01%) 1.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8278697 8277945 -752 (-0.01%) 0.81%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1716239 1716281 42 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624779 3624855 76 (0.00%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2160881 2160839 -42 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1175369 1175354 -15 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1924272 1924287 15 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27854775 27854968 193 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27797987 27797810 -177 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28975923 28976075 152 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28192152 28192292 140 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28973788 28973666 -122 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30430331 30430458 127 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30433280 30433178 -102 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28897589 28897678 89 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28221892 28221816 -76 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27857314 27857387 73 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28895464 28895539 75 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7565093 7565075 -18 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28228721 28228654 -67 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28195018 28195079 61 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30433009 30432949 -60 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2163840 2163844 4 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30387756 30387810 54 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30390381 30390337 -44 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182685 35182637 -48 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28897769 28897730 -39 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1610601 1610603 2 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28976045 28976010 -35 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28198985 28199015 30 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30390658 30390683 25 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27861808 27861791 -17 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180730 35180715 -15 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7562933 7562930 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46460637 46460628 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465285 46465294 9 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28224825 28224830 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46471426 46471418 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46468153 46468147 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58175579 58175572 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80649614 80649605 -9 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27795400 27795403 3 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46377335 46377330 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407043 46407038 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92668573 92668582 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80535985 80535991 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92702771 92702765 -6 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27802295 27802296 1 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58219740 58219742 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58232523 58232525 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58332659 58332661 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92666742 92666739 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92696525 92696522 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92698759 92698762 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80541178 80541176 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46468536 46468537 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58237484 58237483 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58325513 58325514 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58336415 58336416 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641982 80641983 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80644954 80644955 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92657679 92657680 1 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4499013 4499013 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4235170 4235170 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40591000 40591000 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4238499 4238499 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11423480 11423480 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40595000 40595000 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5021182 5021182 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11429435 11429435 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42075098 42075098 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40587739 40587739 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42072610 42072610 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42074908 42074908 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235401 58235401 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80536382 80536382 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40290359 40290359 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4699410 4699410 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40196039 40196039 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2654301 2654301 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40203033 40203033 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41610820 41610820 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2561940 2561940 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41612979 41612979 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40516810 40516810 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40297353 40297353 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4216459 4216459 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11290925 11290925 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41494719 41494719 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40513549 40513549 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40198982 40198982 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1931014 1931014 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41494671 41494671 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41974270 41974270 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41612931 41612931 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41492560 41492560 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41976758 41976758 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40293302 40293302 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1611977 1611977 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41976568 419765680 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40520810 40520810 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3874155 3874155 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46457664 46457664 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2660168 2660168 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3874375 3874375 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.33 ms 4.30 ms -0.03 ms (-0.75%) 1.83%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.03 ms 5.00 ms -0.03 ms (-0.65%) 1.89%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.53 ms 4.50 ms -0.03 ms (-0.56%) 1.48%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.02 ms 4.99 ms -0.03 ms (-0.56%) 1.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.36 ms 4.34 ms -0.02 ms (-0.56%) 1.87%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.06 ms 5.04 ms -0.03 ms (-0.53%) 1.73%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.56 ms 4.54 ms -0.02 ms (-0.51%) 2.08%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.22 ms 5.20 ms -0.03 ms (-0.51%) 1.79%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.26 ms 5.24 ms -0.02 ms (-0.45%) 1.39%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.25 ms 5.23 ms -0.02 ms (-0.45%) 1.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.22 ms 5.20 ms -0.02 ms (-0.44%) 1.59%
handshake_tickets_ring_1.2_rsa_aes 1.62 ms 1.61 ms -0.01 ms (-0.42%) 1.92%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.06 ms 5.04 ms -0.02 ms (-0.37%) 1.23%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.62 ms 3.61 ms -0.01 ms (-0.31%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.14 ms 1.15 ms 0.00 ms (0.30%) 6.15%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.60 ms -0.01 ms (-0.29%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.53 ms 1.53 ms -0.00 ms (-0.19%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.85 ms 1.85 ms -0.00 ms (-0.19%) 4.58%
handshake_session_id_ring_1.3_ecdsap256_aes 6.39 ms 6.38 ms -0.01 ms (-0.19%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.10 ms 1.11 ms 0.00 ms (0.18%) 6.46%
handshake_session_id_ring_1.3_ecdsap384_aes 9.50 ms 9.48 ms -0.02 ms (-0.18%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.49 ms -0.01 ms (-0.16%) 4.88%
handshake_session_id_ring_1.3_rsa_aes 6.89 ms 6.87 ms -0.01 ms (-0.16%) 1.05%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.13 ms 1.14 ms 0.00 ms (0.16%) 2.52%
handshake_no_resume_ring_1.2_rsa_aes 994.18 µs 992.61 µs -1.57 µs (-0.16%) 1.25%
handshake_no_resume_ring_1.3_ecdsap256_chacha 501.66 µs 500.90 µs -0.76 µs (-0.15%) 2.95%
handshake_no_resume_ring_1.3_ecdsap256_aes 505.47 µs 504.71 µs -0.76 µs (-0.15%) 2.12%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 459.85 µs 459.20 µs -0.65 µs (-0.14%) 3.30%
handshake_tickets_ring_1.3_ecdsap256_aes 6.46 ms 6.45 ms -0.01 ms (-0.12%) 1.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.12 ms -0.01 ms (-0.11%) 6.38%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.44 ms 9.43 ms -0.01 ms (-0.11%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.51 ms 9.50 ms -0.01 ms (-0.08%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.95 ms 6.95 ms -0.01 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.82 ms 6.82 ms -0.00 ms (-0.07%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.11 ms 16.10 ms -0.01 ms (-0.07%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.16 ms 1.16 ms -0.00 ms (-0.06%) 1.06%
transfer_no_resume_ring_1.3_rsa_aes 6.84 ms 6.84 ms 0.00 ms (0.05%) 3.71%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.17 ms 1.17 ms -0.00 ms (-0.05%) 1.02%
handshake_no_resume_ring_1.3_rsa_aes 995.29 µs 995.82 µs 0.53 µs (0.05%) 1.22%
handshake_tickets_ring_1.3_ecdsap384_aes 9.56 ms 9.55 ms -0.00 ms (-0.05%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.45 ms 9.46 ms 0.00 ms (0.04%) 2.75%
handshake_no_resume_ring_1.3_rsa_chacha 995.49 µs 995.13 µs -0.36 µs (-0.04%) 1.34%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.20 ms -0.00 ms (-0.03%) 4.44%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.48 ms 0.00 ms (0.03%) 1.76%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.18 ms 5.18 ms -0.00 ms (-0.03%) 7.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 461.20 µs 461.05 µs -0.14 µs (-0.03%) 3.88%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.96 ms 12.97 ms 0.00 ms (0.03%) 2.43%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.66 ms 13.66 ms -0.00 ms (-0.03%) 2.84%
transfer_no_resume_ring_1.2_rsa_aes 6.76 ms 6.77 ms 0.00 ms (0.03%) 3.70%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.41 ms 6.41 ms 0.00 ms (0.02%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.68 ms 1.68 ms 0.00 ms (0.02%) 2.42%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.33 ms 6.33 ms 0.00 ms (0.01%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.99 ms 12.99 ms -0.00 ms (-0.01%) 2.22%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.34 ms -0.00 ms (-0.00%) 4.30%
handshake_tickets_ring_1.3_rsa_chacha 6.89 ms 6.89 ms -0.00 ms (-0.00%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.66 ms 13.66 ms 0.00 ms (0.00%) 2.05%

Additional information

Historical results

Checkout details:

Merged via the queue into rustls:main with commit 6ee9aca Feb 5, 2025
33 checks passed
@brody4hire brody4hire deleted the chore-fix-formatting-of-ci-taplo-job branch February 5, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0