unbuffered: do not prematurely consume data #2338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2338 +/- ##
==========================================
- Coverage 94.89% 94.89% -0.01%
==========================================
Files 103 103
Lines 24274 24292 +18
==========================================
+ Hits 23034 23051 +17
- Misses 1240 1241 +1 ☔ View full report in Codecov by Sentry. |
68062c6 to
ece443f
Compare
djc
approved these changes
Feb 18, 2025
| } else { | ||
| self.taken = true; | ||
| Some(Ok(AppDataRecord { | ||
| self.chunk = self |
There was a problem hiding this comment.
On ReadTraffic Drop, should we put back the chunk if Some?
(I guess this is covered by your commit message saying that next_record() remains one-shot.)
There was a problem hiding this comment.
No. This is the point at which the chunk is consumed. We need to save it in self.chunk to get a place for AppDataRecord to borrow from.
Previously, the point at the application is given a `ReadTraffic` state is when the data is consumed. That meant `ReadTraffic::peek_len()` was too late for an application to decide not to accept the data just yet. Note that `ReadTraffic::next_record()` remains one-shot, as there is at most one item in `received_plaintext` in unbuffered mode.
ece443f to
7da79ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters
ReadTrafficandReadEarlyDataso that theirnext_record()functions are where the data is consumed, allowingpeek_len()functions work as intended.fixes #2031