unbuffered: introduce PeerClosed state
#2332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 103 103
Lines 24201 24216 +15
=======================================
+ Hits 22962 22977 +15
Misses 1239 1239 ☔ View full report in Codecov by Sentry. |
cpu
approved these changes
Feb 10, 2025
rustls/src/conn/unbuffered.rs
Outdated
| @@ -131,6 +131,18 @@ impl<Data> UnbufferedConnectionCommon<Data> { | |||
| .core | |||
| .common_state | |||
| .has_received_close_notify | |||
| && !self.emitted_peer_closed | |||
There was a problem hiding this comment.
I'm starting to find the big chain of if/else if's and their relatively complicated boolean expressions tricky to follow. It's quite dense.
I don't think it's necessary to clean up in this branch but I wonder if we could lift out some intermediate vars at the minimum so that the density is reduced a little bit.
There was a problem hiding this comment.
Yeah, agree. Even though I find the way the early data state is injected into process_tls_records_common a bit distasteful as a special case, I think actually it's a good direction to split the logic up a bit.
There was a problem hiding this comment.
Would suggest taking that out of this PR, though.
d39c910 to
868873a
Compare
Reduce rightward drift and prefer match to trivial if-let.
`Closed` is now bi-directional, terminal closure state.
868873a to
bf34465
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closedwas, and remains, the bi-directional, terminal closure state.Because
rustls::unbuffered::ConnectionStateis anon_exhaustiveenum, this is not a breaking API change. However, it demands a clear release note because downstream users will now encounter the new state.fixes #1895