8000 docs: fix MSRV etc. by brody4hire · Pull Request #2346 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: fix MSRV etc. #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

docs: fix MSRV etc. #2346

merged 1 commit into from
Feb 19, 2025

Conversation

brody4hire
Copy link
Contributor

No description provided.

@codecov Codecov
10000 Copy link
codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (f4fc28a) to head (72ddc10).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2346   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files         103      103           
  Lines       24205    24205           
=======================================
  Hits        22967    22967           
  Misses       1238     1238

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brody4hire brody4hire mentioned this pull request Feb 19, 2025
Open
@djc djc added this pull request to the merge queue Feb 19, 2025
@rustls-benchmarking Rustls Benchmarking
Copy link

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10739670 10697304 -42366 (-0.39%) 0.95%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8303768 8275182 -28586 (-0.34%) 1.30%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10445746 10459665 13919 (0.13%) 0.86%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3296344 3298770 2426 (0.07%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8297054 8291633 -5421 (-0.07%) 0.88%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3299935 3301996 2061 (0.06%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080116 3078503 -1613 (-0.05%) 0.63%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3082494 3082916 422 (0.01%) 0.35%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10713410 10714463 1053 (0.01%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1143825 1143844 19 (0.00%) 1.53%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1924377 1924396 19 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2059387 2059406 19 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27787025 27787270 245 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30436163 30436363 200 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28903098 28903282 184 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27793847 27793965 118 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28190524 28190643 119 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27789607 27789491 -116 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1146118 1146122 4 (0.00%) 0.55%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28981618 28981529 -89 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27853385 27853305 -80 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28979367 28979444 77 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27846448 27846520 72 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1716246 1716242 -4 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28183769 28183705 -64 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28213428 28213492 64 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2062432 2062436 4 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30393449 30393499 50 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295801 1295799 -2 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28216630 28216588 -42 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30396345 30396388 43 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229602 7229592 -10 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27848977 27849011 34 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30438730 30438758 28 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28981430 28981405 -25 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28900891 28900912 21 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34740255 34740230 -25 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28220346 28220326 -20 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30396061 30396077 16 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28903210 28903224 14 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30439083 30439070 -13 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34738339 34738352 13 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28186752 28186762 10 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227434 7227432 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465933 46465925 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234451 58234443 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548536 80548545 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650248 80650255 7 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46148660 46148656 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92680095 92680103 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58075913 58075918 5 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57980059 57980055 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58083704 58083700 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58174932 58174936 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46253819 46253816 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407679 46407682 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58239403 58239406 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92678265 92678269 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92698445 92698441 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458305 46458303 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461268 46461266 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58237322 58237320 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553338 80553336 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92669199 92669201 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92704691 92704689 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541809 80541810 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642626 80642627 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645593 80645594 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92700683 92700684 1 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336195 2336195 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32263629 32263629 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32632798 32632798 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32726018 32726018 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30910075 30910075 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1931127 1931127 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4211899 4211899 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32630622 32630622 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31211664 31211664 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32261416 32261416 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46241642 46241642 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32723682 32723682 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30827617 30827617 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30830558 30830558 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5021752 5021752 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31215658 31215658 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557194 4557194 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000054 11000054 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31149226 31149226 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32725858 32725858 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3869905 3869905 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32150859 32150859 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58086815 58086815 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31153220 31153220 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330342 2330342 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3874635 3874635 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31208385 31208385 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30834603 30834603 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134345 11134345 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2242647 2242647 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32632988 32632988 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32263581 32263581 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31145967 31145967 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4294272 4294272 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30913028 30913028 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297192 1297192 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32150811 32150811 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4764122 4764122 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299668 4299668 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46248378 46248378 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128375 11128375 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30917073 30917073 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32148646 32148646 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.42 ms 4.48 ms 0.06 ms (1.40%) 5.15%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.09 ms 5.16 ms 0.07 ms (1.40%) 6.46%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.11 ms 5.18 ms 0.07 ms (1.37%) 3.78%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.02 ms 5.08 ms 0.07 ms (1.34%) 5.88%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 451.01 µs 456.93 µs 5.92 µs (1.31%) 4.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 450.00 µs 454.76 µs 4.75 µs (1.06%) 3.75%
transfer_no_resume_ring_1.2_rsa_aes 6.59 ms 6.66 ms 0.07 ms (1.05%) 3.67%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.19 ms 6.25 ms 0.06 ms (0.93%) 4.37%
transfer_no_resume_ring_1.3_rsa_aes 6.68 ms 6.74 ms 0.06 ms (0.92%) 3.87%
handshake_no_resume_ring_1.3_ecdsap256_aes 473.21 µs 477.49 µs 4.29 µs (0.91%) 2.71%
handshake_no_resume_ring_1.3_ecdsap256_chacha 470.48 µs 473.98 µs 3.50 µs (0.74%) 3.18%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.30 ms 9.36 ms 0.06 ms (0.63%) 2.74%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.57 ms 13.64 ms 0.07 ms (0.53%) 1.92%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.57 ms 13.64 ms 0.07 ms (0.49%) 1.97%
transfer_no_resume_ring_1.3_rsa_chacha 13.39 ms 13.45 ms 0.06 ms (0.48%) 1.64%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.89 ms 12.95 ms 0.06 ms (0.48%) 1.86%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.90 ms 12.96 ms 0.06 ms (0.47%) 1.82%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.08 ms 0.01 ms (0.47%) 4.23%
handshake_no_resume_ring_1.2_rsa_aes 958.85 µs 963.26 µs 4.41 µs (0.46%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.11 ms 1.11 ms 0.00 ms (0.45%) 3.13%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.13 ms 0.00 ms (0.43%) 1.32%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.63 ms 0.01 ms (0.41%) 2.66%
handshake_no_resume_ring_1.3_rsa_chacha 964.12 µs 968.03 µs 3.91 µs (0.41%) 1.26%
handshake_no_resume_ring_1.3_rsa_aes 962.47 µs 966.27 µs 3.81 µs (0.40%) 1.09%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.02 ms 16.07 ms 0.06 ms (0.36%) 1.59%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.52 ms 0.02 ms (0.34%) 2.16%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.18 ms 5.19 ms 0.02 ms (0.34%) 1.41%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.31 ms 4.33 ms 0.01 ms (0.34%) 2.02%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.80 ms 1.80 ms 0.01 ms (0.31%) 3.58%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.00 ms 5.01 ms 0.02 ms (0.31%) 1.61%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.21 ms 0.01 ms (0.25%) 1.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.15 ms 5.16 ms 0.01 ms (0.24%) 1.59%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.17 ms 5.18 ms 0.01 ms (0.22%) 1.67%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.99 ms 5.00 ms 0.01 ms (0.22%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.14 ms 0.00 ms (0.21%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.95 ms 4.96 ms 0.01 ms (0.17%) 1.74%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.48 ms 4.49 ms 0.01 ms (0.17%) 1.78%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.95 ms 4.96 ms 0.01 ms (0.15%) 1.50%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.11 ms 0.00 ms (0.14%) 1.18%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.50 ms -0.01 ms (-0.13%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.29 ms 4.29 ms 0.01 ms (0.12%) 2.09%
handshake_session_id_ring_1.3_rsa_aes 6.04 ms 6.04 ms -0.01 ms (-0.11%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.59 ms 3.59 ms 0.00 ms (0.10%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.55 ms 5.54 ms -0.00 ms (-0.08%) 1.13%
handshake_tickets_ring_1.3_ecdsap256_aes 5.62 ms 5.62 ms -0.00 ms (-0.08%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms -0.00 ms (-0.08%) 1.43%
handshake_tickets_ring_1.3_rsa_aes 6.11 ms 6.11 ms -0.00 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.73 ms 8.73 ms -0.01 ms (-0.06%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms 0.00 ms (0.06%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.58 ms 5.58 ms -0.00 ms (-0.06%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.62 ms 8.61 ms -0.00 ms (-0.06%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.69 ms 8.69 ms -0.00 ms (-0.05%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.66 ms 8.65 ms -0.00 ms (-0.04%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.06 ms 6.06 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.99 ms 5.99 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

Merged via the queue into rustls:main with commit f0e71ab Feb 19, 2025
33 checks passed
@brody4hire brody4hire deleted the fix-msrv-etc-in-doc branch February 19, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees < 49B9 /div> No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brody4hire @djc
0