8000 Take rustls-webpki 0.103.0 and improve certificate error reporting by ctz · Pull Request #2342 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Take rustls-webpki 0.103.0 and improve certificate error reporting #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 26, 2025
Merged

Take rustls-webpki 0.103.0 and improve certificate error reporting #2342

merged 7 commits into from
Feb 26, 2025

Conversation

ctz
Copy link
Member
@ctz ctz commented Feb 13, 2025

This is a preview of the error reporting improvements we can do once we release webpki 0.103.0. I think it looks good, and if other folks agree I think we can go ahead and release that.

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Feb 13, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4211899 4223929 ⚠️ 12030 (0.29%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3869905 3880255 ⚠️ 10350 (0.27%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557194 4569074 ⚠️ 11880 (0.26%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4294272 4304472 ⚠️ 10200 (0.24%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10411089 10474154 63065 (0.61%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10689040 10712299 23259 (0.22%) 1.64%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10726200 10747234 21034 (0.20%) 1.18%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1716261 1719378 3117 (0.18%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1924377 1927648 3271 (0.17%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1931127 1934375 3248 (0.17%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330342 2333686 3344 (0.14%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336195 2339542 3347 (0.14%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2242647 2245797 3150 (0.14%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5021752 5027182 5430 (0.11%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3302036 3305340 3304 (0.10%) 0.25%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3300719 3303913 3194 (0.10%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27848842 27871586 22744 (0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27853336 27876078 22742 (0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27846492 27869212 22720 (0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27793907 27816494 22587 (0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27789590 27812135 22545 (0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27787104 27809640 22536 (0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28190572 28213247 22675 (0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28183736 28206349 22613 (0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28216460 28239091 22631 (0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28186728 28209278 22550 (0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28220525 28243071 22546 (0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28213484 28235959 22475 (0.08%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080684 3082994 2310 (0.07%) 0.51%
handshake_session_id_ring_1.3_rsa_chacha_client 30834603 30856753 22150 (0.07%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30827617 30849759 22142 (0.07%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30830558 30852700 22142 (0.07%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30910075 30932208 22133 (0.07%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30917073 30939193 22120 (0.07%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30913028 30935140 22112 (0.07%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31153220 31175360 22140 (0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31145967 31168099 22132 (0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31149226 31171358 22132 (0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31208385 31230508 22123 (0.07%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31215658 31237781 22123 (0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31211664 31233779 22115 (0.07%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58174934 58214855 39921 (0.07%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58075917 58115217 39300 (0.07%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58083698 58123003 39305 (0.07%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58086818 58126118 39300 (0.07%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3874635 3877185 2550 (0.07%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57980067 58018055 37988 (0.07%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234444 58272468 38024 (0.07%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58237319 58274706 37387 (0.06%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58239404 58276790 37386 (0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3081633 3083481 1848 (0.06%) 0.56%
handshake_session_id_ring_1.2_rsa_aes_server 4299668 4302068 2400 (0.06%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4764122 4766702 2580 (0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8277146 8280864 3718 (0.04%) 1.27%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92669202 92708506 39304 (0.04%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92680104 92719408 39304 (0.04%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92678265 92717564 39299 (0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92704680 92742070 37390 (0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92700677 92738065 37388 (0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92698450 92735835 37385 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30393575 30402678 9103 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30436214 30445222 9008 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30396356 30405308 8952 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30438827 30447666 8839 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30396191 30404928 8737 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30439313 30447913 8600 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8295898 8293570 -2328 (-0.03%) 1.05%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28903107 28909154 6047 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28900922 28906895 5973 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28981524 28987483 5959 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28979265 28985171 5906 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28903479 28909311 5832 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28981805 28987526 5 8000 721 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32148706 32154676 5970 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32150871 32156841 5970 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32150919 32156889 5970 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32261476 32267446 5970 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32263641 32269611 5970 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32263689 32269659 5970 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2059391 2059723 332 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32632988 32637698 4710 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32726018 32730728 4710 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32723682 32728377 4695 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32725858 32730553 4695 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32630622 32635302 4680 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32632798 32637478 4680 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297192 1297355 163 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295799 1295954 155 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34740255 34743717 3462 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34738322 34741756 3434 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1143829 1143928 99 (0.01%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1146118 1146215 97 (0.01%) 1.54%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2062519 2062682 163 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229602 7229760 158 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227431 7227581 150 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458304 46458945 641 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128375 11128528 153 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134345 11134498 153 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000054 11000146 92 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46241652 46241643 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46148664 46148656 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46248382 46248376 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461267 46461272 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642621 80642629 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645597 80645592 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650249 80650253 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46253817 46253815 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465926 46465925 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541809 80541810 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553338 80553337 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407683 46407683 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548545 80548545 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.10 ms ✅ -0.01 ms (-1.30%) 1.14%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.09 ms -0.02 ms (-2.02%) 2.73%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.06 ms -0.02 ms (-1.87%) 3.23%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.62 ms -0.01 ms (-0.84%) 2.48%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.22 ms 5.18 ms -0.04 ms (-0.79%) 2.11%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.79 ms -0.01 ms (-0.76%) 3.29%
handshake_no_resume_ring_1.3_ecdsap256_chacha 476.36 µs 473.48 µs -2.88 µs (-0.61%) 3.06%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.00 ms 4.97 ms -0.03 ms (-0.60%) 1.50%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.19 ms 5.16 ms -0.03 ms (-0.60%) 6.06%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.53 ms 0.01 ms (0.59%) 1.11%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.11 ms 5.08 ms -0.02 ms (-0.48%) 5.88%
handshake_no_resume_ring_1.3_ecdsap256_aes 478.84 µs 476.71 µs -2.13 µs (-0.45%) 2.35%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.33 ms 4.31 ms -0.02 ms (-0.45%) 2.02%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.53 ms 4.51 ms -0.02 ms (-0.42%) 1.58%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.20 ms 5.18 ms -0.02 ms (-0.37%) 1.59%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 455.16 µs 453.63 µs -1.52 µs (-0.33%) 3.78%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.40 ms 9.43 ms 0.03 ms (0.32%) 2.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.99 ms 4.98 ms -0.02 ms (-0.31%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.13 ms -0.00 ms (-0.26%) 1.27%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.02 ms 5.01 ms -0.01 ms (-0.26%) 1.63%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.67 ms 13.63 ms -0.03 ms (-0.23%) 2.25%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.21 ms 5.20 ms -0.01 ms (-0.22%) 1.61%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.35 ms 4.35 ms 0.01 ms (0.22%) 2.05%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.55 ms 4.56 ms 0.01 ms (0.21%) 2.02%
handshake_no_resume_ring_1.3_rsa_chacha 968.94 µs 967.03 µs -1.91 µs (-0.20%) 1.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.14 ms -0.00 ms (-0.19%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.07 ms 6.08 ms 0.01 ms (0.18%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.58 ms 5.59 ms 0.01 ms (0.17%) 1.03%
handshake_tickets_ring_1.3_ecdsap256_aes 5.65 ms 5.64 ms -0.01 ms (-0.17%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.03 ms 5.04 ms 0.01 ms (0.16%) 1.63%
handshake_no_resume_ring_1.3_rsa_aes 967.33 µs 965.76 µs -1.57 µs (-0.16%) 1.15%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.54 ms 5.55 ms 0.01 ms (0.16%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.61 ms 0.00 ms (0.15%) 1.85%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.24 ms 0.01 ms (0.13%) 1.23%
transfer_no_resume_ring_1.2_rsa_aes 6.70 ms 6.69 ms -0.01 ms (-0.12%) 3.28%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.20 ms -0.01 ms (-0.11%) 5.22%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.61 ms 5.60 ms -0.01 ms (-0.10%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.03 ms 6.04 ms 0.01 ms (0.09%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 456.22 µs 455.84 µs -0.39 µs (-0.08%) 3.77%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.00 ms 12.99 ms -0.01 ms (-0.08%) 2.15%
handshake_session_id_ring_1.3_ecdsap384_aes 8.70 ms 8.69 ms -0.01 ms (-0.07%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.51 ms -0.00 ms (-0.07%) 6.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.68 ms 13.67 ms -0.01 ms (-0.06%) 2.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.59 ms -0.00 ms (-0.06%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.12 ms 16.11 ms -0.01 ms (-0.05%) 1.50%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.66 ms 8.65 ms -0.00 ms (-0.04%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.14 ms 6.14 ms -0.00 ms (-0.04%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms -0.00 ms (-0.04%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 6.77 ms 6.77 ms 0.00 ms (0.04%) 3.53%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.99 ms 12.99 ms -0.00 ms (-0.04%) 2.29%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.71 ms 8.72 ms 0.00 ms (0.03%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.48 ms -0.00 ms (-0.02%) 1.89%
handshake_tickets_ring_1.3_rsa_chacha 6.10 ms 6.10 ms 0.00 ms (0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.75 ms 8.76 ms 0.00 ms (0.02%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.29 ms 6.29 ms -0.00 ms (-0.01%) 4.50%
handshake_no_resume_ring_1.2_rsa_aes 964.12 µs 964.09 µs -0.03 µs (-0.00%) 1.68%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.03390% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.92%. Comparing base (a419389) to head (dea626e).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/webpki/mod.rs 66.66% 5 Missing ⚠️
rustls/src/error.rs 99.09% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2342      +/-   ##
==========================================
+ Coverage   94.89%   94.92%   +0.03%     
==========================================
  Files         103      103              
  Lines       24274    24501     +227     
==========================================
+ Hits        23034    23257     +223     
- Misses       1240     1244       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu reviewed Feb 14, 2025
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think it'll be a nice UX improvement downstream and seems to have the least downsides compared to the other approaches we kicked around in discussion. Thanks!

@ctz ctz changed the title Preview: take rustls-webpki 0.103.0 Take rustls-webpki 0.103.0 and improve certificate error reporting Feb 24, 2025
@ctz ctz marked this pull request as ready for review February 24, 2025 14:15
@ctz ctz mentioned this pull request Feb 24, 2025
Closed
1 task
djc
djc approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member
@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I don't like the ..Detail suffix much on the error variant names, because it doesn't read very naturally? I guess I'd stick with ..Context which is admittedly also not great.

@ctz
Copy link
Member Author
ctz commented Feb 25, 2025

I don't like the ..Detail suffix much on the error variant names, because it doesn't read very naturally? I guess I'd stick with ..Context which is admittedly also not great.

Moved to ..Context, matching the webpki variants.

@djc
Copy link
Member
djc commented Feb 25, 2025 •
edited
Loading

(Have already approved this -- would you like me to make another pass?)

@ctz ctz added this pull request to the merge queue Feb 26, 2025
@ctz
Copy link
Member Author
ctz commented Feb 26, 2025

(Have already approved this -- would you like me to make another pass?)

I think it's OK; but as always happy to address any follow-ups in a later PR.

Merged via the queue into main with commit 72c4c07 Feb 26, 2025
62 checks passed
@ctz ctz deleted the jbp-webpki-103 branch February 26, 2025 13:29
@cpu cpu mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu left review comments

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0