8000 Avoid handshake message round-tripping for binders by ctz · Pull Request #2359 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid handshake message round-tripping for binders #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Avoid handshake message round-tripping for binders #2359

merged 1 commit into from
Feb 27, 2025

Conversation

ctz
Copy link
Member
@ctz ctz commented Feb 25, 2025

Verifying a received ClientHello binder should be done against the original received bytes, not our re-encoding of them.

This previously worked, because we required and tested that we could accurately round-trip handshake messages. But that is a less-robust approach.

(change split out from #1475)

@ctz
Avoid handshake message round-tripping for binders
b544c0e 
Verifying a _received_ `ClientHello` binder should be done
against the original received bytes, not our re-encoding of them.

This previously worked, because we required and tested that
we could accurately round-trip handshake messages. But that is a
less-robust approach.
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Feb 25, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30395789 30225646 ✅ -170143 (-0.56%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30392888 30222912 ✅ -169976 (-0.56%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30438453 30268253 ✅ -170200 (-0.56%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30435518 30265497 ✅ -170021 (-0.56%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30395385 30225654 ✅ -169731 (-0.56%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30438045 30268236 ✅ -169809 (-0.56%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28900639 28748007 ✅ -152632 (-0.53%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28902899 28750416 ✅ -152483 (-0.53%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28902939 28750628 ✅ -152311 (-0.53%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28979003 28826404 ✅ -152599 (-0.53%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28981270 28828732 ✅ -152538 (-0.53%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28981428 28829028 ✅ -152400 (-0.53%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32630322 32461675 ✅ -168647 (-0.52%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32632688 32464216 ✅ -168472 (-0.52%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32632498 32464212 ✅ -168286 (-0.52%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32723382 32554735 ✅ -168647 (-0.52%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32725718 32557246 ✅ -168472 (-0.51%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32725558 32557272 ✅ -168286 (-0.51%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32148376 31997050 ✅ -151326 (-0.47%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32150541 31999549 ✅ -150992 (-0.47%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32150619 31999650 ✅ -150969 (-0.47%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32261146 32109820 ✅ -151326 (-0.47%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32263311 32112319 ✅ -150992 (-0.47%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32263389 32112420 ✅ -150969 (-0.47%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10748194 10699418 -48776 (-0.45%) 0.96%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10749818 10705500 -44318 (-0.41%) 1.34%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1143783 1148371 4588 (0.40%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1146072 1150664 4592 (0.40%) 1.54%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080546 3085158 4612 (0.15%) 0.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8292392 8281806 -10586 (-0.13%) 1.26%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10437531 10443159 5628 (0.05%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3082809 3081331 -1478 (-0.05%) 0.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8272363 8275182 2819 (0.03%) 1.07%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3869725 3869905 180 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2059360 2059455 95 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4211719 4211899 180 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4294092 4294272 180 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557014 4557194 180 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3302045 3302165 120 (0.00%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1924319 1924381 62 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1931065 1931127 62 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295744 1295784 40 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3300395 3300493 98 (0.00%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2062473 2062417 -56 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1716228 1716261 33 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330302 2330342 40 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336155 2336195 40 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297150 1297162 12 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28183510 28183739 229 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2242629 2242647 18 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5021722 5021752 30 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27794094 27793944 -150 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28190851 28190714 -137 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27846338 27846473 135 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227377 7227411 34 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28220441 28220311 -130 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27848948 27849075 127 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27789353 27789459 106 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229555 7229582 27 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128320 11128355 35 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134290 11134325 35 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30827497 30827587 90 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30830438 30830528 90 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30834483 30834573 90 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30909955 30910045 90 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30912908 30912998 90 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30916953 30917043 90 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31145847 31145937 90 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31149106 31149196 90 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31153100 31153190 90 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31208265 31208355 90 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31211544 31211634 90 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31215538 31215628 90 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28186543 28186610 67 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28216457 28216522 65 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28213353 28213393 40 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34740222 34740271 49 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34738294 34738336 42 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27853259 27853266 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46241642 46241652 10 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57980055 57980067 12 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46148656 46148663 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46248380 46248387 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645597 80645586 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458310 46458304 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92680093 92680104 11 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27786909 27786906 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58075917 58075923 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650255 80650247 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58237327 58237323 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465925 46465928 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548545 80548540 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553340 80553345 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642629 80642624 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92669202 92669198 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92700684 92700681 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407679 46407678 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58086815 58086814 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541810 80541811 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92678260 92678261 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92704680 92704681 1 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000054 11000054 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58083700 58083700 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299668 4299668 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4764122 4764122 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234443 58234443 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3874635 3874635 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58239403 58239403 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46253816 46253816 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58174933 58174933 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461267 46461267 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92698452 92698452 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_ring_1.3_rsa_aes 6.14 ms 6.06 ms ✅ -0.09 ms (-1.41%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.64 ms 5.57 ms ✅ -0.07 ms (-1.32%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.58 ms 5.50 ms ✅ -0.07 ms (-1.31%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.12 ms ⚠️ 0.01 ms (1.19%) 1.14%
handshake_tickets_ring_1.3_rsa_chacha 6.09 ms 6.02 ms ✅ -0.07 ms (-1.18%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.60 ms 5.53 ms ✅ -0.07 ms (-1.17%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.53 ms 5.47 ms ✅ -0.06 ms (-1.17%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.08 ms 6.00 ms ✅ -0.07 ms (-1.17%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.03 ms 5.96 ms ✅ -0.07 ms (-1.17%) 1.00%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.09 ms 0.03 ms (2.35%) 3.23%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.10 ms 1.12 ms 0.02 ms (2.11%) 2.73%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.65 ms 0.03 ms (1.95%) 2.17%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.83 ms 0.03 ms (1.70%) 2.37%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.53 ms 4.48 ms -0.05 ms (-1.07%) 1.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.33 ms 4.28 ms -0.04 ms (-1.00%) 1.75%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.18 ms -0.05 ms (-0.99%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.54 ms 4.50 ms -0.04 ms (-0.97%) 2.06%
handshake_session_id_ring_1.2_rsa_aes 1.53 ms 1.52 ms -0.01 ms (-0.93%) 1.06%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.19 ms 5.15 ms -0.05 ms (-0.92%) 1.53%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.47 ms 4.43 ms -0.04 ms (-0.86%) 5.86%
handshake_tickets_ring_1.3_ecdsap384_aes 8.75 ms 8.68 ms -0.07 ms (-0.85%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.69 ms 8.62 ms -0.07 ms (-0.82%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.99 ms 4.95 ms -0.04 ms (-0.78%) 1.49%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.64 ms 8.58 ms -0.07 ms (-0.76%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.70 ms 8.64 ms -0.06 ms (-0.73%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.15 ms 5.12 ms -0.04 ms (-0.72%) 5.11%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.35 ms 4.31 ms -0.03 ms (-0.72%) 1.70%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.23 ms 6.19 ms -0.04 ms (-0.69%) 4.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.13 ms -0.01 ms (-0.62%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.12 ms -0.01 ms (-0.58%) 1.15%
handshake_no_resume_ring_1.3_ecdsap256_aes 476.06 µs 473.38 µs -2.69 µs (-0.56%) 2.63%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.03 ms 5.00 ms -0.03 ms (-0.55%) 1.37%
transfer_no_resume_ring_1.3_rsa_aes 6.72 ms 6.68 ms -0.04 ms (-0.52%) 3.87%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.60 ms -0.01 ms (-0.47%) 1.45%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.35 ms 9.31 ms -0.04 ms (-0.45%) 2.75%
transfer_no_resume_ring_1.2_rsa_aes 6.63 ms 6.60 ms -0.03 ms (-0.40%) 3.54%
handshake_no_resume_ring_1.3_ecdsap256_chacha 473.08 µs 471.20 µs -1.88 µs (-0.40%) 2.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 453.24 µs 451.61 µs -1.63 µs (-0.36%) 3.72%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.19 ms 5.18 ms -0.02 ms (-0.35%) 1.57%
handshake_no_resume_ring_1.2_rsa_aes 962.21 µs 959.34 µs -2.87 µs (-0.30%) 1.62%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.91 ms -0.04 ms (-0.29%) 2.06%
handshake_no_resume_ring_1.3_rsa_aes 965.24 µs 962.73 µs -2.52 µs (-0.26%) 1.08%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 451.16 µs 450.00 µs -1.15 µs (-0.26%) 3.75%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.62 ms 13.59 ms -0.03 ms (-0.24%) 1.96%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.04 ms 5.05 ms 0.01 ms (0.24%) 5.14%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.06 ms 16.02 ms -0.04 ms (-0.22%) 1.56%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.93 ms 12.91 ms -0.03 ms (-0.22%) 2.21%
handshake_no_resume_ring_1.3_rsa_chacha 966.59 µs 964.52 µs -2.06 µs (-0.21%) 1.33%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.11 ms 5.12 ms 0.01 ms (0.19%) 5.46%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.40 ms -0.02 ms (-0.18%) 1.65%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms -0.00 ms (-0.14%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.59 ms 13.60 ms 0.02 ms (0.13%) 1.97%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.98 ms 4.98 ms 0. 8000 01 ms (0.12%) 1.22%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.00 ms 5.00 ms 0.01 ms (0.10%) 1.21%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.59 ms 3.59 ms -0.00 ms (-0.08%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.18 ms 5.18 ms 0.00 ms (0.00%) 1.67%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.93%. Comparing base (a419389) to head (b544c0e).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2359      +/-   ##
==========================================
+ Coverage   94.89%   94.93%   +0.03%     
==========================================
  Files         103      103              
  Lines       24274    24460     +186     
==========================================
+ Hits        23034    23220     +186     
  Misses       1240     1240

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc
Copy link
Member
djc commented Feb 25, 2025

Nice. Was just thinking about #1475 this morning.

cpu
cpu approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ctz ctz added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit e2d501f Feb 27, 2025
62 checks passed
@ctz ctz deleted the jbp-binder-calculated-on-bytes branch February 27, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0