8000 cleanup: specify once_cell version etc. in only 1 place by brody4hire · Pull Request #2352 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cleanup: specify once_cell version etc. in only 1 place #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

cleanup: specify once_cell version etc. in only 1 place #2352

merged 1 commit into from
Feb 24, 2025

Conversation

brody4hire
Copy link
Contributor

as I proposed in PR #2350 which I nuked (my bad)

To keep things simple I would like to simply update rustls/Cargo.toml to inherit the version, default-features = false, and features from top-level Cargo.toml.

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Feb 24, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1143844 1148379 4535 (0.40%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8268167 8294192 26025 (0.31%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8310438 8293905 -16533 (-0.20%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3088064 3083325 -4739 (-0.15%) 0.51%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10701021 10690928 -10093 (-0.09%) 1.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080536 3083336 2800 (0.09%) 0.51%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3299964 3302072 2108 (0.06%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10713550 10710917 -2633 (-0.02%) 1.15%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10443013 10442502 -511 (-0.00%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2059387 2059470 83 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1924421 1924377 -44 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3300641 3300603 -38 (-0.00%) 0.23%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297205 1297192 -13 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27794053 27793798 -255 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28216698 28216448 -250 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28979575 28979336 -239 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28186699 28186875 176 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28981726 28981563 -163 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28903184 28903339 155 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30438991 30439150 159 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28220514 28220387 -127 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27853301 27853422 121 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28981526 28981402 -124 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30438857 30438729 -128 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27787073 27786957 -116 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27789422 27789535 113 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28183637 28183744 107 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27846315 27846420 105 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28213528 28213631 103 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1150672 1150676 4 (0.00%) 1.54%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30393593 30393508 -85 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28903182 28903259 77 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30436268 30436189 -79 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28190622 28190683 61 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1931123 1931127 4 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27849018 27848966 -52 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2062611 2062609 -2 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28900929 28900902 -27 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30396462 30396440 -22 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30396152 30396134 -18 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34738352 34738337 -15 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227432 7227434 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465934 46465925 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58075923 58075913 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458312 46458305 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92678258 92678269 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92680094 92680104 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407678 46407683 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541805 80541812 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553337 80553344 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58237319 58237323 4 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34740257 34740255 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58174933 58174936 3 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46148658 46148656 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46248378 46248376 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92700682 92700686 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650253 80650250 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92704683 92704686 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548544 80548546 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92698445 92698447 2 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57980057 57980056 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234445 58234446 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58239404 58239403 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645588 80645589 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92669201 92669202 1 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32263689 32263689 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299668 4299668 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32725858 32725858 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134345 11134345 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32726018 32726018 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229602 7229602 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58083699 58083699 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46241642 46241642 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000054 11000054 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336195 2336195 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1716242 1716242 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128375 11128375 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4764122 4764122 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32150919 32150919 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461268 46461268 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58086815 58086815 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3874635 3874635 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4211899 4211899 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30830558 30830558 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5021752 5021752 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30913028 30913028 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642626 80642626 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4294272 4294272 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30910075 30910075 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2242647 2242647 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31153220 31153220 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32148706 32148706 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32632798 32632798 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3869905 3869905 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295804 1295804 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31208385 31208385 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32263641 32263641 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30834603 30834603 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31145967 31145967 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557194 4557194 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31149226 31149226 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32261476 32261476 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32723682 32723682 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31215658 31215658 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32632988 32632988 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32150871 32150871 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330342 2330342 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30917073 30917073 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31211664 31211664 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46253815 46253815 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32630622 32630622 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30827617 30827617 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.56 ms 4.49 ms -0.07 ms (-1.45%) 5.15%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.23 ms 5.16 ms -0.07 ms (-1.27%) 6.19%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.25 ms 5.18 ms -0.07 ms (-1.27%) 3.99%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.15 ms 5.08 ms -0.06 ms (-1.26%) 6.02%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.33 ms 6.26 ms -0.06 ms (-0.99%) 4.35%
handshake_no_resume_ring_1.3_ecdsap256_aes 481.92 µs 477.68 µs -4.24 µs (-0.88%) 2.63%
transfer_no_resume_ring_1.3_rsa_aes 6.81 ms 6.75 ms -0.06 ms (-0.86%) 3.87%
transfer_no_resume_ring_1.2_rsa_aes 6.72 ms 6.67 ms -0.06 ms (-0.84%) 3.54%
handshake_no_resume_ring_1.3_ecdsap256_chacha 478.93 µs 475.29 µs -3.64 µs (-0.76%) 2.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 457.81 µs 454.35 µs -3.47 µs (-0.76%) 3.99%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 458.93 µs 455.56 µs -3.37 µs (-0.73%) 3.92%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.44 ms 9.38 ms -0.06 ms (-0.63%) 2.74%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.34 ms 4.31 ms -0.02 ms (-0.52%) 2.09%
handshake_session_id_ring_1.2_rsa_aes 1.53 ms 1.52 ms -0.01 ms (-0.51%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.52 ms 13.46 ms -0.07 ms (-0.49%) 1.65%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.04 ms 12.97 ms -0.06 ms (-0.47%) 1.78%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.71 ms 13.65 ms -0.06 ms (-0.46%) 1.96%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.03 ms 12.97 ms -0.06 ms (-0.45%) 1.76%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.70 ms 13.65 ms -0.05 ms (-0.40%) 1.91%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.32 ms 4.30 ms -0.02 ms (-0.36%) 2.09%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.80 ms -0.01 ms (-0.35%) 3.29%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.15 ms 16.09 ms -0.06 ms (-0.35%) 1.51%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.01 ms 4.99 ms -0.02 ms (-0.35%) 1.23%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.99 ms 4.97 ms -0.02 ms (-0.34%) 1.50%
handshake_no_resume_ring_1.3_rsa_chacha 971.63 µs 968.49 µs -3.13 µs (-0.32%) 1.25%
handshake_no_resume_ring_1.3_rsa_aes 969.15 µs 966.15 µs -3.01 µs (-0.31%) 1.08%
handshake_session_id_ring_1.3_ecdsap256_aes 5.58 ms 5.56 ms -0.02 ms (-0.30%) 1.03%
handshake_tickets_ring_1.3_rsa_aes 6.14 ms 6.13 ms -0.02 ms (-0.30%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.64 ms -0.00 ms (-0.29%) 2.47%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.02 ms 5.00 ms -0.01 ms (-0.28%) 1.68%
handshake_session_id_ring_1.3_rsa_aes 6.07 ms 8000 6.05 ms -0.02 ms (-0.28%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.54 ms 5.53 ms -0.02 ms (-0.28%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.65 ms 5.63 ms -0.02 ms (-0.27%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.04 ms 6.02 ms -0.02 ms (-0.26%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.61 ms 5.59 ms -0.01 ms (-0.26%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.09 ms 6.08 ms -0.02 ms (-0.26%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.52 ms 4.51 ms -0.01 ms (-0.25%) 1.59%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.60 ms -0.00 ms (-0.25%) 1.42%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.53 ms 4.52 ms -0.01 ms (-0.24%) 2.16%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.66 ms 8.64 ms -0.02 ms (-0.23%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.20 ms -0.01 ms (-0.21%) 1.05%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.21 ms 5.20 ms -0.01 ms (-0.21%) 1.67%
handshake_no_resume_ring_1.2_rsa_aes 965.08 µs 963.05 µs -2.03 µs (-0.21%) 1.62%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.98 ms 4.97 ms -0.01 ms (-0.21%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.14 ms -0.00 ms (-0.19%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.13 ms -0.00 ms (-0.18%) 1.15%
handshake_session_id_ring_1.3_ecdsap384_aes 8.70 ms 8.68 ms -0.02 ms (-0.18%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.71 ms 8.70 ms -0.01 ms (-0.15%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.20 ms 5.19 ms -0.01 ms (-0.14%) 1.89%
handshake_tickets_ring_1.3_ecdsap384_aes 8.75 ms 8.74 ms -0.01 ms (-0.13%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.19 ms 5.18 ms -0.01 ms (-0.13%) 2.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.12 ms -0.00 ms (-0.11%) 2.94%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.59 ms -0.00 ms (-0.11%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms -0.00 ms (-0.08%) 1.14%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.00 ms (-0.06%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.03%) 3.23%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.89%. Comparing base (3ccfcec) to head (1c7721b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2352   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files         103      103           
  Lines       24274    24274           
=======================================
  Hits        23034    23034           
  Misses       1240     1240

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc djc added this pull request to the merge queue Feb 24, 2025
Merged via the queue into rustls:main with commit b299743 Feb 24, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brody4hire @djc @ctz
0