8000 Avoid semver errors on discriminant changes by djc · Pull Request #2367 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid semver errors on discriminant changes #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Avoid semver errors on discriminant changes #2367

merged 1 commit into from
Mar 7, 2025

Conversation

djc
Copy link
Member
@djc djc commented Mar 7, 2025

No description provided.

@djc djc requested review from cpu and ctz March 7, 2025 09:13
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Mar 7, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10736982 10677662 -59320 (-0.55%) 0.94%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1150606 1146090 -4516 (-0.39%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8308910 8285634 -23276 (-0.28%) 1.54%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10439257 10412769 -26488 (-0.25%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8289158 8310109 20951 (0.25%) 1.37%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10701846 10724452 22606 (0.21%) 2.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3090716 3085144 -5572 (-0.18%) 0.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3082731 3083121 390 (0.01%) 0.70%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1143765 1143695 -70 (-0.01%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2062541 2062449 -92 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2059402 2059327 -75 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305092 3305157 65 (0.00%) 0.30%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28749607 28750030 423 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303495 3303533 38 (0.00%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927341 1927360 19 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934087 1934106 19 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297087 1297097 10 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28232644 28232835 191 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30264952 30265154 202 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30262155 30262333 178 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27869638 27869479 -159 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28229829 28229681 -148 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27810121 27810229 108 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30222436 30222549 113 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27862720 27862629 -91 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28825308 28825392 84 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28236616 28236691 75 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28747067 28746994 -73 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28202935 28202999 64 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27803255 27803195 -60 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27805694 27805749 55 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30219530 30219477 -53 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28827967 28828009 42 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28827775 28827806 31 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741476 34741506 30 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27865131 27865109 -22 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28749399 28749421 22 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28199849 28199830 -19 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30264984 30264970 -14 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30222261 30222253 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46248387 46248376 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46241642 46241652 10 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227336 7227337 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684208 92684198 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92700625 92700635 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458941 46458946 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642628 80642621 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645596 80645589 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407684 46407680 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58237271 58237266 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58180298 58180294 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650250 80650254 4 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28206758 28206759 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58239508 58239510 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682364 92682367 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92706868 92706871 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541812 80541810 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46148657 46148656 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673305 92673303 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92702865 92702863 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461272 46461273 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465931 46465930 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58080016 58080017 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58087807 58087806 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58090918 58090919 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58241591 58241590 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548545 80548544 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553341 80553340 -1 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719083 1719083 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128285 11128285 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229513 7229513 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3871125 3871125 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31165628 31165628 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31232051 31232051 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30846970 30846970 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339278 2339278 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30844033 30844033 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57983495 57983495 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31162373 31162373 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245510 2245510 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929410 30929410 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32551990 32551990 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295706 1295706 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31228049 31228049 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743437 34743437 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933463 30933463 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32554527 32554527 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999910 10999910 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4564184 4564184 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31998289 31998289 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32461452 32461452 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4760732 4760732 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224782 31224782 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30851023 30851023 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32111160 32111160 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3877675 3877675 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4301262 4301262 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134253 11134253 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32461516 32461516 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32111059 32111059 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32554546 32554546 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31998390 31998390 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46253818 46253818 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31995790 31995790 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4296098 4296098 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32108560 32108560 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4219669 4219669 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333422 2333422 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926482 30926482 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5018332 5018332 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31169630 31169630 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32458915 32458915 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.44 ms 4.52 ms 0.08 ms (1.86%) 8.33%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.12 ms 5.22 ms 0.10 ms (1.86%) 6.29%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.12 ms 5.21 ms 0.09 ms (1.73%) 6.85%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.05 ms 5.14 ms 0.09 ms (1.71%) 6.52%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.22 ms 6.30 ms 0.09 ms (1.37%) 5.40%
transfer_no_resume_ring_1.3_rsa_aes 6.70 ms 6.79 ms 0.09 ms (1.31%) 5.20%
transfer_no_resume_ring_1.2_rsa_aes 6.63 ms 6.71 ms 0.08 ms (1.21%) 4.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 449.81 µs 454.87 µs 5.07 µs (1.13%) 5.44%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 452.84 µs 457.23 µs 4.39 µs (0.97%) 4.93%
handshake_no_resume_ring_1.3_ecdsap256_chacha 471.14 µs 475.69 µs 4.55 µs (0.97%) 4.21%
handshake_no_resume_ring_1.3_ecdsap256_aes 474.40 µs 478.37 µs 3.96 µs (0.84%) 4.06%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.36 ms 9.44 ms 0.07 ms (0.79%) 3.38%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.84 ms 1.85 ms 0.01 ms (0.77%) 3.14%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.60 ms 13.70 ms 0.09 ms (0.70%) 2.34%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.92 ms 13.01 ms 0.09 ms (0.69%) 2.73%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.91 ms 13.00 ms 0.09 ms (0.68%) 2.78%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.59 ms 13.68 ms 0.09 ms (0.65%) 2.65%
transfer_no_resume_ring_1.3_rsa_chacha 13.42 ms 13.50 ms 0.09 ms (0.64%) 2.44%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.13 ms 0.01 ms (0.56%) 2.51%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.12 ms 0.08 ms (0.51%) 2.17%
handshake_no_resume_ring_1.3_rsa_chacha 964.09 µs 967.91 µs 3.82 µs (0.40%) 2.08%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.19 ms 5.21 ms 0.02 ms (0.34%) 1.62%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.66 ms 1.67 ms 0.01 ms (0.33%) 2.67%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.53 ms 0.01 ms (0.31%) 2.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.48 ms 4.50 ms 0.01 ms (0.31%) 1.93%
handshake_no_resume_ring_1.3_rsa_aes 964.41 µs 967.34 µs 2.92 µs (0.30%) 1.61%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.18 ms 5.20 ms 0.02 ms (0.30%) 2.02%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.20 ms 0.01 ms (0.25%) 1.82%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms 0.00 ms (0.25%) 1.87%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.13 ms 0.00 ms (0.25%) 1.30%
handshake_tickets_ring_1.2_rsa_aes 1.62 ms 1.62 ms 0.00 ms (0.24%) 1.75%
handshake_session_id_ring_1.2_rsa_aes 1.53 ms 1.53 ms 0.00 ms (0.24%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.98 ms 4.99 ms 0.01 ms (0.24%) 1.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.16 ms 5.17 ms 0.01 ms (0.23%) 2.15%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.14 ms 0.00 ms (0.23%) 1.78%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.29 ms 4.30 ms 0.01 ms (0.22%) 2.02%
handshake_no_resume_ring_1.2_rsa_aes 961.23 µs 963.14 µs 1.90 µs (0.20%) 2.04%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.00 ms 5.01 ms 0.01 ms (0.19%) 1.94%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.95 ms 4.96 ms 0.01 ms (0.18%) 2.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.00 ms 5.00 ms 0.01 ms (0.14%) 2.03%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.57 ms 5.57 ms 0.01 ms (0.14%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.32 ms 4.32 ms 0.01 ms (0.12%) 3.07%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.51 ms 0.01 ms (0.12%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.99 ms 6.00 ms 0.01 ms (0.11%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms 0.00 ms (0.10%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.59 ms 3.60 ms 0.00 ms (0.09%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.05 ms 6.06 ms 0.01 ms (0.08%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.05 ms 0.00 ms (0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.61 ms 5.62 ms 0.00 ms (0.05%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.09 ms -0.00 ms (-0.04%) 3.96%
handshake_tickets_ring_1.3_rsa_aes 6.11 ms 6.11 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.56 ms 5.56 ms 0.00 ms (0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.68 ms 8.68 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.72 ms 8.72 ms -0.00 ms (-0.02%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.66 ms 8.66 ms 0.00 ms (0.00%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.61 ms 8.61 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

ctz
ctz approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member
@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, here's me thinking "what if we add a dummy structure variant to every public enum"

@djc djc enabled auto-merge March 7, 2025 09:19
@codecov Codecov
Copy link
codecov bot commented Mar 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (1854946) to head (d3daf77).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2367   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files         103      103           
  Lines       24551    24551           
=======================================
  Hits        23299    23299           
  Misses       1252     1252

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit 5860d10 Mar 7, 2025
62 checks passed
@djc djc deleted the tweak-semver-checks branch March 7, 2025 09:41
@cpu
Copy link
Member
cpu commented Mar 7, 2025

Thanks for figuring this out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz
0