8000 Mark unreachable functions with `coverage(off)` by ctz · Pull Request #2373 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mark unreachable functions with coverage(off) #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

Mark unreachable functions with coverage(off) #2373

merged 2 commits into from
Mar 11, 2025

Conversation

ctz
Copy link
Member
@ctz ctz commented Mar 10, 2025

No description provided.

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Mar 10, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1151268 1147016 -4252 (-0.37%) 1.55%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10461913 10428401 -33512 (-0.32%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3104583 3096485 -8098 (-0.26%) 0.58%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10751825 10733233 -18592 (-0.17%) 2.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8299605 8313666 14061 (0.17%) 1.40%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8319157 8330457 11300 (0.14%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10742486 10753049 10563 (0.10%) 0.89%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2061512 2061224 -288 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2064270 2064554 284 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3097198 3096908 -290 (-0.01%) 0.67%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303951 3303873 -78 (-0.00%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1144823 1144808 -15 (-0.00%) 1.57%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719418 1719399 -19 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297118 1297105 -13 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27876883 27877115 232 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28822378 28822183 -195 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27815170 27815009 -161 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27881475 27881631 156 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28248524 28248378 -146 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28819430 28819283 -147 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27817561 27817688 127 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28744028 28743899 -129 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30219224 30219345 121 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28822522 28822409 -113 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28214721 28214830 109 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295925 1295930 5 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28244456 28244564 108 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30216312 30216421 109 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30262137 30262046 -91 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305322 3305331 9 (0.00%) 0.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28743775 28743838 63 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30219408 30219464 56 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28241555 28241528 -27 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27874506 27874522 16 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741792 34741775 -17 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28740948 28740960 12 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227558 7227555 -3 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27822013 27822004 -9 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30262238 30262246 8 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28211768 28211762 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46292211 46292202 -9 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28218973 28218968 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645586 80645597 11 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30259156 30259160 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92701314 92701324 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465930 46465925 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58231628 58231624 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458944 46458941 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553346 80553341 -5 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743507 34743505 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46302458 46302456 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461266 46461268 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548536 80548539 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58127837 58127835 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58131602 58131604 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163472 58163474 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58233862 58233860 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58236035 58236037 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92666716 92666719 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92697228 92697225 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541809 80541811 2 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46198576 46198577 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46298937 46298936 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92657582 92657584 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642629 80642628 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650253 80650254 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92668571 92668572 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92694992 92694993 1 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5016022 5016022 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128487 11128487 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32115490 32115490 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58120623 58120623 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4239222 4239222 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31251983 31251983 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3868725 3868725 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31255931 31255931 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31184720 31184720 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58021703 58021703 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30950337 30950337 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32561230 32561230 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30862056 30862056 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333578 2333578 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31180772 31180772 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4765952 4765952 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30859107 30859107 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32564266 32564266 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32118529 32118529 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927404 1927404 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31248563 31248563 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32459155 32459155 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229513 7229513 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134244 11134244 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4590973 4590973 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30957382 30957382 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339228 2339228 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934146 1934146 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32118600 32118600 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30953286 30953286 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000087 11000087 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32462232 32462232 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31993720 31993720 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31177373 31177373 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3896601 3896601 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32462236 32462236 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31996830 31996830 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32564307 32564307 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31996759 31996759 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245956 2245956 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407682 46407682 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4327852 4327852 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4301258 4301258 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30866152 30866152 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_ring_1.3_ecdsap256_aes 5.42 ms 5.45 ms 0.03 ms (0.49%) 5.09%
transfer_no_resume_ring_1.2_rsa_aes 5.83 ms 5.86 ms 0.03 ms (0.45%) 4.29%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.45 ms 4.47 ms 0.02 ms (0.45%) 7.14%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.15 ms 1.16 ms 0.00 ms (0.41%) 2.46%
transfer_no_resume_ring_1.3_rsa_aes 5.92 ms 5.95 ms 0.02 ms (0.41%) 5.37%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.16 ms 5.18 ms 0.02 ms (0.40%) 5.59%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 451.80 µs 453.59 µs 1.79 µs (0.40%) 4.06%
handshake_no_resume_ring_1.3_ecdsap256_aes 477.99 µs 479.83 µs 1.84 µs (0.39%) 3.96%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.10 ms 5.12 ms 0.02 ms (0.38%) 5.36%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.49 ms 4.47 ms -0.02 ms (-0.35%) 1.80%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.29 ms 4.28 ms -0.01 ms (-0.34%) 2.02%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.17 ms 5.15 ms -0.02 ms (-0.33%) 1.57%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.15 ms 5.16 ms 0.02 ms (0.30%) 6.99%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.96 ms 4.95 ms -0.01 ms (-0.30%) 1.72%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.14 ms 1.14 ms 0.00 ms (0.30%) 1.65%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.54 ms 8.57 ms 0.03 ms (0.29%) 3.22%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.13 ms 1.13 ms -0.00 ms (-0.28%) 4.22%
handshake_no_resume_ring_1.3_ecdsap256_chacha 472.20 µs 473.45 µs 1.24 µs (0.26%) 4.76%
handshake_no_resume_ring_1.3_rsa_aes 974.76 µs 977.29 µs 2.52 µs (0.26%) 1.74%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.00 ms 4.99 ms -0.01 ms (-0.24%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.63 ms 13.66 ms 0.03 ms (0.21%) 1.98%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.51 ms -0.01 ms (-0.19%) 1.61%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 455.00 µs 455.86 µs 0.86 µs (0.19%) 4.02%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.86 ms 1.86 ms -0.00 ms (-0.17%) 2.85%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.21 ms 5.20 ms -0.01 ms (-0.17%) 1.30%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.93 ms 12.95 ms 0.02 ms (0.17%) 2.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.20 ms -0.01 ms (-0.16%) 1.33%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.23 ms 5.22 ms -0.01 ms (-0.15%) 1.41%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.32 ms 4.31 ms -0.01 ms (-0.15%) 2.27%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 16.07 ms 0.02 ms (0.15%) 1.86%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.92 ms 12.94 ms 0.02 ms (0.12%) 2.38%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.44 ms 0.02 ms (0.12%) 2.08%
handshake_no_resume_ring_1.3_rsa_chacha 975.57 µs 976.72 µs 1.15 µs (0.12%) 1.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.13 ms 0.00 ms (0.12%) 1.05%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.07 ms -0.01 ms (-0.12%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.61 ms 13.62 ms 0.01 ms (0.11%) 2.09%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.04 ms 5.03 ms -0.01 ms (-0.10%) 1.34%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.63 ms 8.62 ms -0.01 ms (-0.10%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.00 ms 5.00 ms -0.00 ms (-0.09%) 1.76%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 6.00 ms -0.01 ms (-0.09%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 965.78 µs 966.60 µs 0.82 µs (0.09%) 1.95%
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.66 ms 0.00 ms (0.08%) 1.90%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.59 ms -0.00 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.52 ms 5.52 ms -0.00 ms (-0.06%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.71 ms 8.70 ms -0.00 ms (-0.05%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.14 ms 0.00 ms (0.05%) 1.55%
handshake_tickets_ring_1.3_ecdsap384_aes 8.91 ms 8.91 ms -0.00 ms (-0.04%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.30 ms 6.30 ms -0.00 ms (-0.04%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.37 ms 6.37 ms -0.00 ms (-0.04%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms 0.00 ms (0.03%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.57 ms 0.00 ms (0.03%) 1.15%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.80 ms 5.79 ms -0.00 ms (-0.02%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.69 ms 1.69 ms -0.00 ms (-0.01%) 2.24%
handshake_session_id_ring_1.3_ecdsap384_aes 8.99 ms 8.99 ms -0.00 ms (-0.00%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.88 ms 5.88 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

ctz added 2 commits March 10, 2025 16:27
8000
@ctz
Prefer to put check-cfg data in Cargo.toml
9546f02
@ctz
Mark unreachable functions with coverage(off)
4428adf 
This is nightly-only, so:

- measure coverage under nightly
- mention llvm-cov's `cfg(coverage_nightly)` in our check-cfg stanza
- opt-in to `feature(coverage_attribute)` on nightly coverage builds
@ctz ctz force-pushed the jbp-no-coverage-attr branch from d2dbe07 to 4428adf Compare March 10, 2025 16:28
@codecov Codecov
Copy link
codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (da46c21) to head (4428adf).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2373      +/-   ##
==========================================
+ Coverage   94.78%   94.91%   +0.12%     
==========================================
  Files         103      103              
  Lines       24641    24676      +35     
==========================================
+ Hits        23357    23421      +64     
+ Misses       1284     1255      -29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cpu
cpu approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@ctz ctz added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 8464356 Mar 11, 2025
62 checks passed
@ctz ctz deleted the jbp-no-coverage-attr branch March 11, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0