8000 Map webpki RequiredEkuNotFound error to InvalidPurpose by djc · Pull Request #2384 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Map webpki RequiredEkuNotFound error to InvalidPurpose #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

Map webpki RequiredEkuNotFound error to InvalidPurpose #2384

merged 1 commit into from
Mar 17, 2025

Conversation

djc
Copy link
Member
@djc djc commented Mar 17, 2025

In map_webpki_errors(), rustls-platform-verifier currently downcasts the CertificateError::Other value to webpki::Error. This means that it breaks the abstraction of rustls wrapping the (semver-incompatible) version of webpki being used.

In order to facilitate this usage, map webpki::Error::RequiredEkuNotFound to an actual variant of CertificateError -- which turned out to have an InvalidPurpose variant which currently appears to be unused but does map to the AlertDescription of the same name. Seems like a good fit?

Not sure if this is worth doing a 0.23.25 directly for?

@djc djc requested review from cpu and ctz March 17, 2025 12:40
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Mar 17, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1145003 1148978 3975 (0.35%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8318225 8343431 25206 (0.30%) 1.09%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10454802 10483313 28511 (0.27%) 0.88%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3094736 3101828 7092 (0.23%) 0.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8296394 8310537 14143 (0.17%) 0.95%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3890211 3896601 6390 (0.16%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4233042 4239222 6180 (0.15%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4321822 4327852 6030 (0.14%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4585153 4590973 5820 (0.13%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3873525 3868725 -4800 (-0.12%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4305728 4301258 -4470 (-0.10%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10720076 10709797 -10279 (-0.10%) 1.25%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5020822 5016022 -4800 (-0.10%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10719904 10730066 10162 (0.09%) 1.87%
handshake_tickets_ring_1.2_rsa_aes_server 4770422 4765952 -4470 (-0.09%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304302 3301791 -2511 (-0.08%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3097686 3099379 1693 (0.05%) 0.57%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27871728 27881731 10003 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27867124 27877082 9958 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28238651 28248593 9942 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27864682 27874469 9787 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27805364 27815107 9743 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27807739 27817448 9709 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27812314 27822022 9708 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28231785 28241569 9784 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28204966 28214740 9774 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28201975 28211739 9764 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28208975 28218724 9749 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28235071 28244436 9365 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30852246 30862056 9810 (0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30856342 30866152 9810 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30849301 30859107 9806 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30943476 30953286 9810 (0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30947572 30957382 9810 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30940531 30950337 9806 (0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31170962 31180772 9810 (0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31174910 31184720 9810 (0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31167567 31177373 9806 (0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31242173 31251983 9810 (0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31246121 31255931 9810 (0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31238757 31248563 9806 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30223998 30216379 -7619 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30266655 30259078 -7577 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28826384 28819250 -7134 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28747856 28740764 -7092 (-0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32467045 32459155 -7890 (-0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32568970 32561230 -7740 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30269132 30262009 -7123 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30226593 30219584 -7009 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30226489 30219601 -6888 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28750481 28743930 -6551 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32469616 32462236 -7380 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32469582 32462232 -7350 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30269200 30262379 -6821 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32571496 32564266 -7230 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32571507 32564307 -7200 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28828848 28822484 -6364 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28750143 28743843 -6300 (-0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32000650 31993720 -6930 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28828460 28822312 -6148 (-0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32122270 32115490 -6780 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32003149 31996759 -6390 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32003220 31996830 -6390 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32124769 32118529 -6240 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32124840 32118600 -6240 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1147294 1147094 -200 (-0.02%) 1.54%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297306 1297105 -201 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1296126 1295927 -199 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2064751 2064554 -197 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934305 1934146 -159 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927559 1927419 -140 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333733 2333578 -155 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339383 2339228 -155 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229716 7229513 -203 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227756 7227556 -200 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246009 2245956 -53 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719434 1719399 -35 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134446 11134230 -216 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128684 11128473 -211 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2061629 2061591 -38 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000242 11000073 -169 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58041298 58040658 -640 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163842 58163211 -631 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305302 3305329 27 (0.00%) 0.28%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743662 34743505 -157 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741945 34741805 -140 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154252 58154242 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58258971 58258980 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46294741 46294748 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46298263 46298269 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92659607 92659617 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697818 92697828 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80641390 80641398 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92691218 92691210 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129859 58129854 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80638432 80638426 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122641 58122645 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80549142 80549147 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668743 92668748 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235826 58235829 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46457072 46457070 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234454 58234452 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92724267 92724264 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80544346 80544348 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80646057 80646055 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46193039 46193040 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46288004 46288005 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46402143 46402144 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46454749 46454748 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80537614 80537615 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699193 92699192 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461728 46461728 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.53 ms 4.42 ms -0.11 ms (-2.39%) 6.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.11 ms -0.11 ms (-2.11%) 5.29%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.20 ms 5.10 ms -0.10 ms (-1.89%) 4.81%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.50 ms 5.40 ms -0.10 ms (-1.88%) 4.95%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.03 ms -0.09 ms (-1.85%) 5.02%
transfer_no_resume_ring_1.3_rsa_aes 6.00 ms 5.90 ms -0.09 ms (-1.58%) 4.31%
transfer_no_resume_ring_1.2_rsa_aes 5.90 ms 5.81 ms -0.09 ms (-1.55%) 3.94%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.62 ms 8.52 ms -0.10 ms (-1.18%) 2.92%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 457.97 µs 452.59 µs -5.38 µs (-1.17%) 3.56%
handshake_no_resume_ring_1.3_ecdsap256_chacha 476.44 µs 470.99 µs -5.46 µs (-1.14%) 3.19%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 455.32 µs 450.17 µs -5.16 µs (-1.13%) 3.54%
handshake_no_resume_ring_1.3_ecdsap256_aes 482.50 µs 477.41 µs -5.09 µs (-1.06%) 3.31%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.00 ms 12.89 ms -0.11 ms (-0.86%) 2.06%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.01 ms 12.90 ms -0.11 ms (-0.83%) 1.95%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.11 ms -0.01 ms (-0.83%) 2.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.69 ms 13.58 ms -0.11 ms (-0.78%) 1.75%
transfer_no_resume_ring_1.3_rsa_chacha 13.50 ms 13.40 ms -0.10 ms (-0.76%) 1.76%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.69 ms 13.59 ms -0.10 ms (-0.73%) 1.77%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.12 ms 16.03 ms -0.10 ms (-0.59%) 1.48%
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.65 ms -0.01 ms (-0.57%) 1.45%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.08 ms -0.01 ms (-0.55%) 3.72%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.52 ms 5.49 ms -0.03 ms (-0.51%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.14 ms 1.13 ms -0.01 ms (-0.49%) 1.19%
handshake_tickets_ring_1.3_rsa_chacha 6.06 ms 6.04 ms -0.03 ms (-0.45%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.00 ms 5.98 ms -0.03 ms (-0.42%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.57 ms 5.55 ms -0.02 ms (-0.40%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.15 ms 1.14 ms -0.00 ms (-0.40%) 1.56%
handshake_no_resume_ring_1.3_rsa_chacha 977.88 µs 973.97 µs -3.91 µs (-0.40%) 1.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.27 ms 4.25 ms -0.02 ms (-0.39%) 1.65%
handshake_tickets_ring_1.3_ecdsap256_aes 5.78 ms 5.76 ms -0.02 ms (-0.38%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.46 ms 4.45 ms -0.02 ms (-0.38%) 1.57%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.95 ms 4.94 ms -0.02 ms (-0.37%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.37 ms 6.35 ms -0.02 ms (-0.36%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.64 ms 0.01 ms (0.33%) 2.39%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.30 ms 4.29 ms -0.01 ms (-0.32%) 1.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.94 ms 4.93 ms -0.01 ms (-0.30%) 1.08%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.62 ms 8.60 ms -0.02 ms (-0.29%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.28 ms 6.26 ms -0.02 ms (-0.28%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.87 ms 5.86 ms -0.02 ms (-0.28%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.16 ms 5.14 ms -0.01 ms (-0.25%) 1.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.14 ms 5.13 ms -0.01 ms (-0.25%) 1.31%
handshake_tickets_ring_1.3_ecdsap384_aes 8.90 ms 8.88 ms -0.02 ms (-0.23%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 976.72 µs 974.46 µs -2.25 µs (-0.23%) 1.14%
handshake_session_id_ring_1.3_ecdsap384_aes 8.98 ms 8.96 ms -0.02 ms (-0.22%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 4.99 ms 4.97 ms -0.01 ms (-0.22%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.68 ms 8.6 8000 6 ms -0.02 ms (-0.21%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 966.19 µs 964.63 µs -1.56 µs (-0.16%) 1.46%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.01 ms (-0.16%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.98 ms 4.97 ms -0.01 ms (-0.15%) 1.35%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.82 ms 1.82 ms 0.00 ms (0.14%) 2.12%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms -0.00 ms (-0.12%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.17 ms 5.18 ms 0.00 ms (0.09%) 1.31%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.16 ms 5.16 ms 0.00 ms (0.09%) 1.41%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.49 ms 4.49 ms -0.00 ms (-0.09%) 1.60%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.57 ms -0.00 ms (-0.06%) 1.41%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms 0.00 ms (0.02%) 1.41%

Additional information

Historical results

Checkout details:

@djc djc mentioned this pull request Mar 17, 2025
Merged
@codecov Codecov
Copy link
codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.82%. Comparing base (da46c21) to head (e6985f0).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/webpki/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2384      +/-   ##
==========================================
+ Coverage   94.78%   94.82%   +0.03%     
==========================================
  Files         103      103              
  Lines       24641    24918     +277     
==========================================
+ Hits        23357    23629     +272     
- Misses       1284     1289       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 317c5bf Mar 17, 2025
61 of 62 checks passed
@djc djc deleted the invalid-purpose branch March 17, 2025 13:05
@zerosnacks zerosnacks mentioned this pull request Mar 17, 2025
Merged
2 tasks
@djc djc mentioned this pull request Mar 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz
0