8000 Revert "Pin cargo-hack@0.6.33 for now" by ctz · Pull Request #2390 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Pin cargo-hack@0.6.33 for now" #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Revert "Pin cargo-hack@0.6.33 for now" #2390

merged 1 commit into from
Mar 20, 2025

Conversation

ctz
Copy link
Member
@ctz ctz commented Mar 20, 2025

This reverts commit 4ec06b6.

(cargo-hack 0.6.36 was released)

Copy link
rustls-benchmarking bot commented Mar 20, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10496885 10435557 -61328 (-0.58%) 0.88%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10765835 10723725 -42110 (-0.39%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1149181 1144933 -4248 (-0.37%) 1.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1147298 1151472 4174 (0.36%) 1.49%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8327060 8298326 -28734 (-0.35%) 0.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8311348 8290391 -20957 (-0.25%) 0.73%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3098992 3104660 5668 (0.18%) 0.54%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3102232 3096706 -5526 (-0.18%) 0.58%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10725470 10708456 -17014 (-0.16%) 2.02%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304395 3304264 -131 (-0.00%) 0.25%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305342 3305239 -103 (-0.00%) 0.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28750652 28750334 -318 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934320 1934301 -19 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28828493 28828738 245 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297306 1297296 -10 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28828751 28828952 201 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28208920 28209112 192 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30269338 30269166 -172 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30226660 30226508 -152 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27805230 27805361 131 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28205003 28204881 -122 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27807729 27807841 112 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30223987 30223879 -108 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30269183 30269079 -104 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28201925 28202007 82 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27812182 27812252 70 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27864698 27864767 69 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719438 1719434 -4 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1296123 1296126 3 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30226521 30226590 69 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28826190 28826251 61 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2064751 2064755 4 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28231786 28231834 48 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28747804 28747851 47 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229716 7229706 -10 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28750263 28750301 38 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27867174 27867198 24 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743660 34743635 -25 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28234661 28234675 14 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30266657 30266643 -14 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741945 34741930 -15 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227756 7227753 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46294750 46294739 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46298258 46298269 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154252 58154240 -12 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28238669 28238665 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80549149 80549138 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92691208 92691219 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699198 92699188 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46402149 46402146 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80646053 80646048 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235825 58235822 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80641399 80641395 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46193042 46193040 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58258980 58258978 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697829 92697827 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461732 46461731 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58041298 58041299 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122641 58122642 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80537615 80537614 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80638425 80638424 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668741 92668740 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92724260 92724261 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163847 58163847 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32568970 32568970 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32003149 32003149 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2061629 2061629 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234464 58234464 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30852246 30852246 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32571507 32571507 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5020822 5020822 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31242173 31242173 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32469582 32469582 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31170962 31170962 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4321822 4321822 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134446 11134446 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31167567 31167567 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46457072 46457072 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32000650 32000650 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30947572 30947572 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129853 58129853 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3873525 3873525 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46454746 46454746 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30943476 30943476 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92659618 92659618 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32124769 32124769 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32122270 32122270 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927555 1927555 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4770422 4770422 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4305728 4305728 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32571496 32571496 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31246121 31246121 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3890211 3890211 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31174910 31174910 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31238757 31238757 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339383 2339383 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46288005 46288005 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128684 11128684 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246009 2246009 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4233042 4233042 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4585153 4585153 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32003220 32003220 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30849301 30849301 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80544348 80544348 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27871637 27871637 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000242 11000242 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32469616 32469616 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30856342 30856342 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32467045 32467045 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32124840 32124840 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333733 2333733 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30940531 30940531 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.18 ms 5.21 ms 0.04 ms (0.70%) 5.29%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.44 ms 5.48 ms 0.04 ms (0.68%) 4.95%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.15 ms 5.18 ms 0.03 ms (0.67%) 4.82%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.48 ms 4.51 ms 0.03 ms (0.65%) 5.96%
transfer_no_resume_ring_1.2_rsa_aes 5.86 ms 5.88 ms 0.03 ms (0.48%) 4.29%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.56 ms 8.60 ms 0.04 ms (0.45%) 2.92%
transfer_no_resume_ring_1.3_rsa_aes 5.94 ms 5.97 ms 0.03 ms (0.44%) 4.65%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.08 ms 5.10 ms 0.02 ms (0.43%) 4.89%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.38%) 3.72%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.96 ms 4.94 ms -0.02 ms (-0.37%) 1.09%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.28 ms 4.27 ms -0.02 ms (-0.36%) 1.78%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.31 ms 4.30 ms -0.01 ms (-0.33%) 1.50%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.63 ms 13.68 ms 0.04 ms (0.32%) 1.73%
handshake_no_resume_ring_1.3_ecdsap256_aes 480.89 µs 482.39 µs 1.50 µs (0.31%) 3.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.49 ms -0.01 ms (-0.29%) 1.60%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.98 ms 0.04 ms (0.29%) 2.06%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.61 ms 13.65 ms 0.04 ms (0.29%) 1.80%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.98 ms 4.97 ms -0.01 ms (-0.28%) 1.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.94 ms 12.98 ms 0.04 ms (0.28%) 2.18%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.01 ms 4.99 ms -0.01 ms (-0.26%) 1.26%
handshake_no_resume_ring_1.3_ecdsap256_chacha 473.60 µs 474.81 µs 1.21 µs (0.25%) 3.39%
transfer_no_resume_ring_1.3_rsa_chacha 13.44 ms 13.47 ms 0.03 ms (0.25%) 2.03%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.19 ms -0.01 ms (-0.24%) 1.49%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.07 ms 16.10 ms 0.04 ms (0.23%) 1.61%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.12 ms 0.00 ms (0.23%) 1.43%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.60 ms 5.59 ms -0.01 ms (-0.23%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.48 ms 4.47 ms -0.01 ms (-0.23%) 1.72%
handshake_no_resume_ring_1.2_rsa_aes 964.99 µs 967.06 µs 2.07 µs (0.21%) 1.33%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.81 ms -0.00 ms (-0.21%) 1.98%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.16 ms 5.15 ms -0.01 ms (-0.20%) 1.37%
handshake_tickets_ring_1.3_ecdsap256_aes 5.81 ms 5.80 ms -0.01 ms (-0.20%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.54 ms 5.53 ms -0.01 ms (-0.20%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.90 ms 5.89 ms -0.01 ms (-0.20%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.61 ms 0.01 ms (0.19%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.17 ms 5.16 ms -0.01 ms (-0.19%) 1.43%
handshake_tickets_ring_1.3_rsa_aes 6.31 ms 6.30 ms -0.01 ms (-0.19%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.16 ms 5.15 ms -0.01 ms (-0.17%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 454.18 µs 454.94 µs 0.76 µs (0.17%) 3.54%
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.66 ms -0.00 ms (-0.17%) 1.39%
handshake_tickets_ring_1.3_rsa_chacha 6.09 ms 6.08 ms -0.01 ms (-0.16%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.03 ms 6.02 ms -0.01 ms (-0.16%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.96 ms 4.95 ms -0.01 ms (-0.15%) 1.18%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.57 ms -0.00 ms (-0.15%) 1.22%
handshake_session_id_ring_1.3_rsa_aes 6.39 ms 6.38 ms -0.01 ms (-0.15%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 456.68 µs 457.35 µs 0.67 µs (0.15%) 3.84%
handshake_no_resume_ring_1.3_rsa_chacha 975.33 µs 976.71 µs 1.39 µs (0.14%) 1.24%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.60 ms 0.00 ms (0.13%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 976.22 µs 977.44 µs 1.22 µs (0.13%) 1.19%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.15 ms 1.15 ms 0.00 ms (0.11%) 1.43%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.71 ms 8.71 ms -0.01 ms (-0.10%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.14 ms 1.14 ms 0.00 ms (0.10%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.11 ms 1.11 ms 0.00 ms (0.07%) 2.48%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.65 ms 8.64 ms -0.01 ms (-0.06%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.63 ms 1.63 ms 0.00 ms (0.05%) 2.22%
handshake_session_id_ring_1.3_ecdsap384_aes 9.00 ms 9.00 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.92 ms 8.92 ms -0.00 ms (-0.01%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (4ec06b6) to head (e5f3c0d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2390   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          94       94           
  Lines       22815    22815           
=======================================
  Hits        21939    21939           
  Misses        876      876

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz enabled auto-merge March 20, 2025 18:33
@ctz ctz added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 293f05e Mar 20, 2025
73 checks passed
@ctz ctz deleted the jbp-unpin-cargo-hack branch March 20, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
< 53D9 span class="css-truncate">

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctz @cpu
0