ci: pin cmake to 3.28 on linux #2408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake 4.0 is not compatible w/ aws-lc until the forthcoming release. The runner image switched the version out from under us. Pin it back until one side or the other sorts itself out.
argh, I was hoping it was just the Linux runners that had the issue. I'm not sure I know how to easily remedy this on Windows 🤔 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2408 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 94 94
Lines 22815 22815
=======================================
Hits 21939 21939
Misses 876 876 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Maybe best to exclude FIPS builds on Windows/MacOS for now? |
|
@cpu see fix for Windows and Ubuntu here |
|
Closing this - I think an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake 4.0 is not compatible w/ aws-lc FIPS builds until the forthcoming release. The runner image switched the version out from under us. Pin it back until one side or the other sorts itself out.
The runner-image-provided
cmake@4.0is in/usr/local/cmakeand has higher$PATHpriority. Rather than munge with thePATHand change other things we symbolic link the installedcmake@3.28over-top.Fixes the build failures on
main.See aws/aws-lc-rs#755, actions/runner-images#11926