8000 Use tlswg name for draft-kwiatkowski-tls-ecdhe-mlkem by ctz · Pull Request #2418 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use tlswg name for draft-kwiatkowski-tls-ecdhe-mlkem #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Conversation

ctz
Copy link
Member
@ctz ctz commented Apr 8, 2025

No description provided.

Copy link
rustls-benchmarking bot commented Apr 8, 2025

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1153682 1157860 4178 (0.36%) 1.46%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10687395 10718155 30760 (0.29%) 1.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8307594 8330413 22819 (0.27%) 0.74%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8306268 8327024 20756 (0.25%) 0.92%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10747080 10728786 -18294 (-0.17%) 1.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3099272 3104410 5138 (0.17%) 0.47%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3300701 3305144 4443 (0.13%) 0.27%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10447680 10456918 9238 (0.09%) 0.94%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303845 3301822 -2023 (-0.06%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3101763 3102204 441 (0.01%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2071072 2071136 64 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927426 1927445 19 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2068087 2068106 19 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297064 1297054 -10 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27803404 27803586 182 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27860209 27860386 177 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30263299 30263484 185 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28821355 28821185 -170 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27801158 27801012 -146 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28745979 28746126 147 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28230229 28230104 -125 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28743056 28742939 -117 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28234084 28234185 101 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28824300 28824401 101 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28204416 28204484 68 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27867165 27867230 65 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719375 1719379 4 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30217760 30217829 69 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30260276 30260339 63 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28746023 28745970 -53 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28824187 28824140 -47 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28200608 28200566 -42 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27807797 27807837 40 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27862681 27862711 30 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28197506 28197478 -28 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28227386 28227368 -18 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30220702 30220683 -19 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741688 34741675 -13 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30220915 30220906 -9 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227513 7227515 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58233813 58233829 16 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46294740 46294749 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58258331 58258340 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46456436 46456430 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80638425 80638435 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92724266 92724255 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46193045 46193050 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461089 46461094 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80537614 80537607 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46298258 46298262 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46401502 46401506 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92658977 92658970 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129853 58129857 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58162564 58162568 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46454108 46454105 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80549143 80549148 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697823 92697818 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154255 58154252 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235185 58235182 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46288007 46288005 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80641396 80641399 3 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58040661 58040659 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80646053 80646051 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668102 92668104 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699189 92699187 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122642 58122641 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80544341 80544342 1 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30935214 30935214 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31166600 31166600 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4583443 4583443 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31233911 31233911 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30939322 30939322 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5018062 5018062 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32560930 32560930 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30848032 30848032 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996897 10996897 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30843924 30843924 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295882 1295882 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30263417 30263417 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11125214 11125214 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30840981 30840981 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333545 2333545 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3889611 3889611 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4767842 4767842 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4303178 4303178 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32564007 32564007 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92690579 92690579 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32462026 32462026 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4232262 4232262 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3871875 3871875 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339194 2339194 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30932271 30932271 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32458975 32458975 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743362 34743362 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31995319 31995319 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934174 1934174 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32462052 32462052 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229464 7229464 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32113930 32113930 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245945 2245945 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31992280 31992280 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4320082 4320082 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31237871 31237871 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32563936 32563936 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31995420 31995420 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31162640 31162640 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31230497 31230497 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32116969 32116969 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31159247 31159247 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1155559 1155559 0 (0.00%) 0.75%
handshake_no_resume_ring_1.3_rsa_chacha_server 11130975 11130975 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32117070 32117070 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.56 ms 4.44 ms -0.12 ms (-2.66%) 5.09%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.26 ms 5.14 ms -0.12 ms (-2.31%) 4.46%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.22 ms 5.10 ms -0.12 ms (-2.24%) 4.25%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.15 ms 5.04 ms -0.11 ms (-2.19%) 4.61%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.47 ms 5.36 ms -0.11 ms (-2.03%) 4.07%
transfer_no_resume_ring_1.3_rsa_aes 5.96 ms 5.85 ms -0.11 ms (-1.93%) 3.08%
transfer_no_resume_ring_1.2_rsa_aes 5.90 ms 5.79 ms -0.11 ms (-1.83%) 4.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 459.49 µs 451.33 µs -8.16 µs (-1.78%) 3.12%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 461.39 µs 453.82 µs -7.57 µs (-1.64%) 3.29%
handshake_no_resume_ring_1.3_ecdsap256_aes 480.98 µs 473.94 µs -7.04 µs (-1.46%) 3.12%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.57 ms 8.46 ms -0.11 ms (-1.32%) 2.16%
handshake_no_resume_ring_1.3_ecdsap256_chacha 478.34 µs 472.14 µs -6.20 µs (-1.30%) 2.46%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.11 ms 1.10 ms -0.01 ms (-1.13%) 2.73%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.54 ms 4.49 ms -0.05 ms (-1.10%) 1.15%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.22 ms 5.17 ms -0.05 ms (-0.98%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.33 ms 4.29 ms -0.04 ms (-0.97%) 1.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.36 ms 4.32 ms -0.04 ms (-0.87%) 1.17%
transfer_no_resume_ring_1.3_rsa_chacha 13.53 ms 13.41 ms -0.12 ms (-0.86%) 1.25%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.03 ms 12.92 ms -0.11 ms (-0.85%) 1.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.22 ms 5.17 ms -0.04 ms (-0.85%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.03 ms 12.93 ms -0.11 ms (-0.83%) 1.59%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.70 ms 13.59 ms -0.11 ms (-0.81%) 1.52%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.56 ms 4.52 ms -0.04 ms (-0.81%) 1.14%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.73 ms 13.62 ms -0.11 ms (-0.79%) 1.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.00 ms 4.96 ms -0.04 ms (-0.77%) 1.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.25 ms 5.21 ms -0.04 ms (-0.75%) 1.35%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.14 ms 16.02 ms -0.12 ms (-0.73%) 1.23%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.80 ms 1.79 ms -0.01 ms (-0.72%) 1.88%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.00 ms 4.96 ms -0.04 ms (-0.70%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.22 ms 5.18 ms -0.04 ms (-0.69%) 1.20%
handshake_no_resume_ring_1.3_rsa_chacha 967.77 µs 961.38 µs -6.39 µs (-0.66%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.15 ms 1.15 ms -0.01 ms (-0.65%) 1.14%
handshake_no_resume_ring_1.2_rsa_aes 962.96 µs 956.91 µs -6.05 µs (-0.63%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.14 ms 1.14 ms -0.01 ms (-0.62%) 1.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.05 ms 5.02 ms -0.03 ms (-0.62%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.63 ms 1.62 ms -0.01 ms (-0.61%) 1.28%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.60 ms -0.01 ms (-0.60%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.02 ms 4.99 ms -0.03 ms (-0.60%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 967.04 µs 961.46 µs -5.58 µs (-0.58%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.01 ms (-0.44%) 1.14%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.53 ms 5.51 ms -0.02 ms (-0.41%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 5.98 ms -0.02 ms (-0.38%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.09 ms -0.02 ms (-0.37%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.58 ms 5.56 ms -0.02 ms (-0.36%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.07 ms 6.05 ms -0.02 ms (-0.36%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.62 ms 5.61 ms -0.02 ms (-0.33%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.56 ms 5.55 ms -0.02 ms (-0.32%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.62 ms 8.59 ms -0.03 ms (-0.29%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.58 ms 3.57 ms -0.01 ms (-0.27%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.03 ms -0.02 ms (-0.26%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.68 ms 8.66 ms -0.02 ms (-0.25%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.72 ms 8.70 ms -0.02 ms (-0.22%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.11 ms -0.00 ms (-0.19%) 2.70%
handshake_session_id_ring_1.3_ecdsap384_aes 8.65 ms 8.63 ms -0.02 ms (-0.19%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.18%) 2.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.58 ms 3.57 ms -0.00 ms (-0.11%) 1.00%

Additional information 8000

Historical results

Checkout details:

@ctz ctz enabled auto-merge April 8, 2025 11:59
Copy link
codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (c1fc0f4) to head (fa11223).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2418   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files          94       94           
  Lines       22525    22525           
=======================================
  Hits        21626    21626           
  Misses        899      899           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 68d6ef2 Apr 8, 2025
64 checks passed
@ctz ctz deleted the jbp-pq-draft branch April 8, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0