Add prefer-post-quantum to default features
#2425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables, for dependents who use default-features, X25519MLKEM768 as the most-preferred key exchange.
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2425 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 94 94
Lines 22567 22567
=======================================
Hits 21667 21667
Misses 900 900 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djc
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables, for dependents who use default-features, X25519MLKEM768 as the most-preferred key exchange.
This is another step on the way to enabling this by default. In a future release, I plan to deprecate this feature, make it do nothing, and therefore unconditionally have
X25519MLKEM768as the most preferred key exchange in the default aws-lc-rs provider.Users who wish to opt-out from that change would then have to construct a customized
CryptoProviderin their code.