8000 Improve invalid key purpose errors by djc · Pull Request #2426 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve invalid key purpose errors #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

Improve invalid key purpose errors #2426

merged 3 commits into from
May 5, 2025

Conversation

djc
Copy link
Member
@djc djc commented Apr 13, 2025

@djc djc requested review from cpu and ctz April 13, 2025 10:27
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Apr 13, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10497123 10438569 -58554 (-0.56%) 1.13%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3593127 3580041 -13086 (-0.36%) 1.36%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2007642 2001222 -6420 (-0.32%) 1.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4760766 4747441 -13325 (-0.28%) 0.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9978098 9955694 -22404 (-0.22%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11569316 11555773 -13543 (-0.12%) 1.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78730519 78648784 -81735 (-0.10%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9969836 9978532 8696 (0.09%) 0.91%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11570254 11578917 8663 (0.07%) 1.74%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56582347 56543064 -39283 (-0.07%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3584921 3587349 2428 (0.07%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4760900 4757720 -3180 (-0.07%) 0.24%
handshake_session_id_ring_1.2_rsa_aes_server 4300814 4298144 -2670 (-0.06%) 0.27%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78482445 78526027 43582 (0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3869745 3867855 -1890 (-0.05%) 0.35%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4749876 4747807 -2069 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719041 1719743 702 (0.04%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333229 2334066 837 (0.04%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2338878 2339715 837 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55276468 55294415 17947 (0.03%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245597 2246298 701 (0.03%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303677 3304456 779 (0.02%) 0.26%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3304804 3305581 777 (0.02%) 0.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78469793 78487528 17735 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4219240 4218370 -870 (-0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4570638 4569708 -930 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3877047 3876267 -780 (-0.02%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4307004 4306164 -840 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78693456 78707416 13960 (0.02%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46197238 46189325 -7913 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46302464 46294534 -7930 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46298942 46291018 -7924 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46292199 46284280 -7919 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55300428 55290986 -9442 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46460629 46452707 -7922 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46405697 46397786 -7911 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458123 46450206 -7917 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78710424 78723576 13152 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2913488 2913011 -477 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46468532 46461252 -7280 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78684169 78696376 12207 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56562452 56570941 8489 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78507923 78496226 -11697 (-0.01%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2909843 2910265 422 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56600246 56608232 7986 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30830769 30835051 4282 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30833518 30837796 4278 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30922059 30926341 4282 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30837704 30841974 4270 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30924808 30929086 4278 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30928994 30933264 4270 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31148991 31153265 4274 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31220241 31224515 4274 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31152222 31156472 4250 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31156280 31160522 4242 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31223493 31227743 4250 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31227551 31231793 4242 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56550586 56558200 7614 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5011624 5012134 510 (0.01%) 0.28%
transfer_no_resume_ring_1.2_rsa_aes_client 58041282 58035393 -5889 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163187 58157297 -5890 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548545 80540614 -7931 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541805 80533883 -7922 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553343 80545422 -7921 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642448 80634524 -7924 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645584 80637669 -7915 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80653486 80645572 -7914 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55278196 55283219 5023 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122630 58117366 -5264 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154236 58148973 -5263 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129836 58124579 -5257 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58231416 58226787 -4629 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58231949 58227324 -4625 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58256234 58251610 -4624 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78700877 78694870 -6007 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55223336 55219262 -4074 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55217458 55213404 -4054 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92690559 92685290 -5269 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92658954 92653688 -5266 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668095 92662829 -5266 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92696050 92691427 -4623 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92696597 92691974 -4623 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92722146 92717523 -4623 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55230641 55227932 -2709 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56586738 56583967 -2771 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78473356 78470190 -3166 (-0.00%) 0.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56610440 56612665 2225 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295523 1295484 -39 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296718 1296679 -39 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741363 34742294 931 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743102 34744010 908 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78465413 78467277 1864 (0.00%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003260 2003214 -46 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78733907 78735488 1581 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78445370 78444570 -800 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31990673 31990943 270 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112323 32112593 270 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987543 31987783 240 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31990504 31990744 240 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109193 32109433 240 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112154 32112394 240 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32447924 32448134 210 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32450970 32451180 210 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32549879 32550089 210 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32552925 32553135 210 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229121 7229076 -45 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32450958 32451138 180 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32552868 32553048 180 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227154 7227117 -37 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11124855 11124822 -33 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11130616 11130583 -33 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996791 10996775 -16 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.85 ms 1.79 ms -0.06 ms (-3.24%) 4.28%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.10 ms 1.07 ms -0.03 ms (-2.68%) 6.08%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.66 ms 1.62 ms -0.04 ms (-2.64%) 3.57%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.45 ms 5.31 ms -0.14 ms (-2.62%) 5.63%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.17 ms 5.04 ms -0.12 ms (-2.41%) 6.74%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.34 ms 1.31 ms -0.03 ms (-2.37%) 5.61%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.77 ms 4.66 ms -0.11 ms (-2.35%) 5.72%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.34 ms 1.31 ms -0.03 ms (-2.13%) 9.17%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.47 ms 5.35 ms -0.11 ms (-2.05%) 5.77%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.46 ms 5.36 ms -0.11 ms (-1.97%) 5.30%
transfer_no_resume_ring_1.3_rsa_aes 5.96 ms 5.85 ms -0.11 ms (-1.84%) 5.04%
transfer_no_resume_ring_1.2_rsa_aes 5.88 ms 5.78 ms -0.11 ms (-1.80%) 5.34%
handshake_no_resume_ring_1.3_ecdsap256_chacha 479.27 µs 472.29 µs -6.97 µs (-1.46%) 3.64%
handshake_no_resume_ring_1.3_ecdsap256_aes 482.12 µs 475.44 µs -6.68 µs (-1.39%) 3.76%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 670.79 µs 661.61 µs -9.18 µs (-1.37%) 3.91%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.56 ms 8.45 ms -0.11 ms (-1.29%) 3.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 670.31 µs 661.93 µs -8.38 µs (-1.25%) 4.31%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.59 ms -0.02 ms (-1.10%) 2.56%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.92 ms 13.78 ms -0.14 ms (-1.00%) 2.60%
handshake_session_id_ring_1.2_rsa_aes 1.53 ms 1.51 ms -0.01 ms (-0.96%) 2.17%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.24 ms 13.12 ms -0.12 ms (-0.91%) 2.41%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.03 ms 12.92 ms -0.11 ms (-0.84%) 2.64%
transfer_no_resume_ring_1.3_rsa_chacha 13.52 ms 13.41 ms -0.11 ms (-0.81%) 2.59%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.92 ms 13.81 ms -0.11 ms (-0.80%) 2.10%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.14 ms 16.01 ms -0.12 ms (-0.75%) 2.10%
handshake_no_resume_ring_1.3_rsa_chacha 968.87 µs 962.54 µs -6.33 µs (-0.65%) 1.53%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.36 ms 1.35 ms -0.01 ms (-0.54%) 1.68%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.35 ms 1.34 ms -0.01 ms (-0.49%) 2.50%
handshake_no_resume_ring_1.3_rsa_aes 967.71 µs 963.06 µs -4.65 µs (-0.48%) 1.96%
handshake_no_resume_ring_1.2_rsa_aes 963.34 µs 959.26 µs -4.08 µs (-0.42%) 1.33%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.48 ms 11.44 ms -0.04 ms (-0.37%) 2.46%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.30 ms 11.27 ms -0.03 ms (-0.29%) 1.51%
handshake_tickets_ring_1.3_ecdsap256_aes 5.62 ms 5.60 ms -0.02 ms (-0.28%) 1.34%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.58 ms 3.57 ms -0.01 ms (-0.27%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.45 ms 11.42 ms -0.03 ms (-0.27%) 2.07%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.58 ms 5.57 ms -0.01 ms (-0.25%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.10 ms 6.09 ms -0.01 ms (-0.24%) 1.36%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.67 ms 8.66 ms -0.02 ms (-0.22%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.58 ms 3.58 ms -0.01 ms (-0.22%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.54 ms 5.53 ms -0.01 ms (-0.20%) 1.46%
handshake_tickets_ring_1.3_ecdsap384_aes 8.71 ms 8.70 ms -0.01 ms (-0.17%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.49 ms 11.47 ms -0.02 ms (-0.17%) 1.50%
handshake_tickets_ring_1.3_rsa_chacha 6.06 ms 6.05 ms -0.01 ms (-0.16%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.80 ms 10.79 ms -0.02 ms (-0.15%) 1.98%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.56 ms 10.58 ms 0.02 ms (0.15%) 1.82%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.60 ms 8.59 ms -0.01 ms (-0.12%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.50 ms -0.01 ms (-0.12%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.25 ms 11.24 ms -0.01 ms (-0.12%) 1.55%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.61 ms 10.60 ms -0.01 ms (-0.11%) 1.87%
handshake_session_id_ring_1.3_ecdsap384_aes 8.64 ms 8.63 ms -0.01 ms (-0.10%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.23 ms 11.25 ms 0.01 ms (0.10%) 1.33%
handshake_session_id_ring_1.3_rsa_chacha 5.99 ms 5.99 ms -0.01 ms (-0.09%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.29 ms 11.28 ms -0.01 ms (-0.07%) 1.36%
handshake_session_id_ring_1.3_rsa_aes 6.04 ms 6.03 ms -0.00 ms (-0.06%) 1.12%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.76 ms 10.77 ms 0.00 ms (0.04%) 2.24%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.44 ms 11.44 ms 0.00 ms (0.01%) 2.19%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Apr 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 95.54%. Comparing base (9509626) to head (3616109).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/error.rs 73.17% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2426      +/-   ##
==========================================
- Coverage   95.57%   95.54%   -0.04%     
==========================================
  Files          95       95              
  Lines       22843    22892      +49     
==========================================
+ Hits        21833    21872      +39     
- Misses       1010     1020      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cpu
cpu reviewed Apr 18, 2025
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

Will hold approving until the cargo patch is dropped, but the implementation LGTM.

@djc djc mentioned this pull request Apr 22, 2025
Merged
@djc djc marked this pull request as ready for review April 22, 2025 15:02
@djc djc marked this pull request as draft April 22, 2025 15:02
@djc djc marked this pull request as ready for review April 23, 2025 07:55
@djc
Copy link
Member Author
djc commented Apr 23, 2025 •
edited
Loading

Nice :-)

Will hold approving until the cargo patch is dropped, but the implementation LGTM.

I think having rustls-webpki 0.103.2 be out in the wild before rustls 0.23.27 is released would lead to suboptimal error handling, so I kinda want to get my approvals for this PR before I publish rustls-webpki 0.103.2.

I think the remaining CI failures are all because of the dependency on a published rustls-webpki so that's a bit annoying but not sure it's worth doing something about?

8000

@djc djc mentioned this pull request Apr 23, 2025
Merged
ctz
ctz approved these changes Apr 23, 2025
View reviewed changes
@djc djc force-pushed the eku-errors branch 4 times, most recently from 50bd546 to 12e9e98 Compare May 5, 2025 19:11
@djc djc force-pushed the eku-errors branch 2 times, most recently from 1762dd1 to 6328ce1 Compare May 5, 2025 19:47
@djc djc added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 2601909 May 5, 2025
33 of 34 checks passed
@djc djc deleted the eku-errors branch May 5, 2025 20:19
@djc
Copy link
Member Author
djc commented May 5, 2025
  • Published rustls v0.23.27 at registry crates-io
  • [new tag] v/0.23.27 -> v/0.23.27
  • Release notes

@cpu cpu mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz
0