Reduce use of library internals in tests #2421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
=======================================
Coverage 96.00% 96.01%
=======================================
Files 94 94
Lines 22525 22578 +53
=======================================
+ Hits 21626 21678 +52
- Misses 899 900 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
djc
reviewed
Apr 9, 2025
569dd42 to
60c781a
Compare
60c781a to
ea7b3d7
Compare
djc
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
Nice! I think the commit history would be nicer if it flowed the other way:
message_framing()(last commit with bits it needs from the new module)handshake_framing()(half of the second commit)
This would split the introduction of the encoding module starting with the lower-level bits and working up to the higher-level functions.
ea7b3d7 to
02df69a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the reliance of our tests on internal types for the future benefit of #1475.
Instead of that,
tests::common::encodingis some very stupid code that can produce a variety of client hellos. Making that separate also means we're not testing rustls against itself, and the test code is not fighting against the type-safe internals code when constructing invalid input (see, eg,server_rejects_sni_with_illegal_dns_name).