8000 0.23.26: Detect and error on faulty `io::Write::write_vectored` by ctz · Pull Request #2422 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

0.23.26: Detect and error on faulty io::Write::write_vectored #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

0.23.26: Detect and error on faulty io::Write::write_vectored #2422

merged 2 commits into from
Apr 10, 2025

Conversation

ctz
Copy link
Member
@ctz ctz commented Apr 9, 2025 •
edited
Loading

fixes #2316

Release notes for 0.23.26

  • Bug fix: in certain circumstances we saw std::io::Write::write_vectored implementations that reported writing more bytes than were available, in violation of that method's invariants. This seems to happen on macOS with certain VPN software active. Now we detect and return an error from write_tls calls in this case. See Panic in write_tls #2316.
  • Admit support for a wider set of SignatureSchemes in TLS1.3, so that external providers may support ED448, post-quantum signatures, and others. See Invert working of SignatureScheme::supported_in_tls13 #2420.

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Apr 9, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8297107 8331024 33917 (0.41%) 0.88%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1157927 1153593 -4334 (-0.37%) 1.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1155626 1151383 -4243 (-0.37%) 1.45%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10468335 10435728 -32607 (-0.31%) 0.97%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10655968 10682383 26415 (0.25%) 1.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3104775 3097197 -7578 (-0.24%) 0.34%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3102349 3095037 -7312 (-0.24%) 0.35%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8299074 8315748 16674 (0.20%) 0.80%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305055 3300973 -4082 (-0.12%) 0.25%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3871875 3868515 -3360 (-0.09%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5018062 5014492 -3570 (-0.07%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4303178 4300238 -2940 (-0.07%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4767842 4764932 -2910 (-0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10716487 10722119 5632 (0.05%) 1.02%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3889611 3887721 -1890 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4232262 4230372 -1890 (-0.04%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4320082 4318612 -1470 (-0.03%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4583443 4581973 -1470 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28748007 28744706 -3301 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28745028 28741761 -3267 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28826452 28823251 -3201 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28748077 28744923 -3154 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28823215 28820152 -3063 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28826257 28823386 -2871 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32460715 32457625 -3090 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32463792 32460702 -3090 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32463766 32460736 -3030 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27800903 27803492 2589 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32562670 32559730 -2940 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32565747 32562807 -2940 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31997160 31994310 -2850 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32565676 32562796 -2880 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31994020 31991200 -2820 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31997059 31994239 -2820 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30219954 30217412 -2542 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32118810 32116110 -2700 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28200530 28202886 2356 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27860331 27862649 2318 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32115670 32113000 -2670 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32118709 32116039 -2670 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27867134 27869405 2271 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27862666 27864930 2264 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28204557 28206832 2275 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28197524 28199797 2273 (0.01%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46193040 46189322 -3718 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46294749 46291024 -3725 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46288008 46284284 -3724 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30222991 30220562 -2429 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46298259 46294542 -3717 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30222738 30220312 -2426 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46401506 46397784 -3722 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46454114 46450388 -3726 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46456433 46452712 -3721 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461089 46457368 -3721 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27807974 27810189 2215 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28227277 28229474 2197 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30265511 30263173 -2338 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27803437 27805579 2142 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28230306 28232468 2162 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28234261 28236384 2123 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30265497 30263222 -2275 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30262287 30260092 -2195 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927433 1927568 135 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297135 1297053 -82 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934185 1934297 112 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295938 1295863 -75 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30843924 30845514 1590 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30848032 30849622 1590 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30935214 30936804 1590 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30939322 30940912 1590 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31162640 31164230 1590 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31166600 31168190 1590 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31233911 31235501 1590 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31237871 31239461 1590 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30840981 30842545 1564 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30932271 30933835 1564 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31159247 31160821 1574 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31230497 31232071 1574 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719379 1719293 -86 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80641399 80637669 -3730 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80544348 80540628 -3720 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80537610 80533892 -3718 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80549146 80545428 -3718 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80646057 80642335 -3722 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80638424 80634712 -3712 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2071207 2071132 -75 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2067870 2067796 -74 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245945 2245883 -62 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58040659 58041940 1281 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333552 2333596 44 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339201 2339245 44 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303951 3303898 -53 (-0.00%) 0.27%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229540 7229458 -82 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996897 10996774 -123 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227571 7227496 -75 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11131033 11130951 -82 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11125272 11125195 -77 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743415 34743473 58 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741691 34741736 45 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58233811 58233818 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92724266 92724256 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92690568 92690577 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699187 92699194 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697820 92697825 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235184 58235181 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129855 58129857 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92658977 92658976 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668110 92668109 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122644 58122644 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58162566 58162566 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154252 58154252 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58258342 58258342 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.08 ms 1.11 ms ⚠️ 0.03 ms (2.84%) 2.68%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.07 ms 0.01 ms (1.26%) 2.08%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.49 ms 4.44 ms -0.05 ms (-1.11%) 4.27%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.80 ms 0.02 ms (1.00%) 1.17%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.63 ms 0.02 ms (0.98%) 1.15%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.18 ms 5.14 ms -0.04 ms (-0.83%) 3.74%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.09 ms 1.10 ms 0.01 ms (0.83%) 2.73%
transfer_no_resume_ring_1.2_rsa_aes 5.82 ms 5.78 ms -0.05 ms (-0.80%) 4.09%
transfer_no_resume_ring_1.3_rsa_aes 5.88 ms 5.84 ms -0.04 ms (-0.76%) 3.08%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.40 ms 5.36 ms -0.04 ms (-0.74%) 3.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 455.50 µs 452.64 µs -2.85 µs (-0.63%) 3.23%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.13 ms 5.10 ms -0.03 ms (-0.60%) 4.23%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.06 ms 5.04 ms -0.03 ms (-0.54%) 4.66%
handshake_session_id_ring_1.2_rsa_aes 1.50 ms 1.51 ms 0.01 ms (0.49%) 1.09%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.49 ms 8.45 ms -0.04 ms (-0.48%) 2.13%
handshake_no_resume_ring_1.3_ecdsap256_aes 474.55 µs 472.51 µs -2.03 µs (-0.43%) 3.12%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.14 ms 1.14 ms 0.00 ms (0.41%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.15 ms 0.00 ms (0.39%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 452.95 µs 451.32 µs -1.64 µs (-0.36%) 2.96%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.32 ms 4.31 ms -0.02 ms (-0.36%) 1.23%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.96 ms 12.91 ms -0.05 ms (-0.35%) 1.45%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.94 ms 4.95 ms 0.02 ms (0.31%) 1.02%
transfer_no_resume_ring_1.3_rsa_chacha 13.45 ms 13.41 ms -0.04 ms (-0.31%) 1.24%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.96 ms 12.92 ms -0.04 ms (-0.31%) 1.29%
handshake_no_resume_ring_1.3_ecdsap256_chacha 472.41 µs 470.97 µs -1.44 µs (-0.30%) 2.78%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.64 ms 13.60 ms -0.04 ms (-0.30%) 1.36%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.06 ms 16.01 ms -0.05 ms (-0.29%) 1.11%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.15 ms 5.17 ms 0.01 ms (0.27%) 1.37%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.61 ms 13.58 ms -0.03 ms (-0.24%) 1.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.16 ms 5.18 ms 0.01 ms (0.24%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 957.60 µs 955.41 µs -2.20 µs (-0.23%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.59 ms -0.00 ms (-0.22%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.01 ms 5.00 ms -0.01 ms (-0.20%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.29 ms 4.28 ms -0.01 ms (-0.14%) 1.09%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.57 ms 5.57 ms 0.01 ms (0.13%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.51 ms -0.01 ms (-0.13%) 1.10%
handshake_tickets_ring_1.3_rsa_chacha 6.05 ms 6.06 ms 0.01 ms (0.10%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 960.66 µs 959.74 µs -0.92 µs (-0.10%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.57 ms 3.57 ms -0.00 ms (-0.09%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 962.05 µs 961.18 µs -0.87 µs (-0.09%) 1.21%
handshake_session_id_ring_1.3_ecdsap256_aes 5.53 ms 5.54 ms 0.00 ms (0.08%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.66 ms 8.67 ms 0.01 ms (0.07%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.57 ms 3.57 ms -0.00 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.99 ms 5.99 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.17 ms 5.17 ms 0.00 ms (0.05%) 1.25%
handshake_session_id_ring_1.3_rsa_aes 6.02 ms 6.02 ms -0.00 ms (-0.04%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.96 ms 4.96 ms 0.00 ms (0.04%) 1.12%
handshake_tickets_ring_1.3_ecdsap256_aes 5.60 ms 5.60 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.97 ms 4.97 ms 0.00 ms (0.02%) 1.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.21 ms -0.00 ms (-0.02%) 1.29%
handshake_session_id_ring_1.3_ecdsap384_aes 8.63 ms 8.63 ms 0.00 ms (0.01%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.09 ms 6.09 ms 0.00 ms (0.01%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.70 ms 8.70 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.60 ms 8.60 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.51 ms 0.00 ms (0.00%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.49 ms 4.49 ms -0.00 ms (-0.00%) 1.16%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (c5b9b10) to head (25e11b4).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2422   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files          94       94           
  Lines       22558    22567    +9     
=======================================
+ Hits        21658    21667    +9     
  Misses        900      900

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc
Copy link
Member
djc commented Apr 9, 2025

Do we want to get out a release for this?

cpu
cpu approved these changes Apr 9, 2025
View reviewed changes
@ConradIrwin
Copy link

Thanks for the quick fix!

@ctz ctz force-pushed the jbp-rej-bad-write-returns branch from 73c918e to 25e11b4 Compare April 10, 2025 09:00
@ctz
Copy link
Member Author
ctz commented Apr 10, 2025

Do we want to get out a release for this?

Yep! Have added a bump commit and release notes to this PR.

@ctz ctz changed the title Detect and error on faulty io::Write::write_vectored 0.23.26: Detect and error on faulty io::Write::write_vectored Apr 10, 2025
@ctz ctz added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 88dccec Apr 10, 2025
64 checks passed
@ctz ctz deleted the jbp-rej-bad-write-returns branch April 10, 2025 10:18
@MrSubidubi MrSubidubi mentioned this pull request Apr 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in write_tls
4 participants
@ctz @djc @ConradIrwin @cpu
0