10000 Improve representation of SNI, ALPN and protocol version extensions by ctz · Pull Request #2441 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve representation of SNI, ALPN and protocol version extensions #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 28, 2025
Merged

Improve representation of SNI, ALPN and protocol version extensions #2441

merged 6 commits into from
Apr 28, 2025

Conversation

ctz
Copy link
Member
@ctz ctz commented Apr 28, 2025

These are diversions that happened in #1475

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Apr 28, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3890031 3874767 ✅ -15264 (-0.39%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4232322 4216960 ✅ -15362 (-0.36%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4320142 4304664 ✅ -15478 (-0.36%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4583143 4568298 ✅ -14845 (-0.32%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11535163 11599891 64728 (0.56%) 0.79%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2011335 2003570 -7765 (-0.39%) 1.44%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4763294 4746540 -16754 (-0.35%) 0.37%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10460775 10493053 32278 (0.31%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11597488 11561810 -35678 (-0.31%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9959725 9974549 14824 (0.15%) 0.90%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5017072 5010484 -6588 (-0.13%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4303988 4299134 -4854 (-0.11%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4763762 4758860 -4902 (-0.10%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3872775 3868845 -3930 (-0.10%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78720963 78646642 -74321 (-0.09%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305068 3302663 -2405 (-0.07%) 0.26%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78745258 78689152 -56106 (-0.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56574760 56538733 -36027 (-0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9962676 9968042 5366 (0.05%) 1.04%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56607361 56579525 -27836 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55281192 55305844 24652 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78527438 78496762 -30676 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78464811 78434426 -30385 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30841933 30830135 -11798 (-0.04%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30848872 30837074 -11798 (-0.04%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31167565 31155650 -11915 (-0.04%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31238836 31226921 -11915 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30933223 30921425 -11798 (-0.04%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30940162 30928364 -11798 (-0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31163382 31151592 -11790 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30844537 30832888 -11649 (-0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31234653 31222863 -11790 (-0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31160108 31148357 -11751 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30935827 30924178 -11649 (-0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31231358 31219607 -11751 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55208710 55228817 20107 (0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3579891 3578638 -1253 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78510220 78536889 26669 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55276547 55294273 17726 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78449272 78424251 -25021 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78712604 78688367 -24237 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719484 1718956 -528 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3586663 3585647 -1016 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78462435 78482890 20455 (0.03%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246038 2245503 -535 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2000836 2001309 473 (0.02%) 1.44%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2910971 2910318 -653 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78477906 78494054 16148 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4747312 4748132 820 (0.02%) 0.56%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56561969 56552793 -9176 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333615 2333334 -281 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339264 2338983 -281 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78725395 78734823 9428 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31988070 31991783 3713 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32109720 32113433 3713 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31984943 31988623 3680 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32106593 32110273 3680 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31988095 31991584 3489 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32109745 32113234 3489 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56604639 56610714 6075 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55298220 55292458 -5762 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55221376 55215839 -5537 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56601351 56605786 4435 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78717278 78722074 4796 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2913361 2913186 -175 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55210599 55207718 -2881 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295615 1295554 -61 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296787 1296733 -54 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303807 3303689 -118 (-0.00%) 0.24%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58233875 58231946 -1929 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58233327 58231408 -1919 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58258148 58256233 -1915 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78676456 78673969 -2487 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451268 32452140 872 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553223 32554095 872 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448285 32449094 809 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550240 32551049 809 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451336 32452098 762 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553246 32554008 762 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92724068 92722146 -1922 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697971 92696050 -1921 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92698504 92696596 -1908 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996937 10996746 -191 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56553286 56554058 772 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229205 7229133 -72 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741752 34741445 -307 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743453 34743149 -304 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227244 7227181 -63 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11124947 11124883 -64 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11130708 11130644 -64 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46291029 46291017 -12 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189324 46189314 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452723 46452713 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46450213 46450204 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397785 46397779 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122624 58122631 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80634533 80634524 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284284 46284289 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80545429 80545421 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80540628 80540621 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92690553 92690561 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46460615 46460611 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533892 80533886 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294538 46294535 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637678 80637673 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80645571 80645567 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668084 92668088 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154236 58154238 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163191 58163189 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129838 58129839 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92658961 92658960 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58041282 58041282 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.09 ms 0.02 ms (1.56%) 5.75%
handshake_session_id_ring_1.2_rsa_aes 1.54 ms 1.51 ms -0.02 ms (-1.50%) 1.97%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.31 ms 1.33 ms 0.02 ms (1.49%) 4.83%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.31 ms 1.33 ms 0.02 ms (1.16%) 9.17%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.80 ms 1.82 ms 0.02 ms (1.05%) 3.30%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.69 ms 4.65 ms -0.04 ms (-0.80%) 6.52%
handshake_no_resume_ring_1.3_ecdsap256_aes 478.01 µs 474.34 µs -3.67 µs (-0.77%) 2.96%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.38 ms 5.34 ms -0.04 ms (-0.76%) 5.07%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.60 ms -0.01 ms (-0.72%) 1.64%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.39 ms 5.35 ms -0.04 ms (-0.71%) 5.15%
handshake_no_resume_ring_1.3_ecdsap256_chacha 475.30 µs 472.13 µs -3.16 µs (-0.66%) 3.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 666.82 µs 662.44 µs -4.38 µs (-0.66%) 3.75%
transfer_no_resume_ring_1.3_rsa_aes 5.87 ms 5.84 ms -0.04 ms (-0.65%) 4.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 666.05 µs 662.15 µs -3.90 µs (-0.59%) 3.84%
transfer_no_resume_ring_1.2_rsa_aes 5.80 ms 5.77 ms -0.03 ms (-0.59%) 5.30%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.63 ms 10.57 ms -0.06 ms (-0.58%) 1.87%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.02 ms -0.03 ms (-0.55%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.31 ms 11.25 ms -0.06 ms (-0.53%) 1.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.60 ms 10.54 ms -0.06 ms (-0.53%) 1.60%
handshake_tickets_ring_1.3_ecdsap256_aes 5.62 ms 5.59 ms -0.03 ms (-0.51%) 1.03%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.79 ms 10.73 ms -0.06 ms (-0.51%) 2.04%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.80 ms 10.75 ms -0.05 ms (-0.51%) 1.90%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.49 ms 11.44 ms -0.06 ms (-0.50%) 1.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.27 ms 11.21 ms -0.06 ms (-0.49%) 1.12%
handshake_session_id_ring_1.3_ecdsap256_aes 5.55 ms 5.52 ms -0.03 ms (-0.47%) 1.15%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.49 ms 8.46 ms -0.04 ms (-0.45%) 2.98%
handshake_no_resume_ring_1.2_rsa_aes 961.39 µs 957.11 µs -4.28 µs (-0.45%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.35 ms 1.35 ms -0.01 ms (-0.44%) 1.51%
handshake_tickets_ring_1.3_rsa_aes 6.11 ms 6.08 ms -0.03 ms (-0.43%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.35 ms 1.34 ms -0.01 ms (-0.42%) 1.59%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.46 ms 11.41 ms -0.05 ms (-0.41%) 2.13%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.17 ms 13.12 ms -0.05 ms (-0.36%) 2.23%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.85 ms 13.81 ms -0.05 ms (-0.35%) 2.06%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.52 ms 5.50 ms -0.02 ms (-0.34%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.46 ms 11.42 ms -0.04 ms (-0.33%) 2.47%
handshake_session_id_ring_1.3_ecdsap384_aes 8.65 ms 8.62 ms -0.03 ms (-0.33%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.72 ms 8.69 ms -0.03 ms (-0.32%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.44 ms 13.40 ms -0.04 ms (-0.32%) 2.20%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.58 ms 5.56 ms -0.02 ms (-0.31%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 5.99 ms -0.02 ms (-0.30%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.95 ms 12.91 ms -0.04 ms (-0.30%) 2.43%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.64 ms 0.00 ms (0.29%) 2.85%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.29 ms 11.26 ms -0.03 ms (-0.28%) 1.30%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.45 ms 11.41 ms -0.03 ms (-0.28%) 1.98%
handshake_no_resume_ring_1.3_rsa_chacha 964.57 µs 961.86 µs -2.71 µs (-0.28%) 1.40%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.33 ms 5.32 ms -0.01 ms (-0.26%) 4.65%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.26 ms 11.23 ms -0.03 ms (-0.25%) 1.75%
handshake_no_resume_ring_1.3_rsa_aes 964.27 µs 961.85 µs -2.42 µs (-0.25%) 1.31%
handshake_tickets_ring_1.3_rsa_chacha 6.06 ms 6.05 ms -0.01 ms (-0.22%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 16.02 ms -0.03 ms (-0.21%) 1.67%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.06 ms 5.05 ms -0.01 ms (-0.20%) 5.37%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.62 ms 8.60 ms -0.01 ms (-0.16%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.68 ms 8.67 ms -0.01 ms (-0.12%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.81 ms 13.80 ms -0.02 ms (-0.12%) 2.07%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.58 ms 3.58 ms 0.00 ms (0.11%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.58 ms 3.58 ms 0.00 ms (0.08%) 1.00%

Additional information

Historical results

Checkout details:

@ctz ctz requested a review from djc April 28, 2025 11:39
@codecov Codecov
Copy link
codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.36957% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.96%. Comparing base (486de06) to head (9f1ce03).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/msgs/handshake.rs 98.07% 2 Missing ⚠️
rustls/src/msgs/codec.rs 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2441      +/-   ##
==========================================
+ Coverage   95.94%   95.96%   +0.02%     
==========================================
  Files          94       94              
  Lines       22650    22634      -16     
==========================================
- Hits        21731    21721      -10     
+ Misses        919      913       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

djc
djc approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member
@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@ctz ctz force-pushed the jbp-extension-repr branch 2 times, most recently from 713e57c to 75edf1a Compare April 28, 2025 16:16
cpu
cpu approved these changes Apr 28, 2025
View reviewed changes
ctz added 4 commits April 28, 2025 18:49
@ctz
Optimize client's SupportedVersions ext repr
4fc12e4
@ctz
Simplify ALPN server extension representation
8d66987
@ctz
Eliminate ConvertProtocolNameList
c4ea91e 
Now a given decoded `ProtocolName` cannot be empty, there is no need
to check that manually.
@ctz
Simplify SNI client extension representation
9f1ce03 
Retire `Vec<ServerName>`, as in practice there can never be more
than one value: unknown name types (and everything that follows them)
cannot be decoded, and only one value of each name type is allowed.

Eliminates `ServerName` type which was confusingly overlapping
with `rustls-pki-types::ServerName`.
@ctz ctz force-pushed the jbp-extension-repr branch from 75edf1a to 9f1ce03 Compare April 28, 2025 17:49
@ctz ctz added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit ffac73a Apr 28, 2025
64 checks passed
@ctz ctz deleted the jbp-extension-repr branch April 28, 2025 18:44
@ctz ctz mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0