10000 internals: clean up item order around `ClientHelloPayload` by djc · Pull Request #2457 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

internals: clean up item order around ClientHelloPayload #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

internals: clean up item order around ClientHelloPayload #2457

merged 2 commits into from
May 12, 2025

Conversation

djc
Copy link
Member
@djc djc commented May 12, 2025

Extracted from #2443.

@djc djc requested review from cpu and ctz May 12, 2025 12:52
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented May 12, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10494430 10459010 -35420 (-0.34%) 1.09%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11564910 11589356 24446 (0.21%) 1.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9956779 9971107 14328 (0.14%) 0.79%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3300092 3304410 4318 (0.13%) 0.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78522280 78426770 -95510 (-0.12%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9972851 9963927 -8924 (-0.09%) 0.75%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55252056 55204356 -47700 (-0.09%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78761928 78716389 -45539 (-0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3585539 3587283 1744 (0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11523736 11528791 5055 (0.04%) 1.45%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56617378 56594537 -22841 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78463612 78435918 -27694 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78512897 78539523 26626 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4748803 4750196 1393 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78430000 78452800 22800 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4748638 4747272 -1366 (-0.03%) 0.24%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55287846 55302412 14566 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55226049 55212138 -13911 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2913081 2913795 714 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003243 2003703 460 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55197744 55209376 11632 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78501478 78517270 15792 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78708395 78694997 -13398 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78698486 78711387 12901 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55290271 55298172 7901 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3579739 3579251 -488 (-0.01%) 1.34%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56600380 56593665 -6715 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56594335 56600838 6503 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78692225 78683881 -8344 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78472367 78479024 6657 (0.01%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001558 2001725 167 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56563372 56559008 -4364 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55278907 55282179 3272 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2910625 2910511 -114 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78675226 78676936 1710 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56546181 56547293 1112 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296656 1296666 10 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305517 3305542 25 (0.00%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56559215 56559436 221 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78681184 78681396 212 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34742285 34742300 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227114 7227117 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46291025 46291014 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294544 46294533 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117371 58117362 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80645568 80645577 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226792 58226786 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148972 58148968 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397780 46397777 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452711 46452708 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80545420 80545415 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124572 58124575 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157303 58157300 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717532 92717528 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637666 80637668 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284286 46284287 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653697 92653699 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662821 92662823 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685297 92685295 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46450206 46450205 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461254 46461255 1 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035395 58035396 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251608 58251609 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80540623 80540624 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80634528 80634529 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691427 92691428 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92691975 92691976 1 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339715 2339715 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112394 32112394 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224515 31224515 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837796 30837796 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31990943 31990943 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550089 32550089 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451138 32451138 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128086 11128086 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306164 4306164 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160522 31160522 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569708 4569708 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30835051 30835051 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229084 7229084 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876267 3876267 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553135 32553135 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987783 31987783 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189314 46189314 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34744039 34744039 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533887 80533887 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841974 30841974 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867855 3867855 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295484 1295484 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448134 32448134 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231793 31231793 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929086 30929086 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451180 32451180 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153265 31153265 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112593 32112593 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012134 5012134 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109433 32109433 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553048 32553048 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246298 2246298 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227743 31227743 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000039 11000039 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719747 1719747 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218370 4218370 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58227328 58227328 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757720 4757720 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334066 2334066 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298144 4298144 0 (0.00%) 0.24%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31990744 31990744 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933264 30933264 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133847 11133847 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156472 31156472 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926341 30926341 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.76 ms 4.65 ms -0.11 ms (-2.27%) 5.98%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.01 ms -0.11 ms (-2.20%) 6.28%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.47 ms 5.35 ms -0.12 ms (-2.12%) 5.17%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.46 ms 5.35 ms -0.11 ms (-2.09%) 4.80%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.40 ms 5.29 ms -0.11 ms (-2.06%) 5.53%
transfer_no_resume_ring_1.2_rsa_aes 5.89 ms 5.77 ms -0.12 ms (-1.97%) 5.56%
transfer_no_resume_ring_1.3_rsa_aes 5.96 ms 5.85 ms -0.10 ms (-1.75%) 4.70%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 666.72 µs 657.96 µs -8.75 µs (-1.31%) 4.64%
handshake_no_resume_ring_1.3_ecdsap256_aes 480.64 µs 474.52 µs -6.12 µs (-1.27%) 3.64%
handshake_no_resume_ring_1.3_ecdsap256_chacha 477.89 µs 471.85 µs -6.03 µs (-1.26%) 3.86%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.56 ms 8.46 ms -0.10 ms (-1.17%) 3.04%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 665.41 µs 658.07 µs -7.34 µs (-1.10%) 4.18%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.02 ms 12.91 ms -0.12 ms (-0.89%) 2.17%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.23 ms 13.12 ms -0.11 ms (-0.86%) 1.88%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.92 ms 13.80 ms -0.12 ms (-0.85%) 1.64%
transfer_no_resume_ring_1.3_rsa_chacha 13.51 ms 13.41 ms -0.11 ms (-0.79%) 2.23%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.87 ms 13.76 ms -0.11 ms (-0.78%) 2.12%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.13 ms 16.01 ms -0.12 ms (-0.74%) 1.82%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.29 ms 1.29 ms -0.01 ms (-0.65%) 4.47%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.30 ms 1.29 ms -0.01 ms (-0.62%) 4.62%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.61 ms 1.61 ms -0.01 ms (-0.57%) 2.24%
handshake_no_resume_ring_1.3_rsa_aes 968.78 µs 963.34 µs -5.44 µs (-0.56%) 1.73%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.78 ms -0.01 ms (-0.54%) 2.84%
handshake_no_resume_ring_1.2_rsa_aes 965.83 µs 960.67 µs -5.15 µs (-0.53%) 1.34%
handshake_no_resume_ring_1.3_rsa_chacha 968.85 µs 963.74 µs -5.12 µs (-0.53%) 1.52%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.59 ms -0.01 ms (-0.51%) 1.35%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.52 ms 10.47 ms -0.05 ms (-0.49%) 1.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.68 ms 10.62 ms -0.05 ms (-0.47%) 1.60%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.71 ms 10.66 ms -0.05 ms (-0.46%) 1.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.48 ms 10.43 ms -0.05 ms (-0.45%) 1.76%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.35 ms 1.34 ms -0.01 ms (-0.45%) 1.46%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.00 ms (-0.45%) 4.41%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.17 ms 11.13 ms -0.05 ms (-0.43%) 1.18%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.39 ms 11.35 ms -0.05 ms (-0.42%) 1.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.20 ms 11.16 ms -0.05 ms (-0.41%) 1.27%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.35 ms 11.30 ms -0.05 ms (-0.41%) 1.39%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.35 ms 11.31 ms -0.05 ms (-0.41%) 1.44%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.15 ms 11.11 ms -0.05 ms (-0.40%) 1.63%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.51 ms -0.01 ms (-0.39%) 2.17%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.13 ms 11.09 ms -0.04 ms (-0.38%) 1.27%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.32 ms 11.27 ms -0.04 ms (-0.38%) 1.28%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.06 ms -0.02 ms (-0.37%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.10 ms -0.02 ms (-0.37%) 1.20%
handshake_tickets_ring_1.3_ecdsap256_aes 5.63 ms 5.61 ms -0.02 ms (-0.36%) 1.18%
handshake_session_id_ring_1.3_rsa_chacha 6.02 ms 6.00 ms -0.02 ms (-0.34%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.34 ms 1.34 ms -0.00 ms (-0.30%) 1.71%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.57 ms -0.02 ms (-0.29%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.06 ms 6.04 ms -0.02 ms (-0.27%) 1.31%
handshake_tickets_ring_1.3_ecdsap384_aes 8.72 ms 8.70 ms -0.02 ms (-0.26%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.62 ms 8.60 ms -0.02 ms (-0.24%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.53 ms 5.51 ms -0.01 ms (-0.23%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.58 ms 3.57 ms -0.01 ms (-0.21%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.69 ms 8.67 ms -0.02 ms (-0.21%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.56 ms 5.55 ms -0.01 ms (-0.21%) 1.45%
handshake_session_id_ring_1.3_ecdsap384_aes 8.65 ms 8.64 ms -0.02 ms (-0.18%) 1.01%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.58 ms 3.58 ms -0.01 ms (-0.14%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.26%. Comparing base (b30fc9e) to head (04bc04d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/msgs/handshake.rs 89.47% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2457   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          95       95           
  Lines       21256    21256           
=======================================
  Hits        20250    20250           
  Misses       1006     1006

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc added this pull request to the merge queue May 12, 2025
Merged via the queue into main with commit 7f8df89 May 12, 2025
33 of 34 checks passed
@djc djc deleted the hs-order branch May 12, 2025 13:14
@ctz ctz mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz
0