8000 Disable `clippy::clone_on_ref_ptr` lint by ctz · Pull Request #2474 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Disable clippy::clone_on_ref_ptr lint #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Disable clippy::clone_on_ref_ptr lint #2474

merged 1 commit into from
May 29, 2025

Conversation

ctz
Copy link
Member
@ctz ctz commented May 29, 2025

This is not contributing significantly to code quality.

In cases where an Arc<T> is cloned into an upcast of Arc<dyn Trait> (where T: Trait) it actively makes the code less readable by forcing the repetition of Arc::<T>::clone.

Upstream issue: rust-lang/rust-clippy#2048

I looked into moving our lint configuration in the workspace's Cargo.toml, but actually it would mean reading three files (both lib.rs, and two Cargo.tomls) to determine which lints applied. Unfortunately you cannot layer lints just in Cargo.toml -- upstream issue for that is rust-lang/cargo#13157

@ctz
Disable clippy::clone_on_ref_ptr lint
8123a86 
This is not contributing significantly to code quality.

In cases where an `Arc<T>` is cloned into an upcast of
`Arc<dyn Trait>` (where `T: Trait`) it actively makes the code
less readable by forcing the repetition of `Arc::<T>::clone`.
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented May 29, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001250 2007771 ⚠️ 6521 (0.33%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3593474 3579401 -14073 (-0.39%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11594072 11548881 -45191 (-0.39%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4747723 4758683 10960 (0.23%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9944448 9957141 12693 (0.13%) 0.94%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10453474 10465808 12334 (0.12%) 1.10%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305587 3303392 -2195 (-0.07%) 0.26%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78462888 78506312 43424 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78662509 78705839 43330 (0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3585562 3587454 1892 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78685299 78717135 31836 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55216986 55238533 21547 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56551351 56573276 21925 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78444380 78416541 -27839 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78483892 78511332 27440 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78520380 78495320 -25060 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56554090 56570221 16131 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55275747 55290909 15162 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55216202 55202371 -13831 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55305881 55293364 -12517 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003643 2003225 -418 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78646964 78660745 13781 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78421015 78433345 12330 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56545094 56551862 6768 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55207781 55213926 6145 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78735776 78727418 -8358 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78740394 78746814 6420 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4749099 4749475 376 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9947327 9948110 783 (0.01%) 0.60%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56615491 56611174 -4317 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2904684 2904484 -200 (-0.01%) 0.83%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78492612 78487617 -4995 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304346 3304141 -205 (-0.01%) 0.22%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56609412 56612707 3295 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55289005 55286578 -2427 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11591876 11591620 -256 (-0.00%) 1.32%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296439 1296416 -23 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56593439 56593635 196 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2907400 2907390 -10 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719927 1719923 -4 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78688691 78688873 182 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295244 1295242 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691429 92691414 -15 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148972 58148981 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538692 80538681 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284268 46284273 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653699 92653689 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46448260 46448255 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459281 46459276 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643599 80643606 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717529 92717521 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226784 58226779 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533871 80533865 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58229017 58229013 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294220 46294223 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92693667 92693661 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117364 58117367 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637662 80637666 4 (0.00%) 0.20%
transfer 8000 _no_resume_ring_1.3_ecdsap256_aes_server 46289084 46289086 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685298 92685294 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397766 46397768 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632583 80632580 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124575 58124577 2 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189286 46189285 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662829 92662831 2 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035393 58035394 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251613 58251612 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543188 80543189 1 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127905 11127905 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31988230 31988230 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837854 30837854 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926215 30926215 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227809 31227809 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31991415 31991415 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157300 58157300 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306090 4306090 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553370 32553370 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757724 4757724 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231797 31231797 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153199 31153199 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553457 32553457 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999871 10999871 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933198 30933198 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451502 32451502 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133666 11133666 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156538 31156538 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867861 3867861 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738002 34738002 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451460 32451460 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222912 7222912 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31991282 31991282 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30834925 30834925 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334246 2334246 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339895 2339895 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569708 4569708 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160526 31160526 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452707 46452707 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246478 2246478 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298386 4298386 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012380 5012380 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109880 32109880 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112932 32112932 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32113065 32113065 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841908 30841908 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876271 3876271 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550648 32550648 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736301 34736301 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224449 31224449 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448693 32448693 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218366 4218366 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7220960 7220960 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929144 30929144 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.69 ms 4.75 ms 0.07 ms (1.43%) 5.35%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.36 ms 5.43 ms 0.07 ms (1.35%) 4.10%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.38 ms 5.44 ms 0.06 ms (1.21%) 4.28%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.08 ms 5.14 ms 0.06 ms (1.18%) 4.61%
transfer_no_resume_ring_1.3_rsa_aes 5.87 ms 5.94 ms 0.07 ms (1.16%) 4.15%
transfer_no_resume_ring_1.2_rsa_aes 5.82 ms 5.89 ms 0.06 ms (1.08%) 4.60%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.39 ms 5.45 ms 0.06 ms (1.07%) 4.13%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 651.14 µs 656.79 µs 5.66 µs (0.87%) 3.07%
handshake_no_resume_ring_1.3_ecdsap256_chacha 461.67 µs 465.33 µs 3.67 µs (0.79%) 3.73%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.49 ms 8.55 ms 0.06 ms (0.74%) 2.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 652.75 µs 657.17 µs 4.42 µs (0.68%) 3.98%
handshake_no_resume_ring_1.3_ecdsap256_aes 464.00 µs 466.96 µs 2.96 µs (0.64%) 3.99%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.15 ms 13.22 ms 0.07 ms (0.53%) 1.73%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.50 ms 0.07 ms (0.52%) 1.83%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.82 ms 13.89 ms 0.07 ms (0.48%) 1.62%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.95 ms 13.01 ms 0.06 ms (0.47%) 1.79%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.84 ms 13.91 ms 0.06 ms (0.46%) 1.76%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.09 ms 0.00 ms (0.46%) 1.77%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 16.12 ms 0.07 ms (0.42%) 1.25%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.32 ms 1.32 ms 0.01 ms (0.39%) 1.95%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.33 ms 1.33 ms 0.00 ms (0.37%) 1.32%
handshake_no_resume_ring_1.3_rsa_chacha 954.19 µs 957.57 µs 3.38 µs (0.35%) 1.66%
handshake_no_resume_ring_1.3_rsa_aes 954.57 µs 957.50 µs 2.93 µs (0.31%) 1.48%
handshake_no_resume_ring_1.2_rsa_aes 951.82 µs 954.66 µs 2.85 µs (0.30%) 1.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.34 ms 1.34 ms 0.00 ms (0.29%) 1.56%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.59 ms 10.62 ms 0.03 ms (0.29%) 1.23%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.57 ms 0.01 ms (0.28%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.47 ms 11.50 ms 0.03 ms (0.27%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.78 ms 10.81 ms 0.03 ms (0.26%) 1.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.27 ms 11.30 ms 0.03 ms (0.25%) 1.19%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.29 ms 11.31 ms 0.03 ms (0.23%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.25 ms 11.27 ms 0.02 ms (0.22%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.57 ms 0.01 ms (0.21%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.23 ms 11.25 ms 0.02 ms (0.21%) 1.15%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.47 ms 11.49 ms 0.02 ms (0.21%) 1.03%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms 0.00 ms (0.19%) 1.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.56 ms 10.58 ms 0.02 ms (0.19%) 1.24%
handshake_session_id_ring_1.3_rsa_aes 6.02 ms 6.01 ms -0.01 ms (-0.18%) 1.13%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.65 ms 0.00 ms (0.17%) 2.79%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.75 ms 10.77 ms 0.02 ms (0.16%) 1.47%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.43 ms 11.44 ms 0.02 ms (0.14%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.99 ms 5.98 ms -0.01 ms (-0.12%) 1.09%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.44 ms 11.45 ms 0.01 ms (0.12%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.82 ms 1.82 ms 0.00 ms (0.12%) 2.90%
handshake_tickets_ring_1.3_rsa_aes 6.07 ms 6.07 ms -0.01 ms (-0.09%) 1.06%
handshake_tickets_ring_1.3_rsa_chacha 6.04 ms 6.04 ms -0.00 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.58 ms 5.58 ms 0.00 ms (0.07%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms 0.00 ms (0.06%) 1.70%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.33 ms 1.33 ms 0.00 ms (0.06%) 1.13%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.65 ms 8.65 ms -0.00 ms (-0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.49 ms 5.49 ms 0.00 ms (0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.55 ms 5.55 ms -0.00 ms (-0.02%) 1.27%
handshake_tickets_ring_1.3_ecdsap384_aes 8.68 ms 8.68 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.62 ms 8.62 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.59 ms 8.59 ms 0.00 ms (0.00%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.52 ms 5.52 ms 0.00 ms (0.00%) 1.29%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented May 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (70d00af) to head (8123a86).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2474   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          97       97           
  Lines       21506    21506           
=======================================
  Hits        20502    20502           
  Misses       1004     1004

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

djc
djc approved these changes May 29, 2025
View reviewed changes
Copy link
Member
@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also get rid of existing Arc::clone calls?

cpu
cpu approved these changes May 29, 2025
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ctz
Copy link
Member Author
ctz commented May 29, 2025

Should we also get rid of existing Arc::clone calls?

Will do this in a later PR.

@ctz ctz added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit 5f7c467 May 29, 2025
34 checks passed
@ctz ctz deleted the jbp-clippy-clone-on-ref branch May 29, 2025 13:33
@cpu cpu mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0