8000 Fix bug in crypto::aws_lc_rs::pq::hybrid::Layout by cjpatton · Pull Request #2470 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Fix bug in crypto::aws_lc_rs::pq::hybrid::Layout #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

Fix bug in crypto::aws_lc_rs::pq::hybrid::Layout #2470

merged 1 commit into from
May 26, 2025
+9 −2

Conversation

cjpatton
Copy link
Contributor

The share splitter function swaps the order of the shares whenever post_quantum_first is true.

@cjpatton
Fix bug in crypto::aws_lc_rs::pq::hybrid::Layout
80a8f1d 
The share splitter function swaps the order of the shares whenever
`post_quantum_first` is `true`.
@codecov Codecov
Copy link
codecov bot commented May 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.27%. Comparing base (79677ce) to head (80a8f1d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/crypto/aws_lc_rs/pq/hybrid.rs 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2470      +/-   ##
==========================================
- Coverage   95.27%   95.27%   -0.01%     
==========================================
  Files          97       97              
  Lines       21357    21359       +2     
==========================================
+ Hits        20348    20349       +1     
- Misses       1009     1010       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc requested a review from ctz May 26, 2025 07:44
djc
djc approved these changes May 26, 2025
View reviewed changes
Copy link
Member
@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, nice catch!

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented May 26, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9945277 9976607 31330 (0.32%) 0.60%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11576611 11550957 -25654 (-0.22%) 1.52%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11592924 11577076 -15848 (-0.14%) 1.27%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10486256 10473599 -12657 (-0.12%) 1.13%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78419831 78484481 64650 (0.08%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9961507 9953464 -8043 (-0.08%) 0.79%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55200920 55236250 35330 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78695670 78650952 -44718 (-0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78434425 78473141 38716 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78554190 78590965 36775 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55307906 55330835 22929 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55211492 55233804 22312 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78500918 78469213 -31705 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56564774 56545369 -19405 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78652930 78677705 24775 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78716936 78695002 -21934 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56545022 56560396 15374 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4749939 4748696 -1243 (-0.03%) 0.21%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55293230 55280444 -12786 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78546274 78529162 -17112 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3580113 3579522 -591 (-0.02%) 1.22%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56556776 56565336 8560 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78725668 78714152 -11516 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56604519 56596727 -7792 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2914292 2914668 376 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4748151 4748700 549 (0.01%) 0.26%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78696497 78704698 8201 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55312729 55307177 -5552 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001538 2001338 -200 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2904369 2904574 205 (0.01%) 0.79%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876541 3876271 -270 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218636 4218366 -270 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306360 4306090 -270 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569978 4569708 -270 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56595750 56598902 3152 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304449 3304272 -177 (-0.01%) 0.23%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1720007 1719927 -80 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56607225 56604797 -2428 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78441297 78438159 -3138 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003710 2003782 72 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55204244 55205812 1568 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3586609 3586674 65 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296418 1296439 21 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305522 3305549 27 (0.00%) 0.27%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295234 1295244 10 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987990 31988230 240 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31991042 31991282 240 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31991175 31991415 240 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109640 32109880 240 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112692 32112932 240 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112825 32113065 240 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448453 32448693 240 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451220 32451460 240 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451262 32451502 240 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550408 32550648 240 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553130 32553370 240 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553217 32553457 240 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78718747 78719229 482 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246487 2246478 -9 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7220952 7220963 11 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222904 7222912 8 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736291 34736326 35 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127897 11127905 8 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133658 11133666 8 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34737992 34738010 18 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189296 46189285 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294230 46294219 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284263 46284273 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289092 46289082 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226791 58226781 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117360 58117368 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632585 80632574 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1 8000 .3_ecdsap384_aes_server 46448263 46448257 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58229021 58229014 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459279 46459284 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533862 80533870 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92693660 92693667 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691429 92691435 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452703 46452706 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643600 80643605 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717522 92717526 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538690 80538687 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124572 58124574 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543188 80543190 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662829 92662831 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397765 46397764 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035395 58035394 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148972 58148971 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157301 58157300 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251610 58251611 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637656 80637655 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653697 92653698 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685296 92685297 1 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160526 31160526 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929144 30929144 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334246 2334246 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156538 31156538 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999871 10999871 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30834925 30834925 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841908 30841908 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926215 30926215 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933198 30933198 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757724 4757724 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231797 31231797 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153199 31153199 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298386 4298386 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339895 2339895 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837854 30837854 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867861 3867861 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227809 31227809 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224449 31224449 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012380 5012380 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.83 ms 1.81 ms -0.02 ms (-1.04%) 3.40%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.60 ms 5.55 ms -0.05 ms (-0.81%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.66 ms 1.64 ms -0.01 ms (-0.80%) 3.33%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.53 ms 5.49 ms -0.04 ms (-0.79%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.56 ms 5.52 ms -0.04 ms (-0.79%) 1.45%
handshake_tickets_ring_1.3_ecdsap256_aes 5.63 ms 5.58 ms -0.04 ms (-0.79%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.04 ms -0.04 ms (-0.66%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.08 ms -0.04 ms (-0.63%) 1.17%
handshake_session_id_ring_1.3_rsa_chacha 6.02 ms 5.98 ms -0.04 ms (-0.63%) 1.09%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.59 ms -0.01 ms (-0.58%) 1.55%
handshake_session_id_ring_1.3_rsa_aes 6.06 ms 6.02 ms -0.04 ms (-0.58%) 1.39%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms -0.01 ms (-0.54%) 2.17%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.42 ms 5.40 ms -0.03 ms (-0.51%) 4.03%
handshake_no_resume_ring_1.3_ecdsap256_aes 466.77 µs 464.49 µs -2.27 µs (-0.49%) 3.29%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.41 ms 5.38 ms -0.03 ms (-0.48%) 4.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.12 ms 5.10 ms -0.02 ms (-0.41%) 4.82%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.63 ms 8.60 ms -0.03 ms (-0.37%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.66 ms 8.63 ms -0.03 ms (-0.37%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.78 ms 10.74 ms -0.04 ms (-0.36%) 1.56%
handshake_tickets_ring_1.3_ecdsap384_aes 8.72 ms 8.69 ms -0.03 ms (-0.36%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.46 ms 11.42 ms -0.04 ms (-0.36%) 1.13%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.69 ms 8.65 ms -0.03 ms (-0.36%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.26 ms 11.22 ms -0.04 ms (-0.36%) 1.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 654.64 µs 652.35 µs -2.29 µs (-0.35%) 4.01%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.73 ms 4.71 ms -0.02 ms (-0.35%) 5.06%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.47 ms 11.43 ms -0.04 ms (-0.32%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.59 ms 10.56 ms -0.03 ms (-0.32%) 1.24%
transfer_no_resume_ring_1.2_rsa_aes 5.86 ms 5.84 ms -0.02 ms (-0.31%) 4.38%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.28 ms 11.24 ms -0.03 ms (-0.31%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 464.00 µs 462.65 µs -1.35 µs (-0.29%) 3.33%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.42 ms 5.40 ms -0.02 ms (-0.28%) 4.11%
transfer_no_resume_ring_1.3_rsa_aes 5.90 ms 5.89 ms -0.02 ms (-0.27%) 4.15%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.81 ms 10.78 ms -0.03 ms (-0.27%) 1.12%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.49 ms 11.46 ms -0.03 ms (-0.27%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.62 ms 10.60 ms -0.03 ms (-0.26%) 1.23%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.31 ms 11.28 ms -0.03 ms (-0.25%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.50 ms 11.47 ms -0.03 ms (-0.23%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.30 ms 11.28 ms -0.02 ms (-0.21%) 1.11%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.32 ms 1.32 ms -0.00 ms (-0.17%) 2.39%
transfer_no_resume_ring_1.3_rsa_chacha 13.47 ms 13.45 ms -0.02 ms (-0.17%) 1.71%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.08 ms -0.00 ms (-0.15%) 1.89%
handshake_no_resume_ring_1.3_rsa_chacha 955.44 µs 954.14 µs -1.30 µs (-0.14%) 1.38%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.86 ms 13.84 ms -0.02 ms (-0.13%) 1.64%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.57 ms 3.57 ms 0.00 ms (0.13%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.57 ms 0.00 ms (0.13%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 955.99 µs 954.77 µs -1.22 µs (-0.13%) 1.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.87 ms 13.85 ms -0.02 ms (-0.11%) 1.76%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.52 ms 8.51 ms -0.01 ms (-0.11%) 2.38%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.19 ms 13.17 ms -0.01 ms (-0.11%) 1.73%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.98 ms 12.97 ms -0.01 ms (-0.11%) 1.72%
handshake_no_resume_ring_1.2_rsa_aes 952.12 µs 951.25 µs -0.87 µs (-0.09%) 1.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.33 ms 1.33 ms -0.00 ms (-0.08%) 1.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 654.83 µs 654.32 µs -0.52 µs (-0.08%) 4.17%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.08 ms 16.07 ms -0.01 ms (-0.04%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.34 ms 1.34 ms 0.00 ms (0.01%) 1.51%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.33 ms 1.33 ms -0.00 ms (-0.00%) 1.84%

Additional information

Historical results

Checkout details:

ctz
ctz approved these changes May 26, 2025
View reviewed changes
Copy link
Member
@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In retrospect it probably wasn't a great idea to make this more flexible than we needed and could test.

@djc djc added this pull request to the merge queue May 26, 2025
@djc
Copy link
Member
djc commented May 26, 2025

Why can't we test it?

Merged via the queue into rustls:main with commit 9b8f254 May 26, 2025
33 of 34 checks passed
@ctz ctz mentioned this pull request May 26, 2025
Merged
@cjpatton
Copy link
Contributor Author

In retrospect it probably wasn't a great idea to make this more flexible than we needed and could test.

FWIW I found the flexibility useful, hence how I found the bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjpatton @djc @ctz
0