8000 Only include renegotiation SCSV for TLS1.2 attempts by ctz · Pull Request #2486 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Only include renegotiation SCSV for TLS1.2 attempts #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

Only include renegotiation SCSV for TLS1.2 attempts #2486

merged 1 commit into from
Jun 11, 2025

Conversation

ctz
Copy link
Member
@ctz ctz commented Jun 11, 2025

On reviewing #2485, I noticed we only want to include this for hellos where TLS1.2 is offered.

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Jun 11, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64538263 64809570 ⚠️ 271307 (0.42%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64627276 64875595 ⚠️ 248319 (0.38%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64365208 64563087 ⚠️ 197879 (0.31%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49600816 49724583 ⚠️ 123767 (0.25%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49536094 49657642 ⚠️ 121548 (0.25%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64510335 64353156 ✅ -157179 (-0.24%) 0.22%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 48216625 48314026 ⚠️ 97401 (0.20%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3122213 3109559 -12654 (-0.41%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9519260 9490458 -28802 (-0.30%) 1.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2679778 2672945 -6833 (-0.25%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9525333 9506201 -19132 (-0.20%) 0.59%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295332 1297589 2257 (0.17%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296514 1298759 2245 (0.17%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48350146 48269954 -80192 (-0.17%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64586266 64691759 105493 (0.16%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11356360 11341457 -14903 (-0.13%) 1.12%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10464967 10452842 -12125 (-0.12%) 1.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49561816 49613129 51313 (0.10%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4281509 4278157 -3352 (-0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64414702 64462545 47843 (0.07%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305535 3307925 2390 (0.07%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11332166 11324525 -7641 (-0.07%) 1.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64444113 64401681 -42432 (-0.07%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304441 3306590 2149 (0.07%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1770592 1769599 -993 (-0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64585401 64620995 35594 (0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48267811 48245201 -22610 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48299230 48321769 22539 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49588081 49604075 15994 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4278841 4279924 1083 (0.03%) 1.01%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1768211 1768530 319 (0.02%) 1.25%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49588922 49583183 -5739 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 48271545 48266743 -4802 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64457495 64451146 -6349 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64657647 64652160 -5487 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2676365 2676575 210 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987420 31985020 -2400 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31990472 31988072 -2400 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31990575 31988175 -2400 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109070 32106670 -2400 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112122 32109722 -2400 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112225 32109825 -2400 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32451183 32448813 -2370 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32453950 32451580 -2370 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32453992 32451622 -2370 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32553138 32550768 -2370 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32555860 32553490 -2370 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32555947 32553577 -2370 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49658369 49654813 -3556 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30836725 30834745 -1980 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30839674 30837694 -1980 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30843728 30841748 -1980 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30928015 30926035 -1980 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30930964 30928984 -1980 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30935018 30933038 -1980 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64723200 64719227 -3973 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31154999 31153169 -1830 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31158354 31156524 -1830 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31162342 31160512 -1830 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31226249 31224419 -1830 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31229625 31227795 -1830 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31233613 31231783 -1830 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64424351 64422275 -2076 (-0.00%) 0.25%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48295422 48294117 -1305 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3878971 3879061 90 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4221036 4221126 90 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4307620 4307710 90 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4571208 4571298 90 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7223018 7222921 -97 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334263 2334232 -31 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339912 2339881 -31 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3116548 3116587 39 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7221051 7220969 -82 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58243126 58243768 642 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1720137 1720155 18 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11124709 11124634 -75 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11130470 11130395 -75 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738061 34737978 -83 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736327 34736277 -50 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246518 2246517 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284263 46284273 10 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189296 46189289 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46457824 46457818 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543180 80543190 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80633215 80633225 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92662691 92662680 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80644246 80644237 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92701057 92701067 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464400 46464405 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80638302 80638296 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58240894 58240898 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294222 46294219 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92671817 92671823 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46453379 46453382 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538688 80538692 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289083 46289085 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163735 58163733 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58265722 58265720 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46401607 46401606 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58037986 58037987 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58126355 58126356 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58133566 58133565 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58157965 58157964 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92694290 92694291 1 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5011840 5011840 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533872 80533872 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996575 10996575 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92703292 92703292 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299946 4299946 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4758624 4758624 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92727152 92727152 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3870591 3870591 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_ring_1.3_ecdsap256_chacha 5.53 ms 5.50 ms -0.03 ms (-0.45%) 1.36%
handshake_session_id_ring_1.3_ecdsap256_aes 5.56 ms 5.54 ms -0.02 ms (-0.43%) 1.41%
handshake_session_id_ring_1.3_rsa_aes 6.06 ms 6.04 ms -0.02 ms (-0.37%) 1.03%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.57 ms -0.02 ms (-0.36%) 1.59%
handshake_session_id_ring_1.3_rsa_chacha 6.02 ms 6.00 ms -0.02 ms (-0.36%) 1.75%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 589.20 µs 587.25 µs -1.95 µs (-0.33%) 4.26%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.67 ms 8.64 ms -0.03 ms (-0.33%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.10 ms -0.02 ms (-0.33%) 1.17%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.06 ms -0.02 ms (-0.32%) 1.22%
handshake_tickets_ring_1.3_ecdsap256_aes 5.63 ms 5.61 ms -0.02 ms (-0.29%) 1.45%
handshake_session_id_ring_1.3_ecdsap384_aes 8.70 ms 8.68 ms -0.02 ms (-0.27%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.61 ms 0.00 ms (0.26%) 3.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.41 ms 9.38 ms -0.02 ms (-0.25%) 2.82%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.28 ms 5.30 ms 0.01 ms (0.25%) 6.41%
handshake_tickets_ring_1.3_ecdsap384_aes 8.76 ms 8.74 ms -0.02 ms (-0.23%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.76 ms 8.74 ms -0.02 ms (-0.22%) 3.30%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.23 ms 1.22 ms -0.00 ms (-0.22%) 2.41%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.42 ms 5.41 ms -0.01 ms (-0.21%) 6.70%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.73 ms 8.71 ms -0.02 ms (-0.21%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.20 ms 9.18 ms -0.02 ms (-0.20%) 2.85%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.73 ms 8.71 ms -0.02 ms (-0.20%) 3.12%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.40 ms 9.38 ms -0.02 ms (-0.19%) 3.01%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.38 ms 9.36 ms -0.02 ms (-0.19%) 2.50%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.65 ms 4.66 ms 0.01 ms (0.16%) 7.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.44 ms 9.42 ms -0.02 ms (-0.16%) 2.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.27 ms 1.27 ms -0.00 ms (-0.15%) 2.03%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.59 ms -0.00 ms (-0.15%) 1.17%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.20 ms 9.19 ms -0.01 ms (-0.13%) 2.94%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.05 ms 1.05 ms 0.00 ms (0.13%) 1.88%
handshake_no_resume_ring_1.3_ecdsap256_aes 467.67 µs 468.25 µs 0.58 µs (0.13%) 3.97%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.22 ms 9.21 ms -0.01 ms (-0.12%) 3.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.56 ms 8.55 ms -0.01 ms (-0.11%) 3.74%
transfer_no_resume_ring_1.2_rsa_aes 5.86 ms 5.85 ms -0.01 ms (-0.10%) 5.66%
handshake_no_resume_ring_1.3_rsa_aes 955.04 µs 954.18 µs -0.85 µs (-0.09%) 1.63%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.22 ms 1.22 ms -0.00 ms (-0.09%) 2.94%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.24 ms 9.23 ms -0.01 ms (-0.08%) 3.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.26 ms 1.26 ms -0.00 ms (-0.07%) 1.76%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.56 ms 8.56 ms -0.01 ms (-0.07%) 4.18%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.52 ms 8.52 ms -0.01 ms (-0.07%) 3.37%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.77 ms 1.77 ms -0.00 ms (-0.07%) 3.09%
handshake_no_resume_ring_1.3_rsa_chacha 954.90 µs 955.50 µs 0.60 µs (0.06%) 1.78%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms 0.00 ms (0.06%) 1.09%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.76 ms 13.75 ms -0.01 ms (-0.05%) 2.41%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.81 ms 13.80 ms -0.01 ms (-0.05%) 2.66%
transfer_no_resume_ring_1.3_rsa_aes 5.91 ms 5.91 ms -0.00 ms (-0.05%) 5.73%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.61 ms 0.00 ms (0.05%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.13 ms 16.12 ms -0.01 ms (-0.04%) 2.22%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.99 ms 12.98 ms -0.00 ms (-0.02%) 2.55%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.02%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.34 ms 5.34 ms 0.00 ms (0.02%) 6.46%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.12 ms 13.12 ms 0.00 ms (0.01%) 2.68%
handshake_no_resume_ring_1.2_rsa_aes 951.33 µs 951.24 µs -0.10 µs (-0.01%) 1.58%
transfer_no_resume_ring_1.3_rsa_chacha 13.47 ms 13.47 ms -0.00 ms (-0.01%) 2.54%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.08 ms 5.08 ms -0.00 ms (-0.01%) 6.62%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 588.43 µs 588.42 µs -0.01 µs (-0.00%) 3.91%
handshake_no_resume_ring_1.3_ecdsap256_chacha 465.39 µs 465.38 µs -0.01 µs (-0.00%) 3.64%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (568b2c6) to head (bf50a5a).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2486   +/-   ##
=======================================
  Coverage   95.39%   95.40%           
=======================================
  Files          97       97           
  Lines       21859    21874   +15     
=======================================
+ Hits        20853    20868   +15     
  Misses       1006     1006

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cpu
cpu approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to have a test to catch unintended regression if it's not a big pain.

@ctz ctz force-pushed the jbp-reneg-scsv-tls13 branch from f493a17 to bf50a5a Compare June 11, 2025 15:05
cpu
cpu approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ctz ctz added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 96d6656 Jun 11, 2025
34 checks passed
@ctz ctz deleted the jbp-reneg-scsv-tls13 branch June 11, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0