8000 Added task for GPG key imports. Fixes rvm/rvm1-ansible#14. by hasanen · Pull Request #15 · rvm/rvm1-ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added task for GPG key imports. Fixes rvm/rvm1-ansible#14. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We 8000 ’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2014
Merged

Added task for GPG key imports. Fixes rvm/rvm1-ansible#14. #15

merged 4 commits into from
Oct 29, 2014

Conversation

hasanen
Copy link
Contributor
@hasanen hasanen commented Oct 29, 2014

This fixed issue in our environment.

@mpapis
Copy link
Member
mpapis commented Oct 29, 2014

👍

@hasanen
Copy link
Contributor Author
hasanen commented Oct 29, 2014

I'll check

@hasanen
Copy link
Contributor Author
hasanen commented Oct 29, 2014

Fixed conflicts, had too old version of repo when added task.

mpapis
mpapis reviewed Oct 29, 2014
View reviewed changes
tasks/rvm.yml
command: 'gpg --keyserver hkp://keys.gnupg.net --recv-keys {{ rvm1_gpg_keys }}'
changed_when: False
when: not rvm_binary.stat.exists
changed_when: False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double changed_when: False?

@nickjj
Copy link
Contributor
nickjj commented Oct 29, 2014

Nice, one last thing and we're good to go for a merge.

Can you move the variable from vars/ into defaults/ and set the task to only run if a value is present?

Here's the docs for the readme to drop into the defaults section:

# GPG key verification, use an empty string if you want to skip this
# Note: Unless you know what you're doing, just keep it as is
#           Identity proof: https://keybase.io/mpapis
#           PGP message: https://rvm.io/mpapis.asc
rvm1_gpg_keys: 'D39DC0E3'

The changes to the task:

when: not rvm_binary.stat.exists and rvm1_gpg_keys

nickjj added a commit that referenced this pull request Oct 29, 2014
@nickjj
Merge pull request #15 from hasanen/import-gpg-keys
8ccecc0 
Added task for GPG key imports. Fixes #14.
@nickjj nickjj merged commit 8ccecc0 into rvm:master Oct 29, 2014
@nickjj
Copy link
Contributor
nickjj commented Oct 29, 2014

Thanks for the contribution, it has been released as v.1.3.1 and is available on the Galaxy.

https://galaxy.ansible.com/list#/roles/1087

@hasanen
Copy link
Contributor Author
hasanen commented Oct 29, 2014

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasanen @mpapis @nickjj
0