10000 Update fr.po by teamcons · Pull Request #335 · ryonakano/reco · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update fr.po #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 20, 2025
Merged

Update fr.po #335

merged 6 commits into from
May 20, 2025

Conversation

teamcons
Copy link
Contributor
@teamcons teamcons commented May 19, 2025 •
edited
Loading

Hon hon hon baguette

Edit: I just saw the Weblate. Should i cancel this PO, and mirror the language update to it?

@teamcons
Update fr.po
55a6f8c 
Hon hon hon baguette
@ryonakano
Copy link
Owner

Thank you very much for your contribution. I don't understand French so I'm glad! 🎉

Edit: I just saw the Weblate. Should i cancel this PO, and mirror the language update to it?

No, I accept translation updates both through PRs and Weblate in my repositories unlike elementary, because conflicts wouldn't often happen here (I don't use the automatic translation update actions and also there are few active translations who contribute to my repositories in Weblate).

ryonakano
ryonakano reviewed May 19, 2025
View reviewed changes
Copy link
Owner
@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, possibly you edited the .po file with normal editors? If so using dedicated editor like Poedit is recommended. It's provided through Snap officially but community package is also available on Flathub.

teamcons and others added 4 commits May 19, 2025 13:36
@teamcons @ryonakano
Update po/fr.po
b41c855 
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
@teamcons @ryonakano
Update po/fr.po
3fab23e 
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
@teamcons @ryonakano
Update po/fr.po
19e984c 
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
@teamcons
Update fr.po
b171441
8000
@teamcons
Copy link
Contributor Author
teamcons commented May 19, 2025 •
edited
Loading

FYI, possibly you edited the .po file with normal editors? If so using dedicated editor like Poedit is recommended. It's provided through Snap officially but community package is also available on Flathub.

During the day, im at work on a windows box with no admin rights. I try to do what i can with what i have during breaks

But weblate is a good alternative. Missed it at first. It would be suitable instead of poedit i suppose
thank you for your reviews

Thank you very much for your contribution. I don't understand French so I'm glad! 🎉

Terrible language, with terrible grammar and rules. I thought id spare another poor soul from having to do anything in french.

ryonakano
ryonakano approved these changes May 19, 2025
View reviewed changes
Copy link
Owner
@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ryonakano ryonakano merged commit 2bfaee8 into ryonakano:main May 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teamcons @ryonakano
0