8000 interrupts: fix a regex by chaerin16 · Pull Request #244 · ryran/xsos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

interrupts: fix a regex #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

interrupts: fix a regex #244

wants to merge 1 commit into from

Conversation

chaerin16
Copy link
Contributor

I found a bug in the part of interrupts.

In case there is a line like below in /proc/interrupts,
29: 0 0 0 0 0 0 0 0 IR-PCI-MSI-edge 0000:00:11.5

I expected the output will be as below.
29: ........ IR-PCI-MSI-edge 0000:00:11.5

But, actual output is as below.
29: ........ IR-PCI-MSI-edge▊

I checked the source code, and I found the regex is wrong.
According to the source code, it outputs the field as it is only in case the field contains alphabet.
But actually '.' or ':' can be located there, too.
So, I think the regex would be better to change [a-zA-Z] to [^0-9] like this PR.

Thank you.

@chaerin16
interrupts: fix a regex
cf5067d 
fixed the regex that related to interrupt type and name of device.
@superjamie
Copy link
Collaborator

Thanks for this, it works well.

I modified your commit to increment the version number and applied with 5bd2993

@superjamie superjamie closed this Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaerin16 @superjamie
0