Enable HelmOps deployments with strict TLS mode #3806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8227e6d to
7bfb574
Compare
When the agent TLS mode is set to `strict`, the Fleet agent bypasses the operating system's CA store only for the duration of the agent registration process. Once registration is successful, the store can be used again, which enables Helm charts to be pulled from the agent.
No conflicts should happen between `JustBeforeEach` blocks, which resulted in agent TLS mode not being configured as expected.
Expectations run inside a function taking a `Gomega` argument must use that argument.
790a6c3 to
82d32fa
Compare
82d32fa to
7727bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the agent TLS mode is set to
strict, the Fleet agent bypasses the operating system's CA store only for the duration of the agent registration process. Once registration is successful, the store can be used again, which enables Helm charts to be pulled from the agent.This does not compromise on security for the cluster registration process, while exposing HelmOps deployments to the limited risk of failing while cluster (re-)registration is in progress.
A cleaner alternative to this could consist in isolating cluster registration in its own container again, where the OS CA store could be bypassed entirely without affecting the Helm deployer.
Refers to #3589