8000 Replace various function-like macros with inline functions by randombit · Pull Request #2913 · randombit/botan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace various function-like macros with inline functions #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 13, 2022
Merged

Replace various function-like macros with inline functions #2913

merged 6 commits into from
Feb 13, 2022

Conversation

randombit
Copy link
Owner

No description provided.

@randombit
Remove macro usage from ChaCha
1dfa2e5
@randombit
Remove macro usage from Salsa20
96d5b36
@randombit
Remove macro usage from Serpent
04daa2a 
Also consolidate the implementation of the linear operations.

Interestingly, this change allows GCC 11 to auto-vectorize the
baseline version on its own.
@randombit
Remove macro usage from the AES-NI implementation
a8df5f1 
Also convert to using SIMD_4x32 in most cases, in the hope of
eventually consolidating the various HW AES implementations into a
single file.
@randombit
Remove function macros from Threefish-512
d26ebe1
@codecov-commenter
Copy link
codecov-commenter commented Feb 12, 2022 •
edited
Loading

Codecov Report

Merging #2913 (c5972d5) into master (6aead98) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2913      +/-   ##
==========================================
+ Coverage   92.40%   92.41%   +0.01%     
==========================================
  Files         569      569              
  Lines       63688    63770      +82     
  Branches     6237     6235       -2     
==========================================
+ Hits        58851    58934      +83     
+ Misses       4805     4804       -1     
  Partials       32       32
Impacted Files Coverage Δ
src/lib/block/aes/aes_ni/aes_ni.cpp 100.00% <100.00%> (ø)
src/lib/block/serpent/serpent.cpp 100.00% <100.00%> (ø)
...rc/lib/block/serpent/serpent_avx2/serpent_avx2.cpp 100.00% <100.00%> (ø)
...rc/lib/block/serpent/serpent_simd/serpent_simd.cpp 100.00% <100.00%> (ø)
src/lib/block/threefish_512/threefish_512.cpp 100.00% <100.00%> (ø)
src/lib/stream/chacha/chacha.cpp 100.00% <100.00%> (ø)
src/lib/stream/salsa20/salsa20.cpp 100.00% <100.00%> (ø)
src/lib/asn1/der_enc.cpp 83.85% <0.00%> (-2.49%) ⬇️
src/lib/pubkey/dl_group/dl_group.cpp 92.63% <0.00%> (+1.05%) ⬆️
src/lib/pubkey/elgamal/elgamal.cpp 97.29% <0.00%> (+1.35%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aead98...c5972d5. Read the comment docs.

@randombit randombit merged commit a19627a into master Feb 13, 2022
@randombit randombit deleted the jack/remove-fn-macros branch February 13, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randombit @codecov-commenter
0