De-Cython several modules #6920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
approved these changes
Jun 18, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon this while refactoring some other code. There were several
.pyxfiles that had no reason to be in cython. I've moved these to be.pyfiles instead.Pure python modules don't require any compilation, are easier to debug, and can rely on the copious standard tooling for formatting/linting/editor help. There were no reasons for these modules to by in cython, moving them to python.
For reviewers: you might notice the diff isn't just a straight file rename. This is because
blackonly runs on.pyfiles, hence the better formatted code. There are no code changes (beyond reformatting and file name changes) in this PR.