8000 refactor: consistent generic function parameters by richardstrnad · Pull Request #1731 · ratatui/ratatui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: consistent generic function parameters #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor: consistent generic function parameters #1731

wants to merge 1 commit into from

Conversation

richardstrnad
Copy link

Cleanup of where X: Into boundaries to <T: Into>

Related to #1548

@richardstrnad richardstrnad requested a review from a team as a code owner March 20, 2025 10:16
@richardstrnad richardstrnad marked this pull request as draft March 20, 2025 10:16
@richardstrnad richardstrnad changed the title WIP: Consistent generic parameters function parameters refactor: consistent generic parameters function parameters Mar 20, 2025
@richardstrnad richardstrnad changed the title refactor: consistent generic parameters function parameters refactor: consistent generic function parameters Mar 20, 2025
@codecov Codecov
Copy link
codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.84211% with 15 lines in your changes missing coverage. Please review.

Project coverage is 93.0%. Comparing base (2739391) to head (f46f5c9).

Files with missing lines Patch % Lines
ratatui/src/widgets.rs 0.0% 6 Missing ⚠️
ratatui-crossterm/src/lib.rs 0.0% 2 Missing ⚠️
ratatui-widgets/src/barchart.rs 33.3% 2 Missing ⚠️
ratatui-widgets/src/tabs.rs 66.6% 2 Missing ⚠️
ratatui-termwiz/src/lib.rs 0.0% 1 Missing ⚠️
ratatui-widgets/src/block/title.rs 0.0% 1 Missing ⚠️
ratatui-widgets/src/gauge.rs 50.0% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##            main   #1731    +/-   ##
======================================
  Coverage   93.0%   93.0%            
======================================
  Files         80      80            
  Lines      17625   17436   -189     
======================================
- Hits       16395   16225   -170     
+ Misses      1230    1211    -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@richardstrnad
0