-
Notifications
You must be signed in to change notification settings - Fork 536
Refactor Apiserver e2e run in cluster #3529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
machichima
wants to merge
16
commits into
ray-project:master
Choose a base branch
from
machichima:3380-apiserver-e2e-run-in-cluster
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor Apiserver e2e run in cluster #3529
machichima
wants to merge
16
commits into
ray-project:master
from
machichima:3380-apiserver-e2e-run-in-cluster
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directly execute command in the pod instead of through http -e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
with a kubectl exec like behaviour -e Signed-off-by: machichima <nary12321@gmail.com>
machichima
commented
May 3, 2025
…server-e2e-run-in-cluster -e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
27841f7
to
e22ea52
Compare
-e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
…server-e2e-run-in-cluster -e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
…server-e2e-run-in-cluster -e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: Nary Yeh <60069744+machichima@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exec.go
for sending request to apiserver through remote command (similar tokubectl exec
behaviour).exec.go
contains all functions inpkg/http/client.go
, but send through remote commandWhy are these changes needed?
Currently, the KubeRay API server e2e tests rely on accessing the API server via a NodePort exposed through kind's extraPortMappings, defaulting to http://localhost:31888. This approach depends on the local environments. Everything should run inside the Kubernetes cluster.
Related issue number
Closes #3380
Checks