[Core/Observability 1/N] Add a "running" state to task status #24651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
commented
May 10, 2022
src/ray/protobuf/common.proto
Outdated
| // The task is submitted to a worker process to execute. | ||
| SUBMITTED_TO_WORKER = 4; | ||
| // The task has failed to be scheduled and being rescheduled. | ||
| RESCHEDULED = 5; |
There was a problem hiding this comment.
Q: Maybe it is unnecessary, and we can reuse SCHEDULED state here.
|
Btw, one question I have is if "SUBMITTED_TO_WORKER" necessary. I originally wanted to implement "RUNNING", and I realized the current implementation cannot actually become "RUNNING" because for things like actor tasks, we have the execution side queuing (which means we can know the exact state only from the execution side, not a caller (owner) side). This is the full picture |
scv119
reviewed
May 10, 2022
src/ray/protobuf/common.proto
Outdated
| // The task is submitted to a worker process to execute. | ||
| SUBMITTED_TO_WORKER = 4; | ||
| // The task has failed to be scheduled and being rescheduled. | ||
| RESCHEDULED = 5; |
scv119
approved these changes
May 12, 2022
|
We need a bit more work on |
<
8000
/tr>
|
Failed test should be unrelated |
maxpumperla
pushed a commit
that referenced
this pull request
May 18, 2022
This PR adds 2 more states into TaskStatus
enum TaskStatus {
// The task is scheduled properly and waiting for execution.
// It includes time to deliver the task to the remote worker + queueing time
// from the execution side.
WAITING_FOR_EXECUTION = 5;
// The task that is running.
RUNNING = 6;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds 2 more states into
TaskStatusRelated issue number
Checks
scripts/format.shto lint the changes in this PR.