[serve] Handle request with Semaphore #54019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f50a3c0 to
84a4f9e
Compare
|
Mind adding some description on what's the goal of the PR? |
abrarsheikh
reviewed
Jun 23, 2025
python/ray/serve/_private/replica.py
Outdated
| @@ -354,6 +364,7 @@ def __init__( | |||
| self._component_id = self._replica_id.unique_id | |||
| self._configure_logger_and_profilers(self._deployment_config.logging_config) | |||
| self._event_loop = get_or_create_event_loop() | |||
| self._num_queued_requests = 0 | |||
There was a problem hiding this comment.
self._num_queued_requests is not required and can be removed.
There was a problem hiding this comment.
@abrarsheikh resolved at a035ca3
Signed-off-by: doyoung <doyoung@anyscale.com>
Signed-off-by: doyoung <doyoung@anyscale.com>
ce65881 to
a035ca3
Compare
abrarsheikh
approved these changes
Jun 24, 2025
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
This PR updates how the logic on determining if the request can be currently handled or not with Semaphore and number of ongoing requests. --------- Signed-off-by: doyoung <doyoung@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how the logic on determining if the request can be currently handled or not with Semaphore and number of ongoing requests.