[POC] fix test_metrics #54037
Merged
[POC] fix test_metrics #54037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abrar <abrar@anyscale.com>
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix test metrics and update request routing logic.
- In tests, a timeout is added and an assertion is now used to ensure the metric is present immediately.
- In the router, the dynamic replica selection is temporarily replaced with a hardcoded selection of the first replica.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/ray/serve/tests/test_metrics.py | Updated HTTP calls to include timeouts and assertions in test functions |
| python/ray/serve/_private/router.py | Changed replica selection by hardcoding the first replica from the available replicas |
Comments suppressed due to low confidence (1)
python/ray/serve/_private/router.py:628
- Hardcoding the selection of the first replica may lead to non-deterministic behavior and bypasses the intended replica selection logic. It would be preferable to enhance the replica selection process rather than simplifying it to the first available replica.
r = list(self.request_router._replicas.values())[0]
Comment on lines
+195
to
+196
| assert name in metrics | ||
| return True |
There was a problem hiding this comment.
Using an assertion here causes the test to fail immediately instead of waiting for the metric to become available through wait_for_condition. Consider returning a boolean check to allow the wait to work as intended.
Suggested change
| assert name in metrics | |
| return True | |
| if name in metrics: | |
| return True | |
| return False |
Copilot uses AI. Check for mistakes.
Signed-off-by: abrar <abrar@anyscale.com>
zcin
approved these changes
Jun 24, 2025
akyang-anyscale
approved these changes
Jun 24, 2025
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
## Why are these changes needed? Fix test_metrics --------- Signed-off-by: abrar <abrar@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.