Open
[ci] remove ci/keep_alive
#54079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer need to keep printing things to keep alive when running on buildkite Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy ci/keep_alive script and its invocations, as Buildkite no longer requires periodic output to stay alive.
- Deletes the
ci/keep_alivehelper script. - Updates CI entrypoints (
ci.shandbuild-wheel-windows.sh) to call pip and build scripts directly. - Cleans up the
keep_alivefunction definition and any wrapper calls.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/build-wheel-windows.sh | Removed ci/keep_alive wrapper around pip install. |
| ci/keep_alive | Deleted obsolete keep-alive script. |
| ci/ci.sh | Removed keep_alive function and its uses in CI flows. |
Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
|
friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no longer need to keep printing things to keep alive when running on buildkite