[Doc][KubeRay] revert kuberay-gcs-ft.ipynb to markdown #54084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fscnick <fscnick.dev@gmail.com>
step 1-3step 4-6 (skip part of json output for brevity)step 7-10 (with jq to select
|
|
@MortalHappiness PTAL |
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the interactive notebook version of the KubeRay GCS fault tolerance guide back to a static markdown format. The changes include adding the new markdown file (kuberay-gcs-ft.md) and removing the ipynb file (kuberay-gcs-ft.ipynb).
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| doc/source/cluster/kubernetes/user-guides/kuberay-gcs-ft.md | New markdown file containing the GCS fault tolerance guide documentation for KubeRay. |
| doc/source/cluster/kubernetes/user-guides/kuberay-gcs-ft.ipynb | Removal of the interactive notebook version to revert to markdown. |
Comments suppressed due to low confidence (2)
doc/source/cluster/kubernetes/user-guides/kuberay-gcs-ft.md:1
- [nitpick] Verify that the anchor label syntax '(kuberay-gcs-ft)=' meets the project's documentation style guidelines for cross-references.
(kuberay-gcs-ft)=
kevin85421
approved these changes
Jun 25, 2025
|
@fscnick Please ping me when all CI tests pass. |
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Hi @kevin85421 , CI has passed. |
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
…4084) Revert `kuberay-gcs-ft.ipynb` to `kuberay-gcs-ft.md` Closes ray-project#54078 --------- Signed-off-by: fscnick <fscnick.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Revert
kuberay-gcs-ft.ipynbtokuberay-gcs-ft.mdRelated issue number
Closes #54078
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.