[core] Clean up test_locality_aware_leasing_borrowed_objects
#54086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
approved these changes
Jun 25, 2025
| # g will run on head, f_obj will be borrowed by head, and we confirm that | ||
| # h(f_obj) is scheduled onto worker, the node that has f_obj. | ||
| @ray.remote(num_cpus=0) | ||
| def borrower(o: List[ray.ObjectRef]) -> str: |
There was a problem hiding this comment.
qq: why we need a list as input while we only pass in a single element list
There was a problem hiding this comment.
This is intentional so that the task is a "borrower" of the reference itself. If it took the object ref, that would be resolved to its underlying value before the task was invoked.
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
…roject#54086) Clean up `test_locality_aware_leasing_borrowed_objects` to use public API to schedule to specific nodes and make the test behavior a bit more clear. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up
test_locality_aware_leasing_borrowed_objectsto use public API to schedule to specific nodes and make the test behavior a bit more clear.