[serve] Increase default uvicorn keep alive timeout #54127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
abrarsheikh
reviewed
Jun 26, 2025
| @@ -20,7 +20,7 @@ | |||
| DEFAULT_HTTP_PORT = int(os.environ.get("RAY_SERVE_DEFAULT_HTTP_PORT", 8000)) | |||
|
|
|||
| #: Uvicorn timeout_keep_alive Config | |||
| DEFAULT_UVICORN_KEEP_ALIVE_TIMEOUT_S = 5 | |||
| DEFAULT_UVICORN_KEEP_ALIVE_TIMEOUT_S = 90 | |||
There was a problem hiding this comment.
I suggest making this an environment variable, in case if it breaks anything in production, we should be able to easily control it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The current default timeout (5 seconds) is shorter than the default idle timeout on common reverse proxies. This can lead to the connection being terminated on the serve side while the revproxy is writing the request to the connection. This PR increases the default timeout to 90 seconds to mitigate this issue.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.