Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to split the combined dask & modin tests into separate CI steps to accommodate a change in the Python version required for dask.
- Separate CI steps for dask tests and modin tests
- Updated command parameters and labels to reflect the split
Comments suppressed due to low confidence (1)
.buildkite/core.rayci.yml:193
- The removal of the '--parallelism-per-worker 2' parameter in the modin tests step may affect test execution concurrency. Please confirm if this is intentional or if a similar parallelism configuration should be applied for modin tests as well.
--build-name datalbuild
dask will need to use a different python version after upgrade Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
df0ae4a to
d845cb3
Compare
|
this is for accepting changes from #52589 which needs to run dask tests on python 3.12+ |
|
I understand the concern on setup overhead. we will hopefully optimize that part out in the next quarter. |
edoakes
approved these changes
Jun 26, 2025
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
dask will need to use a different python version after upgrade Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dask will need to use a different python version after upgrade