[core] Clean up unused FFs #54139
Merged
[core] Clean up unused FFs #54139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israbbani
reviewed
Jun 26, 2025
Comment on lines
-448
to
-450
| if (RayConfig::instance().enable_reap_actor_death()) { | ||
| gcs_actor_manager_.SetPreemptedAndPublish(node_id); | ||
| } |
There was a problem hiding this comment.
At first glance, the description of the config and what it's being used for don't look related 😞
israbbani
approved these changes
Jun 26, 2025
8 tasks
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
- `isolate_workers_across_resource_types`: totally unused - `isolate_workers_across_task_types`: totally unused - `enable_reap_actor_death`: on by default for a long time with a TODO to remove it Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isolate_workers_across_resource_types: totally unusedisolate_workers_across_task_types: totally unusedenable_reap_actor_death: on by default for a long time with a TODO to remove it