8000 [core] Support `.options` chaining in `actor.options` by chebbyChefNEQ · Pull Request #51836 · ray-project/ray · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[core] Support .options chaining in actor.options #51836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[core] Support .options chaining in actor.options #51836

wants to merge 2 commits into from

Conversation

chebbyChefNEQ
Copy link
@chebbyChefNEQ chebbyChefNEQ commented Mar 31, 2025 •
edited
Loading

Why are these changes needed?

to support calling actor options like so

actor = actor.options(...)
if condition:
    actor.optoons(...)

Related issue number

Closes #51835

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests

@chebbyChefNEQ
[core] Support .options chaining in actor.options
8f5f422 
Signed-off-by: rmeng <rob.xu.meng@gmail.com>
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Mar 31, 2025
@hainesmichaelc hainesmichaelc added the community-contribution Contributed by the community label Apr 4, 2025
@stale Stale
Copy link
stale bot commented May 6, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 6, 2025
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 22, 2025
@israbbani israbbani added the go add ONLY when ready to merge, run all tests label May 28, 2025
israbbani
israbbani reviewed May 29, 2025
View reviewed changes
Copy link
Contributor
@israbbani israbbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! I've left a few small comments. I've also triggered premerge.

python/ray/actor.py
< 8000 td class="blob-code blob-code-context">
@@ -874,7 +874,18 @@ def method(self):
updated_options["runtime_env"]
)
actor = self
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reuse actor_cls defined a few lines above?

python/ray/actor.py
class ActorOptionWrapper:
def options(self, **options):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add type hints for the function signature?

@israbbani
Copy link
Contributor

@chebbyChefNEQ are you still working on this?

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@israbbani israbbani israbbani left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@israbbani israbbani

Labels
community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Support .options chaining in actor.options
4 participants
@chebbyChefNEQ @israbbani @hainesmichaelc @jcotant1
0