8000 [Data] Fix bug where pandas blocks don't use tensor extension by bveeramani · Pull Request #51868 · ray-project/ray · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Data] Fix bug where pandas blocks don't use tensor extension #51868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Data] Fix bug where pandas blocks don't use tensor extension #51868

wants to merge 1 commit into from

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

If you return a pandas DataFrame containing Torch tensors from your map_batches function, Ray Data won't use the tensor extension type, and this can cause Ray Data to incorrectly estimate the size of resu 8000 lting blocks.

This PR fixes that bug by making PandasBlockBuilder use the same code path used to construct blocks from NumPy batches.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Fix bug
a2d4d8c 
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani bveeramani requested a review from a team as a code owner April 1, 2025 00:26
bveeramani
bveeramani commented Apr 1, 2025
View reviewed changes
python/ray/air/util/tensor_extensions/pandas.py
@@ -1430,22 +1430,3 @@ def _is_boolean(self):
TensorArray._add_arithmetic_ops()
TensorArray._add_comparison_ops()
TensorArray._add_logical_ops()


@PublicAPI(stability="beta")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume no one uses this, but it's technically a public API, so I'm not sure if we should keep it just to be safe.

alexeykudinkin
alexeykudinkin reviewed Apr 1, 2025
View reviewed changes
python/ray/data/_internal/numpy_support.py

if isinstance(column_values, np.ndarray):
# No copy/conversion needed, just keep it verbatim.
return column_values

elif isinstance(column_values, list):
elif isinstance(column_values, (list, pd.Series)):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pd.Series should be handled by the next branch (L#198)

@stale Stale
Copy link
stale bot commented May 7, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 7, 2025
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 22, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 8, 2025

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 8, 2025
@github-actions GitHub Actions
Copy link

This pull request has been automatically closed because there has been no more activity in the 14 days
since being marked stale.

Please feel free to reopen or open a new pull request if you'd still like this to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for your contribution!

@github-actions github-actions bot closed this Jun 23, 2025
@bveeramani bveeramani reopened this Jun 23, 2025
@github-actions github-actions bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykudinkin alexeykudinkin alexeykudinkin left review comments

@raulchen raulchen raulchen approved these changes

Assignees

@alexeykudinkin alexeykudinkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bveeramani @alexeykudinkin @raulchen @hainesmichaelc
0