[core] Returning a useful message when trying to get logs for a job that has not started yet #53174
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has not been started yet. Signed-off-by: irabbani <irabbani@anyscale.com>
| @@ -145,8 +145,13 @@ async def _resolve_job_filename(self, sub_job_id: str) -> Tuple[str, str]: | |||
| logger.info(f"Submission job ID {sub_job_id} not found.") | |||
| return None, None | |||
|
|
|||
| node_id = job_info.driver_node_id | |||
| node_id = target_job.driver_node_id | |||
There was a problem hiding this comment.
qq: was this fixing a bug? does it make sense to write a quick unittest for this function
edoakes
reviewed
May 20, 2025
Comment on lines
+150
to
+154
| if target_job.status == JobStatus.PENDING: | ||
| raise ValueError( | ||
| f"Job {sub_job_id} is still {JobStatus.PENDING}." | ||
| "Since it has not started yet, there are no logs available yet." | ||
| ) |
There was a problem hiding this comment.
I believe this will result in a 500 internal server error (which is not ideal)
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] Returning a useful message when trying to get logs for a job that has not been started yet.
This was reported by an OSS user.