8000 fix: Type of AlgorithmConfig.training(learner_connector by Daraan · Pull Request #53369 · ray-project/ray · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Type of AlgorithmConfig.training(learner_connector #53369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Type of AlgorithmConfig.training(learner_connector #53369

wants to merge 3 commits into from
+4 −1

Conversation

Daraan
Copy link
Contributor
@Daraan Daraan commented May 28, 2025

The type of the AlgorithmConfig.traning(learner_connector attribute is wrong. It should be two gym.Space obj 8000 ects and not one single positional RLModule parameter.

Related issue number

Fixes: #53368

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [NA] Unit tests
    • [NA] Release tests
    • [NA] This PR is not tested :(
    • Typing changes only

@Daraan Daraan requested a review from a team as a code owner May 28, 2025 14:56
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added stale The issue is stale. It will be closed within 7 days unless there are further conversation and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Jun 18, 2025
@Daraan
fix: Type of AlgorithmConfig.training(learner_connector
ba0ef1a 
Signed-off-by: Daraan <github.blurry@9ox.net>
@Daraan Daraan force-pushed the typing/correct-learner_connector branch from 2bb1995 to ba0ef1a Compare June 25, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLlib] Type of AlgorithmConfig.training(learner_connector is wrong
1 participant
@Daraan
0