consume autoscaling metrics from both handle and replica #53453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abrar <abrar@anyscale.com>
zcin
approved these changes
May 30, 2025
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jun 3, 2025
…#53453) The additional check on read is redundant because the writer of metrics already ensures exclusivity. Had to increase timeout on 2 tests. I dont know why it was failing. Best guess is that its a timing issue --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: Vicky Tsang <vtsang@amd.com>
iamjustinhsu
pushed a commit
to iamjustinhsu/ray
that referenced
this pull request
Jun 12, 2025
…#53453) The additional check on read is redundant because the writer of metrics already ensures exclusivity. Had to increase timeout on 2 tests. I dont know why it was failing. Best guess is that its a timing issue --------- Signed-off-by: abrar <abrar@anyscale.com>
rebel-scottlee
pushed a commit
to rebellions-sw/ray
that referenced
this pull request
Jun 21, 2025
…#53453) The additional check on read is redundant because the writer of metrics already ensures exclusivity. Had to increase timeout on 2 tests. I dont know why it was failing. Best guess is that its a timing issue --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: Scott Lee <scott.lee@rebellions.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional check on read is redundant because the writer of metrics already ensures exclusivity.
Had to increase timeout on 2 tests. I dont know why it was failing. Best guess is that its a timing issue