-
Notifications
You must be signed in to change notification settings - Fork 6.5k
[core] Update very old doc message #53557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
doc/source/ray-core/walkthrough.rst
Outdated
@@ -37,7 +37,7 @@ The first step is to import and initialize Ray: | |||
|
|||
.. note:: | |||
|
|||
In recent versions of Ray (>=1.5), ``ray.init()`` is automatically called on the first use of a Ray remote API. | |||
If ``ray.init()`` isn't called explicitly, it will implicitly be called with no arguments on the first use of a Ray remote API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested edit for simplicity (removes passive voice and future tense as well)
If ``ray.init()`` isn't called explicitly, it will implicitly be called with no arguments on the first use of a Ray remote API. | |
Unless you explicitly call ``ray.init()``, the first use of a Ray remote API calls ``ray.init()`` with no arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, just kept the word "implicitly" in there for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested edit for clarity and verb tense. If "you" is not the actor for the call, do you to update to "Unless the code explicitly calls" (or application, etc.; whatever makes sense as doing the calling)
Ray 1.5 isn't new anymore :) --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Ray 1.5 isn't new anymore :) --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Ray 1.5 isn't new anymore :) --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Scott Lee <scott.lee@rebellions.ai>
Ray 1.5 isn't new anymore :)