8000 [core] Update very old doc message by edoakes · Pull Request #53557 · ray-project/ray · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[core] Update very old doc message #53557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2025
Merged

Conversation

edoakes
Copy link
Collaborator
@edoakes edoakes commented Jun 4, 2025

Ray 1.5 isn't new anymore :)

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested a review from a team as a code owner June 4, 2025 18:14
@edoakes edoakes requested a review from a team June 4, 2025 18:15
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Jun 4, 2025
@edoakes edoakes enabled auto-merge (squash) June 4, 2025 18:15
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@github-actions github-actions bot disabled auto-merge June 4, 2025 18:16
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@@ -37,7 +37,7 @@ The first step is to import and initialize Ray:

.. note::

In recent versions of Ray (>=1.5), ``ray.init()`` is automatically called on the first use of a Ray remote API.
If ``ray.init()`` isn't called explicitly, it will implicitly be called with no arguments on the first use of a Ray remote API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested edit for simplicity (removes passive voice and future tense as well)

Suggested change
If ``ray.init()`` isn't called explicitly, it will implicitly be called with no arguments on the first use of a Ray remote API.
Unless you explicitly call ``ray.init()``, the first use of a Ray remote API calls ``ray.init()`` with no arguments.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, just kept the word "implicitly" in there for clarity

Copy link
Contributor
@dstrodtman dstrodtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested edit for clarity and verb tense. If "you" is not the actor for the call, do you to update to "Unless the code explicitly calls" (or application, etc.; whatever makes sense as doing the calling)

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
< 8000 /div>
@edoakes edoakes enabled auto-merge (squash) June 4, 2025 18:30
@edoakes edoakes merged commit 4fd3605 into ray-project:master Jun 4, 2025
6 checks passed
eicherseiji pushed a commit to lk-chen/ray that referenced this pull request Jun 4, 2025
Ray 1.5 isn't new anymore :)

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
iamjustinhsu pushed a commit to iamjustinhsu/ray that referenced this pull request Jun 12, 2025
Ray 1.5 isn't new anymore :)

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
rebel-scottlee pushed a commit to rebellions-sw/ray that referenced this pull request Jun 21, 2025
Ray 1.5 isn't new anymore :)

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Scott Lee <scott.lee@rebellions.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0