-
Notifications
You must be signed in to change notification settings - Fork 6.5k
[core] Remove experimental max_cpu_frac_per_node
#53610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@stephanie-wang you have the most context on this one, could you take a look? |
@matthewdeng is also working on confirming it's unused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage for this was removed in the library layer in #39412.
…es/rm-cpu-max-frac
…es/rm-cpu-max-frac
max_cpu_frac_per_node
max_cpu_frac_per_node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave it to @stephanie-wang but if not i'll come back
We should be good to remove, but I'm going to do a deprecation warning for at least one release before killing it |
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
Introduced for Ray AIR, no longer used by any Ray libraries, but never finished (does not work with autoscaler).
This is exposed in the public
ray.util.placement_group
API, but it is marked experimental with a strong caveat and we aren't aware of any external usage, so going to directly remove it.