8000 [core] Remove experimental `max_cpu_frac_per_node` by edoakes · Pull Request #53610 · ray-project/ray · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[core] Remove experimental max_cpu_frac_per_node #53610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

edoakes
Copy link
Collaborator
@edoakes edoakes commented Jun 6, 2025

Introduced for Ray AIR, no longer used by any Ray libraries, but never finished (does not work with autoscaler).

This is exposed in the public ray.util.placement_group API, but it is marked experimental with a strong caveat and we aren't aware of any external usage, so going to directly remove it.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested review from a team, pcmoritz and raulchen as code owners June 6, 2025 15:16
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Jun 6, 2025
@edoakes edoakes marked this pull request as draft June 6, 2025 15:16
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@jjyao
Copy link
Collaborator
jjyao commented Jun 6, 2025

@stephanie-wang you have the most context on this one, could you take a look?

@edoakes
Copy link
Collaborator Author
edoakes commented Jun 6, 2025

@matthewdeng is also working on confirming it's unused

Copy link
Contributor
@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage for this was removed in the library layer in #39412.

edoakes added 6 commits June 6, 2025 12:43
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes marked this pull request as ready for review June 6, 2025 22:05
@edoakes edoakes changed the title [WIP] Remove experimental max_cpu_frac_per_node [core] Remove experimental max_cpu_frac_per_node Jun 6, 2025
Copy link
Collaborator
@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave it to @stephanie-wang but if not i'll come back

@edoakes
Copy link
Collaborator Author
edoakes commented Jun 10, 2025

We should be good to remove, but I'm going to do a deprecation warning for at least one release before killing it

@edoakes edoakes marked this pull request as draft June 10, 2025 19:35
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0