[ci] bazelize get_contributors script
#53743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR bazelizes the get_contributors script, updates dependency requirements, and applies several fixes.
- Updated comments and dependency versions in requirements files.
- Refactored get_contributors.py to use the BUILD_WORKSPACE_DIRECTORY environment variable and reorganized imports.
- Added a new Bazel build target for the get_contributors binary.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| release/requirements_buildkite.txt | Updated comment formatting for clarity regarding dependency source. |
| release/requirements_buildkite.in | Added tqdm as a dependency for consistency with usage in the script. |
| ci/ray_ci/automation/get_contributors.py | Refactored commit organization logic and fixed git log format. |
| ci/ray_ci/automation/BUILD.bazel | Added a py_binary target for the get_contributors script. |
Comments suppressed due to low confidence (2)
ci/ray_ci/automation/get_contributors.py:67
- The get_category function appears to always yield [NO_CATEGORY] due to the current splitting logic. Consider checking for the existence of the closing ']' or refining the split logic to correctly extract the category from the commit message.
if line[0] == "[":
ci/ray_ci/automation/get_contributors.py:53
- The removal of quotes in the git log format specifier might impact how commit messages with special characters or spaces are handled. Consider verifying that this change produces the intended output.
--pretty=format:%s
bdc31b2 to
321266a
Compare
capturing dependencies, and added some fixes too Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
321266a to
b112725
Compare
khluu
approved these changes
Jun 14, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
capturing dependencies, and added some fixes too Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
rebel-scottlee
pushed a commit
to rebellions-sw/ray
that referenced
this pull request
Jun 21, 2025
capturing dependencies, and added some fixes too Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Scott Lee <scott.lee@rebellions.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capturing dependencies, and added some fixes too