10000 [RLlib] Mixin Layer Design Sketch Up by simonsays1980 · Pull Request #53850 · ray-project/ray · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[RLlib] Mixin Layer Design Sketch Up #53850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[RLlib] Mixin Layer Design Sketch Up #53850

wants to merge 3 commits into from

Conversation

simonsays1980
Copy link
Collaborator
8000

Why are these changes needed?

This PR contains a proposal for a mixin layer design for RLlib's Algorithm class and shows some simple examples of how this design could be implemented

  • rllib/algorithms/rl_algorithm.RLAlgorithm is the base algorithm class derived from Trainable.
  • rllib/algorithms/ppo/ppo_algorithm.PPOAlgorithm derives from the base class and uses the SyncEnvRunnerConcreteMixin to include synchronized online sampling.
  • rllib/algorithms/rl_algorithm_mixins/online_mixins.SyncEnvRunnerConcreteMixin is derived from an abstract EnvRunnerMixin and includes the definition of an (inner mixin layer) SyncEnvRunnerGroup that samples only synchronous.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simonsays1980
Added mixin layer design sketchup.
50dd90e 
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
@simonsays1980
Implemented LearnerMixin and PPOAlgorithm with Mixins. PPO learns.
00ff334 
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
@simonsays1980
First cleanup.
1c313d4 
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
41E4 Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonsays1980
0