[kuberay] log actionable err msg when required TPU node selectors missing #53914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebe8a6 to
c147db6
Compare
davidxia
commented
Jun 18, 2025
| @@ -344,7 +368,7 @@ def test_resource_quantity(input: str, output: int): | |||
| def test_autoscaling_config( | |||
| ray_cr_in: Dict[str, Any], | |||
| expected_config_out: Optional[Dict[str, Any]], | |||
| expected_error: Optional[Exception], | |||
| expected_error: Optional[Type[Exception]], | |||
There was a problem hiding this comment.
fix a type checking error
ryanaoleary
reviewed
Jun 18, 2025
|
cc: @richardsliu |
c147db6 to
ed20a7e
Compare
…sing instead of raising a `KeyError`. The required node selectors are `cloud.google.com/gke-tpu-topology` or `cloud.google.com/gke-tpu-accelerator`. Signed-off-by: David Xia <david@davidxia.com>
ed20a7e to
359cffe
Compare
edoakes
approved these changes
Jun 23, 2025
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
…sing (ray-project#53914) instead of raising a `KeyError`. The required node selectors are `cloud.google.com/gke-tpu-topology` or `cloud.google.com/gke-tpu-accelerator`. ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: David Xia <david@davidxia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of raising a
KeyError. The required node selectors arecloud.google.com/gke-tpu-topologyorcloud.google.com/gke-tpu-accelerator.Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.